Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce librustc_index crate #64778

Merged
merged 5 commits into from
Sep 30, 2019
Merged

Introduce librustc_index crate #64778

merged 5 commits into from
Sep 30, 2019

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented Sep 25, 2019

Closes #50592

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2019
@rust-highfive

This comment has been minimized.

@csmoe csmoe force-pushed the index branch 2 times, most recently from 1fdd5ad to dc8291a Compare September 26, 2019 03:28
@rust-highfive

This comment has been minimized.

@csmoe csmoe changed the title [WIP] Introduce librustc_index crate Introduce librustc_index crate Sep 26, 2019
@csmoe
Copy link
Member Author

csmoe commented Sep 26, 2019

r? @nikomatsakis

@csmoe csmoe force-pushed the index branch 2 times, most recently from c1ccc8d to 6695eab Compare September 26, 2019 07:13
@rust-highfive

This comment has been minimized.

@bors

This comment has been minimized.

src/librustc_index/lib.rs Outdated Show resolved Hide resolved
@rust-highfive

This comment has been minimized.

@csmoe
Copy link
Member Author

csmoe commented Sep 28, 2019

@eddyb almost no changes here, https://github.com/rust-lang/rust/pull/64778/files#diff-1240c4024b5a96328bb0436c2344a020L847, but I cannot figure out where the error came from.

@eddyb
Copy link
Member

eddyb commented Sep 28, 2019

Presumably rustdoc is using a different copy of the IndexVec type?

@bors

This comment has been minimized.

@csmoe csmoe force-pushed the index branch 2 times, most recently from 1f71be4 to e99e1be Compare September 29, 2019 08:49
@rust-highfive

This comment has been minimized.

@bors

This comment has been minimized.

@csmoe csmoe force-pushed the index branch 2 times, most recently from 7bfe2b1 to 71cfa02 Compare September 29, 2019 16:15
@csmoe
Copy link
Member Author

csmoe commented Sep 29, 2019

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned nikomatsakis Sep 29, 2019
@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-29T16:16:03.0765144Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-29T16:16:03.9308289Z ##[command]git config gc.auto 0
2019-09-29T16:16:03.9315403Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-29T16:16:03.9318231Z ##[command]git config --get-all http.proxy
2019-09-29T16:16:03.9325183Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64778/merge:refs/remotes/pull/64778/merge
---
2019-09-29T16:25:56.4042948Z 
2019-09-29T16:25:57.5749384Z error[E0599]: no function or associated item named `new` found for type `rustc::mir::Local` in the current scope
2019-09-29T16:25:57.5750635Z    --> src/librustc_codegen_ssa/mir/block.rs:232:43
2019-09-29T16:25:57.5750916Z     |
2019-09-29T16:25:57.5751237Z 232 |             match self.locals[mir::Local::new(1 + va_list_arg_idx)] {
2019-09-29T16:25:57.5751674Z     |                                           ^^^ function or associated item not found in `rustc::mir::Local`
2019-09-29T16:25:57.5752214Z     = help: items from traits can only be used if the trait is in scope
2019-09-29T16:25:57.5752214Z     = help: items from traits can only be used if the trait is in scope
2019-09-29T16:25:57.5752869Z     = note: the following trait is implemented but not in scope, perhaps add a `use` for it:
2019-09-29T16:25:57.5753114Z             `use rustc_index::vec::Idx;`
2019-09-29T16:25:58.9907442Z error: aborting due to 2 previous errors
2019-09-29T16:25:58.9910973Z 
2019-09-29T16:25:58.9922871Z Some errors have detailed explanations: E0432, E0599.
2019-09-29T16:25:58.9932416Z For more information about an error, try `rustc --explain E0432`.
---
2019-09-29T16:26:05.5367857Z == clock drift check ==
2019-09-29T16:26:05.5388208Z   local time: Sun Sep 29 16:26:05 UTC 2019
2019-09-29T16:26:05.7027017Z   network time: Sun, 29 Sep 2019 16:26:05 GMT
2019-09-29T16:26:05.7030562Z == end clock drift check ==
2019-09-29T16:26:07.0126898Z ##[error]Bash exited with code '1'.
2019-09-29T16:26:07.0164760Z ##[section]Starting: Checkout
2019-09-29T16:26:07.0166707Z ==============================================================================
2019-09-29T16:26:07.0166769Z Task         : Get sources
2019-09-29T16:26:07.0166831Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@eddyb
Copy link
Member

eddyb commented Sep 30, 2019

cc @nikomatsakis

@bors r+

@bors
Copy link
Contributor

bors commented Sep 30, 2019

📌 Commit 64f61c7 has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2019
@bors
Copy link
Contributor

bors commented Sep 30, 2019

⌛ Testing commit 64f61c7 with merge 22bc9e1...

bors added a commit that referenced this pull request Sep 30, 2019
Introduce librustc_index crate

Closes #50592
@bors
Copy link
Contributor

bors commented Sep 30, 2019

☀️ Test successful - checks-azure
Approved by: eddyb
Pushing 22bc9e1 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extract index and bit-set related types into their own crate
6 participants