Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code clarity #64935

Merged
merged 23 commits into from
Oct 1, 2019
Merged

Improve code clarity #64935

merged 23 commits into from
Oct 1, 2019

Commits on Sep 25, 2019

  1. Use saturating_sub where applicable

    @AnthonyMikh
    AnthonyMikh authored Sep 25, 2019
    Configuration menu
    Copy the full SHA
    2cb460e View commit details
    Browse the repository at this point in the history

  2. Use max instead of ifs

    @AnthonyMikh
    AnthonyMikh authored Sep 25, 2019
    Configuration menu
    Copy the full SHA
    e9a93be View commit details
    Browse the repository at this point in the history

  3. Simplify Unicode-aware trimming

    @AnthonyMikh
    AnthonyMikh authored Sep 25, 2019
    Configuration menu
    Copy the full SHA
    4fc5650 View commit details
    Browse the repository at this point in the history

  4. Use map + sum instead of fold for computing Unicode width

    @AnthonyMikh
    AnthonyMikh authored Sep 25, 2019
    Configuration menu
    Copy the full SHA
    d6327e8 View commit details
    Browse the repository at this point in the history

  5. Use Option::map_or where applicable

    @AnthonyMikh
    AnthonyMikh authored Sep 25, 2019
    Configuration menu
    Copy the full SHA
    aef169b View commit details
    Browse the repository at this point in the history

  6. Unify order of variables in chained comparison

    @AnthonyMikh
    AnthonyMikh authored Sep 25, 2019
    Configuration menu
    Copy the full SHA
    9b447e2 View commit details
    Browse the repository at this point in the history

  7. Simplify Emitter::fix_multispan_in_std_macros 

    1. Rewrite `if let` into `match` to return earl and avoid indenting giant block 
2. Assign `spans_updated` only once
    @AnthonyMikh
    AnthonyMikh authored Sep 25, 2019
    Configuration menu
    Copy the full SHA
    f93827f View commit details
    Browse the repository at this point in the history

  8. Use sort_by_key rather than sort_by

    @AnthonyMikh
    AnthonyMikh authored Sep 25, 2019
    Configuration menu
    Copy the full SHA
    ea32862 View commit details
    Browse the repository at this point in the history

  9. Simplify style_or_override

    @AnthonyMikh
    AnthonyMikh authored Sep 25, 2019
    Configuration menu
    Copy the full SHA
    7a0725f View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2019

  1. Revert "Simplify Unicode-aware trimming" 

    `taken` is actually used afterwards
    @AnthonyMikh
    AnthonyMikh authored Sep 26, 2019
    Configuration menu
    Copy the full SHA
    75a7c27 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2019

  1. Simplify code for special case of annotation

    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    7dc953b View commit details
    Browse the repository at this point in the history

  2. Simplify EmitterWriter::get_multispan_max_line_num

    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    6b6a79b View commit details
    Browse the repository at this point in the history

  3. Simplify EmitterWriter::get_max_line_num

    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    7b4c5c6 View commit details
    Browse the repository at this point in the history

  4. Update doc comment for style_or_override

    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    21724ed View commit details
    Browse the repository at this point in the history

  5. Simplify EmitterWriter::emit_suggestion_default 

    Make function return early if source map is not present
    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    7a807c5 View commit details
    Browse the repository at this point in the history

  6. Remove redundant .iter_mut()

    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    9d73176 View commit details
    Browse the repository at this point in the history

  7. Simplify a conditional in collect_annotations 

    Also avoid excessive cloning
    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    55b5428 View commit details
    Browse the repository at this point in the history

  8. Use pattern matching instead of indexing tuples

    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    bb44288 View commit details
    Browse the repository at this point in the history

  9. (fmt) remove trailing whitespaces

    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    e5db5b3 View commit details
    Browse the repository at this point in the history

  10. Fix errors

    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    61bc38e View commit details
    Browse the repository at this point in the history

  11. Ascript type explicitly

    @AnthonyMikh
    AnthonyMikh authored Sep 30, 2019
    Configuration menu
    Copy the full SHA
    515262c View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2019

  1. Hint type for .sum()

    @AnthonyMikh
    AnthonyMikh authored Oct 1, 2019
    Configuration menu
    Copy the full SHA
    fdce416 View commit details
    Browse the repository at this point in the history

  2. Fix borrowck errors 

    Reborrowing doesn't work for loops
    @AnthonyMikh
    AnthonyMikh authored Oct 1, 2019
    Configuration menu
    Copy the full SHA
    50c2a58 View commit details
    Browse the repository at this point in the history