Custom lifetime error for impl item doesn't conform to trait
#65068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Centril
reviewed
Oct 3, 2019
src/librustc/infer/error_reporting/nice_region_error/trait_impl_difference.rs
Outdated
Show resolved
Hide resolved
Centril
reviewed
Oct 3, 2019
src/librustc/infer/error_reporting/nice_region_error/trait_impl_difference.rs
Outdated
Show resolved
Hide resolved
estebank
force-pushed
the
trait-impl-lt-mismatch
branch
from
0e57ace to
be07592
Compare
estebank
commented
Oct 8, 2019
src/librustc/infer/error_reporting/nice_region_error/trait_impl_difference.rs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
trait-impl-lt-mismatch
branch
from
0c58dbf to
1e95b5c
Compare
This comment has been minimized.
This comment has been minimized.
estebank
commented
Oct 15, 2019
|
Ping from triage: @nikomatsakis Can you please review this PR? Thanks |
nikomatsakis
approved these changes
Oct 28, 2019
|
📌 Commit 3aba2d0 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 28, 2019
…nikomatsakis Custom lifetime error for `impl` item doesn't conform to `trait` Partly addresses rust-lang#42706, rust-lang#41343, fix rust-lang#40900.
|
⌛ Testing commit 3aba2d0 with merge e097c19d6d8d9564b54923c2903baad9a990bbb2... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 29, 2019
…nikomatsakis Custom lifetime error for `impl` item doesn't conform to `trait` Partly addresses rust-lang#42706, rust-lang#41343, fix rust-lang#40900.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-review
This causes issues in at least `dist-i586-gnu-i586-i686-musl`, possibly others.
estebank
force-pushed
the
trait-impl-lt-mismatch
branch
from
3aba2d0 to
213fd1f
Compare
|
@bors r=nikomatsakis Made that test ignore x86 targets to get around different platform output discrepancies when a |
|
📌 Commit 213fd1f has been approved by |
bors
added
S-waiting-on-bors
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 30, 2019
…nikomatsakis Custom lifetime error for `impl` item doesn't conform to `trait` Partly addresses rust-lang#42706, rust-lang#41343, fix rust-lang#40900.
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly addresses #42706, #41343, fix #40900.