Add Cow::is_borrowed and Cow::is_owned #65144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TimNN (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
clarfonthey
force-pushed
the
moo
branch
2 times, most recently
from
f3cace4 to
2b767e4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
You can run the tests locally i.e. with |
hellow554
suggested changes
Oct 7, 2019
src/liballoc/borrow.rs
Outdated
| /// #![feature(cow_is_borrowed)] | ||
| /// use std::borrow::Cow; | ||
| /// | ||
| /// let mut cow = Cow::Borrowed("moo"); |
There was a problem hiding this comment.
let cow = Cow::Borrowed("moo");
src/liballoc/borrow.rs
Outdated
| /// let mut cow = Cow::Borrowed("moo"); | ||
| /// assert!(cow.is_borrowed()); | ||
| /// | ||
| /// let mut bull: Cow<'_, str> = Cow::Owned("...moo?".to_string()); |
There was a problem hiding this comment.
let bull: Cow<str> = Cow::Owned("...moo?".to_string());
src/liballoc/borrow.rs
Outdated
Comment on lines
248
to
251
| match *self { | ||
| Borrowed(_) => false, | ||
| Owned(_) => true, | ||
| } |
There was a problem hiding this comment.
Why not: !self.is_borrowed()? (see is_some/is_none, is_ok/is_err)
src/liballoc/borrow.rs
Outdated
| /// #![feature(cow_is_borrowed)] | ||
| /// use std::borrow::Cow; | ||
| /// | ||
| /// let mut cow: Cow<'_, str> = Cow::Owned("moo".to_string()); |
There was a problem hiding this comment.
let cow: Cow<str> = Cow::Owned("moo".to_string());
src/liballoc/borrow.rs
Outdated
| /// let mut cow: Cow<'_, str> = Cow::Owned("moo".to_string()); | ||
| /// assert!(cow.is_owned()); | ||
| /// | ||
| /// let mut bull = Cow::Borrowed("...moo?".to_string()); |
There was a problem hiding this comment.
let bull = Cow::Borrowed("...moo?");
same as above, but if you want to use a String instead do:
let bull: Cow<str> = Cow::Borrowed("...moo?".to_string());
That would make too much sense |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@clarfon you don't like the suggestion: you need to add Line 125 in b5bd31e |
|
Thank you for the comment about the feature flag. I was just convinced that intra-doc links were broken again >< |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Ping from triage. @TimNN can you please review this PR? Thanks. |
|
Removed the links on |
|
@ProgrammaticNajel TimNN seems to be not available. Can you reassign it please? |
|
r? @sfackler |
|
@bors r+ |
|
📌 Commit eeb549b has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 23, 2019
Add Cow::is_borrowed and Cow::is_owned Implements rust-lang#65143.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 23, 2019
Add Cow::is_borrowed and Cow::is_owned Implements rust-lang#65143.
bors
added a commit
that referenced
this pull request
Oct 24, 2019
Rollup of 12 pull requests Successful merges: - #64178 (More Clippy fixes for alloc, core and std) - #65144 (Add Cow::is_borrowed and Cow::is_owned) - #65193 (Lockless LintStore) - #65479 (Add the `matches!( $expr, $pat ) -> bool` macro) - #65518 (Avoid ICE when checking `Destination` of `break` inside a closure) - #65583 (rustc_metadata: use a table for super_predicates, fn_sig, impl_trait_ref.) - #65641 (Derive `Rustc{En,De}codable` for `TokenStream`.) - #65648 (Eliminate `intersect_opt`.) - #65657 (Remove `InternedString`) - #65691 (Update E0659 error code long explanation to 2018 edition) - #65696 (Fix an issue with const inference variables sticking around under Chalk + NLL) - #65704 (relax ExactSizeIterator bound on write_bytes) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #65143.