Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom PartialEq impls for LocalInternedString. #65426

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Remove custom PartialEq impls for LocalInternedString. #65426

merged 1 commit into from
Oct 15, 2019

Conversation

nnethercote
Copy link
Contributor

This is on-trend with the recent changes simplifying
LocalInternedString and reducing its use.

r? @petrochenkov

@nnethercote
Remove custom PartialEq impls for LocalInternedString.
57d33b1 
This is on-trend with the recent changes simplifying
`LocalInternedString` and reducing its use.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2019
@petrochenkov
Copy link
Contributor

I'm surprised how little fallout this had.
Probably because everything using comparisons was converted to symbols earlier.
With this little fallout we can remove this convenience feature.
@bors r+

@bors
Copy link
Contributor

bors commented Oct 15, 2019

📌 Commit 57d33b1 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019
@Centril
Rollup merge of rust-lang#65426 - nnethercote:rm-custom-LocalInterned…
bc3e97a 
…String-PartialEq-impls, r=petrochenkov

Remove custom `PartialEq` impls for `LocalInternedString`.

This is on-trend with the recent changes simplifying
`LocalInternedString` and reducing its use.

r? @petrochenkov
@Centril Centril mentioned this pull request Oct 15, 2019
Merged
bors added a commit that referenced this pull request Oct 15, 2019
@bors
Auto merge of #65433 - Centril:rollup-rzvry15, r=Centril
237d54f 
Rollup of 4 pull requests

Successful merges:

 - #64035 (Stabilize proc macros generating `macro_rules` items)
 - #65376 (syntax: misc extractions)
 - #65426 (Remove custom `PartialEq` impls for `LocalInternedString`.)
 - #65428 (Refactor: Rename `db` locals to `diag`)

Failed merges:

r? @ghost
@bors bors merged commit 57d33b1 into rust-lang:master Oct 15, 2019
phansch added a commit to phansch/rust-clippy that referenced this pull request Oct 15, 2019
@phansch
Rustup to rust-lang/rust#65426
ae6341a
tesuji added a commit to tesuji/rust-clippy that referenced this pull request Oct 15, 2019
@tesuji
rustup rust-lang/rust#65426
69333f7
tesuji added a commit to tesuji/rust-clippy that referenced this pull request Oct 15, 2019
@tesuji
rustup rust-lang/rust#65426
189c006
tesuji added a commit to tesuji/rust-clippy that referenced this pull request Oct 15, 2019
@tesuji
rustup rust-lang/rust#65426
9e566db
@tesuji tesuji mentioned this pull request Oct 15, 2019
Merged
@nnethercote nnethercote deleted the rm-custom-LocalInternedString-PartialEq-impls branch October 15, 2019 21:58
@nnethercote nnethercote mentioned this pull request Oct 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnethercote @petrochenkov @bors @rust-highfive