Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo, books #65445

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Update cargo, books #65445

merged 1 commit into from
Oct 16, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 15, 2019

nomicon

3 commits in 4374786f0b4bf0606b35d5c30a9681f342e5707b..5004ad30d69f93553ceef74439fea2159d1f769e
2019-09-17 18:33:21 +0200 to 2019-10-12 19:52:40 +0200

cargo

12 commits in a429e8cc4614a46a86322a0777a477e2baa83f1c..3a9abe3f065554a7fbc59f440df2baba4a6e47ee
2019-10-04 17:36:12 +0000 to 2019-10-15 15:55:35 +0000

book

7 commits in 04806c80be0f54b1290287e3f85e84bdfc0b6ec7..9bb8b161963fcebc9d9ccd732ba26f42108016d5
2019-10-01 20:20:22 -0400 to 2019-10-14 18:42:55 -0500

rust-by-example

5 commits in a6288e7407a6c4c19ea29de6d43f40c803883f21..0b111eaae36cc4b4997684be853882a59e2c7ca7
2019-10-01 10:09:14 -0300 to 2019-10-14 18:34:25 -0300

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2019
@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-10-15T17:48:18.1973470Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-15T17:48:18.1982882Z ##[command]git config gc.auto 0
2019-10-15T17:48:18.1984732Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-15T17:48:18.1986618Z ##[command]git config --get-all http.proxy
2019-10-15T17:48:18.1989171Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65445/merge:refs/remotes/pull/65445/merge
---
2019-10-15T17:50:30.2353783Z Attempting with retry: docker build --rm -t rust-ci -f /home/vsts/work/1/s/src/ci/docker/mingw-check/Dockerfile /home/vsts/work/1/s/src/ci/docker
2019-10-15T17:50:30.3241351Z Sending build context to Docker daemon  526.3kB
2019-10-15T17:50:30.3242619Z 
2019-10-15T17:50:30.3416379Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:50:30.4547976Z received unexpected HTTP status: 503 Service Unavailable
2019-10-15T17:50:31.5411700Z Sending build context to Docker daemon  526.3kB
2019-10-15T17:50:31.5412589Z 
2019-10-15T17:50:31.5656925Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:50:31.5656925Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:50:31.6020520Z received unexpected HTTP status: 503 Service Unavailable
2019-10-15T17:50:33.6945938Z Sending build context to Docker daemon  526.3kB
2019-10-15T17:50:33.6946817Z 
2019-10-15T17:50:33.7176243Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:50:33.7176243Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:50:33.7604563Z received unexpected HTTP status: 503 Service Unavailable
2019-10-15T17:50:36.8524480Z Sending build context to Docker daemon  526.3kB
2019-10-15T17:50:36.8525219Z 
2019-10-15T17:50:36.8733126Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:50:36.8733126Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:50:36.9209412Z received unexpected HTTP status: 503 Service Unavailable
2019-10-15T17:50:41.0123230Z Sending build context to Docker daemon  526.3kB
2019-10-15T17:50:41.0123645Z 
2019-10-15T17:50:41.0374216Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:50:41.0374216Z Step 1/6 : FROM ubuntu:16.04
2019-10-15T17:50:41.1414004Z received unexpected HTTP status: 503 Service Unavailable
2019-10-15T17:50:41.1443839Z The command has failed after 5 attempts.
2019-10-15T17:50:41.1574540Z ##[error]Bash exited with code '1'.
2019-10-15T17:50:41.1605584Z ##[section]Starting: Checkout
2019-10-15T17:50:41.1607078Z ==============================================================================
2019-10-15T17:50:41.1607121Z Task         : Get sources
2019-10-15T17:50:41.1607157Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Oct 15, 2019

📌 Commit 611bdcc has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2019
@bors
Copy link
Contributor

bors commented Oct 16, 2019

⌛ Testing commit 611bdcc with merge 0b68137d1e135bfe7cc97055b6bc6443c5ed4920...

tmandry added a commit to tmandry/rust that referenced this pull request Oct 16, 2019
…chton

Update cargo, cc, books

Update `cc` to include new parallel building support.

## nomicon

3 commits in 4374786f0b4bf0606b35d5c30a9681f342e5707b..5004ad30d69f93553ceef74439fea2159d1f769e
2019-09-17 18:33:21 +0200 to 2019-10-12 19:52:40 +0200
- further clarify C11 and C/C++11 terminology (rust-lang/nomicon#169)
- atomics: C11 -> C++20 (rust-lang/nomicon#168)
- use sound/unsound terminology

## cargo

12 commits in a429e8cc4614a46a86322a0777a477e2baa83f1c..3a9abe3f065554a7fbc59f440df2baba4a6e47ee
2019-10-04 17:36:12 +0000 to 2019-10-15 15:55:35 +0000
- Fix typo in git index initialization error path (rust-lang/cargo#7512)
- Reject feature flags in a virtual workspace. (rust-lang/cargo#7507)
- Rename `overrides` to `package` in profiles. (rust-lang/cargo#7504)
- Allow publishing with dev-dependencies without a version. (rust-lang/cargo#7333)
- Stabilize cache-messages (rust-lang/cargo#7450)
- don't lock the package cache when cleaning target dir. (rust-lang/cargo#7502)
- Document rustc wrapper (rust-lang/cargo#7499)
- Migrate towards exclusively using serde for `Config` (rust-lang/cargo#7456)
- Re-enable some MSVC tests. (rust-lang/cargo#7492)
- when -Z unstable-options not specified, don't validate --profile (rust-lang/cargo#7489)
- Improve error message for cyclic dependencies (rust-lang/cargo#7470)
- Some minor clippy fixes. (rust-lang/cargo#7484)

## book

7 commits in 04806c80be0f54b1290287e3f85e84bdfc0b6ec7..9bb8b161963fcebc9d9ccd732ba26f42108016d5
2019-10-01 20:20:22 -0400 to 2019-10-14 18:42:55 -0500
- Make a portion of text less ambiguous (rust-lang/book#2092)
- fix heading level (rust-lang/book#2117)
- Add missing "of" before `"duck typing"`. (rust-lang/book#1951)
- ch18-03: no need to debug print destructured int (rust-lang/book#1991)
- Subtle fix to introduce ? on Option in Chapter 9.2 (rust-lang/book#2047)
- make wording clearer (rust-lang/book#1976)
- Update the version of rand we use

## rust-by-example

5 commits in a6288e7407a6c4c19ea29de6d43f40c803883f21..0b111eaae36cc4b4997684be853882a59e2c7ca7
2019-10-01 10:09:14 -0300 to 2019-10-14 18:34:25 -0300
- Some fix to three files (rust-lang/rust-by-example#1280)
- Add reference to Generics (rust-lang/rust-by-example#1281)
- Confusing and long sentence (rust-lang/rust-by-example#1282)
- Explicit mention of slice range meaning (rust-lang/rust-by-example#1277)
- Updated aliasing for nll (rust-lang/rust-by-example#1276)
@tmandry
Copy link
Member

tmandry commented Oct 16, 2019

@bors retry rolled up

bors added a commit that referenced this pull request Oct 16, 2019
Rollup of 2 pull requests

Successful merges:

 - #65445 (Update cargo, cc, books)
 - #65450 (Update clippy)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Oct 16, 2019

⌛ Testing commit 611bdcc with merge f71b456606f33ae90a2ac829d8b634e8ac15abac...

@tmandry
Copy link
Member

tmandry commented Oct 16, 2019

@bors retry
Rollup had a spurious failure in CI

@tmandry tmandry added the A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) label Oct 16, 2019
@bors
Copy link
Contributor

bors commented Oct 16, 2019

⌛ Testing commit 611bdcc with merge a73db1d0f1992526428e59ffa1b37cc625ee2872...

@tmandry
Copy link
Member

tmandry commented Oct 16, 2019

Probable cause of failure in #65457 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 16, 2019
@tmandry
Copy link
Member

tmandry commented Oct 16, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 16, 2019
@tmandry tmandry added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 16, 2019
@ehuss ehuss force-pushed the update-cargo-books branch from 611bdcc to 5bb05a2 Compare October 16, 2019 13:44
@ehuss ehuss changed the title Update cargo, cc, books Update cargo, books Oct 16, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Oct 16, 2019

Removed cc from the update, as it was the cause of the riscv32 error.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 16, 2019

📌 Commit 5bb05a2 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 16, 2019
@ehuss
Copy link
Contributor Author

ehuss commented Oct 16, 2019

@alexcrichton risc-v support was added to cc in rust-lang/cc-rs#428, rust-lang/cc-rs#429, rust-lang/cc-rs#430. I'm not up to speed with how bootstrap interacts with cc, or the consequences of those PRs.

I'd like to move this PR forward without cc and deal with it separately.

I also don't know how the risc-v targets were linking without a risc-v gcc toolchain installed. If you want to give some guidance on what needs to change, I can look at it.

@alexcrichton
Copy link
Member

@ehuss the support there is largely just in the form of defaults, it looks like the default compiler selection just wasn't available. I think this probably falls into one of two buckets:

  • One is that we have a riscv toolchain and it's just not being used. This would be fixed by setting the right CC_... env vars in the containers.
  • Another is, as you pointed out, we don't even have a riscv toolchain. In that case the "detected toolchain" was actually bogus and used it would cause problems. It's possible to configure our build though to not actually need a C toolchain for just producing libstd. I'd have to investigate to see what's the case here.

If there wasn't actually a riscv toolchain at all we probably just need to update rustbuild to stop asserting that one exists for riscv.

@mati865
Copy link
Contributor

mati865 commented Oct 16, 2019

To save your time, it's just libstd build and C toolchains for RISC are not installed.
First PR adding RISC target: #52787

@bors
Copy link
Contributor

bors commented Oct 16, 2019

⌛ Testing commit 5bb05a2 with merge 0e8a4b4...

bors added a commit that referenced this pull request Oct 16, 2019
Update cargo, books

## nomicon

3 commits in 4374786f0b4bf0606b35d5c30a9681f342e5707b..5004ad30d69f93553ceef74439fea2159d1f769e
2019-09-17 18:33:21 +0200 to 2019-10-12 19:52:40 +0200
- further clarify C11 and C/C++11 terminology (rust-lang/nomicon#169)
- atomics: C11 -> C++20 (rust-lang/nomicon#168)
- use sound/unsound terminology

## cargo

12 commits in a429e8cc4614a46a86322a0777a477e2baa83f1c..3a9abe3f065554a7fbc59f440df2baba4a6e47ee
2019-10-04 17:36:12 +0000 to 2019-10-15 15:55:35 +0000
- Fix typo in git index initialization error path (rust-lang/cargo#7512)
- Reject feature flags in a virtual workspace. (rust-lang/cargo#7507)
- Rename `overrides` to `package` in profiles. (rust-lang/cargo#7504)
- Allow publishing with dev-dependencies without a version. (rust-lang/cargo#7333)
- Stabilize cache-messages (rust-lang/cargo#7450)
- don't lock the package cache when cleaning target dir. (rust-lang/cargo#7502)
- Document rustc wrapper (rust-lang/cargo#7499)
- Migrate towards exclusively using serde for `Config` (rust-lang/cargo#7456)
- Re-enable some MSVC tests. (rust-lang/cargo#7492)
- when -Z unstable-options not specified, don't validate --profile (rust-lang/cargo#7489)
- Improve error message for cyclic dependencies (rust-lang/cargo#7470)
- Some minor clippy fixes. (rust-lang/cargo#7484)

## book

7 commits in 04806c80be0f54b1290287e3f85e84bdfc0b6ec7..9bb8b161963fcebc9d9ccd732ba26f42108016d5
2019-10-01 20:20:22 -0400 to 2019-10-14 18:42:55 -0500
- Make a portion of text less ambiguous (rust-lang/book#2092)
- fix heading level (rust-lang/book#2117)
- Add missing "of" before `"duck typing"`. (rust-lang/book#1951)
- ch18-03: no need to debug print destructured int (rust-lang/book#1991)
- Subtle fix to introduce ? on Option in Chapter 9.2 (rust-lang/book#2047)
- make wording clearer (rust-lang/book#1976)
- Update the version of rand we use

## rust-by-example

5 commits in a6288e7407a6c4c19ea29de6d43f40c803883f21..0b111eaae36cc4b4997684be853882a59e2c7ca7
2019-10-01 10:09:14 -0300 to 2019-10-14 18:34:25 -0300
- Some fix to three files (rust-lang/rust-by-example#1280)
- Add reference to Generics (rust-lang/rust-by-example#1281)
- Confusing and long sentence (rust-lang/rust-by-example#1282)
- Explicit mention of slice range meaning (rust-lang/rust-by-example#1277)
- Updated aliasing for nll (rust-lang/rust-by-example#1276)
@bors
Copy link
Contributor

bors commented Oct 16, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing 0e8a4b4 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants