Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest borrowing when it would satisfy an unmet trait bound #65456

Merged
merged 6 commits into from
Nov 18, 2019
Merged

Suggest borrowing when it would satisfy an unmet trait bound #65456

merged 6 commits into from
Nov 18, 2019

Commits on Nov 16, 2019

  1. Tweak code formatting

    @estebank
    estebank committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    405a3dd View commit details
    Browse the repository at this point in the history

  2. Suggest borrowing when it would satisfy an unmet trait bound 

    When there are multiple implementors for the same trait that is present
in an unmet binding, modify the E0277 error to refer to the parent
obligation and verify whether borrowing the argument being passed in
would satisfy the unmet bound. If it would, suggest it.
    @estebank
    estebank committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    f57413b View commit details
    Browse the repository at this point in the history

  3. Modify primary label message to be inline with error message

    @estebank
    estebank committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    970503b View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary note

    @estebank
    estebank committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    0f7f234 View commit details
    Browse the repository at this point in the history

  5. Account for rustc_on_unimplemented

    @estebank
    estebank committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    7a2f3ee View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2019

  1. review comments and fix rebase

    @estebank
    estebank committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    2fe8371 View commit details
    Browse the repository at this point in the history