-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unresolved type span inside async object #65668
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Does this change have a user visible change? |
@estebank error[E0698]: type inside `async` object must be known in this context
--> src/lib.rs:23:25
|
23 | let server = server.serve(hyper::service::make_service_fn(move |_| {
| ^^^^^ cannot infer type for `ME`
|
note: the type is part of the `async` object because of this `await`
--> src/lib.rs:34:5
|
34 | server.await
| ^^^^^^^^^^^^ To: error[E0698]: type inside `async fn` body must be known in this context
--> src/lib.rs:15:13
|
15 | Ok(hyper::service::service_fn(move |req| {
| ^^ cannot infer type for `ME`
|
note: the type is part of the `async fn` body because of this `await`
--> src/lib.rs:24:5
|
24 | server.await
| ^^^^^^^^^^^^
error: aborting due to previous error but I should figure out a test/ui. |
r=me with a test |
Looks good to me, too |
Ping from triage. |
@csmoe can you add a ui test exercising this new code? |
@estebank it's a bit complicated, still trying. |
☔ The latest upstream changes (presumably #66252) made this pull request unmergeable. Please resolve the merge conflicts. |
Pinging once again from triage: Thank you. |
Triage: @csmoe - unfortunately this PR has sat idle for several weeks, I'm marking this as inactive. Please reopen this PR when you're ready to move forward. |
Fix unresolved type span inside async object Closes rust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)
Fix unresolved type span inside async object Closes rust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)
Fix unresolved type span inside async object Closes rust-lang#65180 r? @estebank It's hard to create a minimal repro for that issue, [decided](https://rust-lang.zulipchat.com/#narrow/stream/187312-wg-async-foundations/topic/meeting.202019.2E12.2E17/near/183675659) to give up finding mcve. cc [previous take](rust-lang#65668)
Closes #65180
r? @estebank
cc @nikomatsakis @cramertj