Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

submodules: Bump RLS to 58869107ec162a821a4bee53cdd3f51c84cda3ea #65957

Merged
merged 1 commit into from
Oct 31, 2019
Merged

submodules: Bump RLS to 58869107ec162a821a4bee53cdd3f51c84cda3ea #65957

merged 1 commit into from
Oct 31, 2019

Conversation

Xanewok
Copy link
Member

@Xanewok Xanewok commented Oct 30, 2019 •
edited
Loading

Most importantly it contains rust-lang/rls@d267b49 which fixes the RLS build whenever Clippy is built successfully in Rust CI.

Closes #65944

r? @ghost

@Xanewok
Copy link
Member Author

Xanewok commented Oct 30, 2019

Tested the fix locally and working, so...

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Oct 30, 2019

📌 Commit d7b4dd1 has been approved by Xanewok

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 30, 2019
@bors
Copy link
Contributor

bors commented Oct 30, 2019

⌛ Testing commit d7b4dd1 with merge 6b2a6ed...

bors added a commit that referenced this pull request Oct 30, 2019
@bors
Auto merge of #65957 - Xanewok:update-rls, r=Xanewok
6b2a6ed 
submodules: Bump RLS to 58869107ec162a821a4bee53cdd3f51c84cda3ea

Most importantly it contains rust-lang/rls@d267b49 which fixes the RLS build whenever Clippy is built successfully in Rust CI.

Closes #65944

r? @ghost
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-10-30T08:52:25.9461818Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-30T08:52:25.9667718Z ##[command]git config gc.auto 0
2019-10-30T08:52:25.9761588Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-30T08:52:25.9813491Z ##[command]git config --get-all http.proxy
2019-10-30T08:52:25.9965693Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65957/merge:refs/remotes/pull/65957/merge
---
2019-10-30T10:42:14.8515920Z     Finished release [optimized] target(s) in 11m 17s
2019-10-30T10:44:31.0389658Z Error: there are broken links
2019-10-30T10:44:31.0390675Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html" returned 404 Not Found
2019-10-30T10:44:31.0391087Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html#method.buffer_lint" returned 404 Not Found
2019-10-30T10:44:31.0391558Z  Caused By: "***/tree/master/src/libsyntax/ext/tt" returned 404 Not Found
2019-10-30T10:44:31.0401065Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/fn.parse.html" returned 404 Not Found
2019-10-30T10:44:31.0401869Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_rules/" returned 404 Not Found
2019-10-30T10:44:31.0402601Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/ext/tt/macro_parser/" returned 404 Not Found
2019-10-30T10:44:31.0405770Z  Caused By: "https://github.com/rust-lang/chalk/blob/master/src/test/wf.rs" returned 404 Not Found
---
2019-10-30T10:44:31.0426168Z  Caused By: "https://rust-lang.github.io/chalk/doc/chalk_parse/index.html" returned 404 Not Found
2019-10-30T10:44:31.0426459Z  Caused By: "https://rust-lang.github.io/chalk/doc/chalk/index.html" returned 404 Not Found
2019-10-30T10:44:31.0427085Z  Caused By: "https://rust-lang.github.io/chalk/doc/chalki/index.html" returned 404 Not Found
2019-10-30T10:44:31.0427408Z  Caused By: "https://doc.rust-lang.org/nightly/nightly-rustc/syntax/parse/struct.ParseSess.html" returned 404 Not Found
2019-10-30T10:44:31.0427791Z  Caused By: There was an error while fetching "http://www.cs.bgu.ac.il/%7Ehendlerd/papers/p280-hendler.pdf", http://www.cs.bgu.ac.il/%7Ehendlerd/papers/p280-hendler.pdf: timed out
2019-10-30T10:44:31.0438275Z 
2019-10-30T10:44:31.0439218Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rustbook" "linkcheck" "/checkout/src/doc/rustc-guide"
2019-10-30T10:44:31.0439726Z expected success, got: exit code: 101
2019-10-30T10:44:31.0439873Z 
---
2019-10-30T10:49:36.9366944Z    Compiling toml v0.5.3
2019-10-30T10:49:48.4752341Z    Compiling url v2.1.0
2019-10-30T10:50:20.8382580Z    Compiling cargo_metadata v0.9.0
2019-10-30T10:50:46.0220764Z    Compiling clippy_lints v0.0.212 (/checkout/src/tools/clippy/clippy_lints)
2019-10-30T10:57:11.3468482Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/pull/64675
2019-10-30T10:57:11.3469590Z    |
2019-10-30T10:57:11.3469871Z 12 | #[plugin_registrar]
2019-10-30T10:57:11.3470259Z    | ^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version
2019-10-30T10:57:11.3470506Z    |
---
2019-10-30T11:46:06.0403904Z Verifying status of edition-guide...
2019-10-30T11:46:06.0416813Z Verifying status of rls...
2019-10-30T11:46:06.0431695Z This PR updated 'src/tools/rls', verifying if status is 'test-pass'...
2019-10-30T11:46:06.0443597Z 
2019-10-30T11:46:06.0444432Z ⚠️ We detected that this PR updated 'rls', but its tests failed.
2019-10-30T11:46:06.0444694Z 
2019-10-30T11:46:06.0446186Z If you do intend to update 'rls', please check the error messages above and
2019-10-30T11:46:06.0446534Z commit another update.
2019-10-30T11:46:06.0446620Z 
2019-10-30T11:46:06.0446962Z If you do NOT intend to update 'rls', please ensure you did not accidentally
2019-10-30T11:46:06.0447231Z change the submodule at 'src/tools/rls'. You may ask your reviewer for the
2019-10-30T11:46:06.0447579Z proper steps.
2019-10-30T11:46:06.0468957Z   local time: Wed Oct 30 11:46:06 UTC 2019
2019-10-30T11:46:06.3398489Z   network time: Wed, 30 Oct 2019 11:46:06 GMT
2019-10-30T11:46:06.3398923Z == end clock drift check ==
2019-10-30T11:46:07.3464180Z 
2019-10-30T11:46:07.3464180Z 
2019-10-30T11:46:07.3582407Z ##[error]Bash exited with code '3'.
2019-10-30T11:46:07.3629803Z ##[section]Starting: Checkout
2019-10-30T11:46:07.3632125Z ==============================================================================
2019-10-30T11:46:07.3632184Z Task         : Get sources
2019-10-30T11:46:07.3632252Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-10-30T13:33:42.7779887Z Verifying status of edition-guide...
2019-10-30T13:33:42.7793968Z Verifying status of rls...
2019-10-30T13:33:42.7815760Z This PR updated 'src/tools/rls', verifying if status is 'test-pass'...
2019-10-30T13:33:42.7826878Z 
2019-10-30T13:33:42.7827417Z ⚠️ We detected that this PR updated 'rls', but its tests failed.
2019-10-30T13:33:42.7827474Z 
2019-10-30T13:33:42.7827745Z If you do intend to update 'rls', please check the error messages above and
2019-10-30T13:33:42.7827822Z commit another update.
2019-10-30T13:33:42.7827878Z 
2019-10-30T13:33:42.7828110Z If you do NOT intend to update 'rls', please ensure you did not accidentally
2019-10-30T13:33:42.7828368Z change the submodule at 'src/tools/rls'. You may ask your reviewer for the
2019-10-30T13:33:42.7828621Z proper steps.
2019-10-30T13:33:42.7849131Z   local time: Wed Oct 30 13:33:42 UTC 2019
2019-10-30T13:33:43.0732480Z   network time: Wed, 30 Oct 2019 13:33:43 GMT
2019-10-30T13:33:43.0737489Z == end clock drift check ==
2019-10-30T13:33:45.1926357Z 
2019-10-30T13:33:45.1926357Z 
2019-10-30T13:33:45.2037663Z ##[error]Bash exited with code '3'.
2019-10-30T13:33:45.2073820Z ##[section]Starting: Upload CPU usage statistics
2019-10-30T13:33:45.2080318Z ==============================================================================
2019-10-30T13:33:45.2080424Z Task         : Bash
2019-10-30T13:33:45.2080509Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Oct 30, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 30, 2019
@Xanewok Xanewok mentioned this pull request Oct 30, 2019
Merged
@Xanewok
submodules: Bump RLS to 58869107ec162a821a4bee53cdd3f51c84cda3ea
0658b24 
Most importantly it contains rust-lang/rls@d267b49
which fixes the RLS build whenever Clippy is built successfully in Rust CI.
@Xanewok
Copy link
Member Author

Xanewok commented Oct 30, 2019

Fixed RLS test that was broken in the meantime via rust-lang/rls#1583.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 30, 2019

📌 Commit 0658b24 has been approved by Xanewok

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2019
@bors
Copy link
Contributor

bors commented Oct 30, 2019

⌛ Testing commit 0658b24 with merge 03d537e...

bors added a commit that referenced this pull request Oct 30, 2019
@bors
Auto merge of #65957 - Xanewok:update-rls, r=Xanewok
03d537e 
submodules: Bump RLS to 58869107ec162a821a4bee53cdd3f51c84cda3ea

Most importantly it contains rust-lang/rls@d267b49 which fixes the RLS build whenever Clippy is built successfully in Rust CI.

Closes #65944

r? @ghost
@bors
Copy link
Contributor

bors commented Oct 31, 2019

☀️ Test successful - checks-azure
Approved by: Xanewok
Pushing 03d537e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 31, 2019
@bors bors merged commit 0658b24 into rust-lang:master Oct 31, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #65957!

Tested on commit 03d537e.
Direct link to PR: #65957

🎉 rls on windows: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 31, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#65957!
32182d1 
Tested on commit rust-lang/rust@03d537e.
Direct link to PR: <rust-lang/rust#65957>

🎉 rls on windows: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok, @rust-lang/infra).
@Xanewok Xanewok deleted the update-rls branch October 31, 2019 20:56
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Nov 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rls no longer builds after rust-lang/rust#65904
3 participants
@Xanewok @bors @rust-highfive