No more hidden elements #66123
Merged
No more hidden elements #66123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
no-more-hidden-elements
branch
from
2b37a6f to
f66a331
Compare
|
r? @Dylan-DPC |
kinnison
reviewed
Nov 6, 2019
Comment on lines
+164
to
+167
| function isHidden(elem) { | ||
| return elem.offsetHeight === 0; | ||
| } | ||
|
|
There was a problem hiding this comment.
This function seems odd to have, there's code further down which called an isHidden() function you don't appear to have removed, so is this shadowing one?
There was a problem hiding this comment.
You're absolutely right! I removed the old one.
src/librustdoc/html/static/main.js
Outdated
Comment on lines
2655
to
2656
| handleHashes(); | ||
| highlightSourceLines(); |
There was a problem hiding this comment.
Would it be more future-proof to just call onHashChange() here?
There was a problem hiding this comment.
Took me a while to think about it but I think you're right. I updated the code. Thanks!
hdhoang
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
no-more-hidden-elements
branch
from
bf2b270 to
d4527b7
Compare
kinnison
approved these changes
Nov 7, 2019
|
Then let's wait for your confirmation. :) |
|
looks good to me, ping me when ready to merge |
|
Can confirm functioning. |
|
@bors r+ rollup |
|
📌 Commit d4527b7 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 8, 2019
…nts, r=Dylan-DPC No more hidden elements Fixes rust-lang#66046. Follow-up of rust-lang#66082. r? @kinnison
bors
added a commit
that referenced
this pull request
Nov 8, 2019
Rollup of 8 pull requests Successful merges: - #65554 (Enhance the documentation of BufReader for potential data loss) - #65580 (Add `MaybeUninit` methods `uninit_array`, `slice_get_ref`, `slice_get_mut`) - #66049 (consistent handling of missing sysroot spans) - #66056 (rustc_metadata: Some reorganization of the module structure) - #66123 (No more hidden elements) - #66157 (Improve math log documentation examples) - #66165 (Ignore these tests ,since the called commands doesn't exist in VxWorks) - #66190 (rustc_target: inline abi::FloatTy into abi::Primitive.) Failed merges: - #66188 (`MethodSig` -> `FnSig` & Use it in `ItemKind::Fn`) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66046.
Follow-up of #66082.
r? @kinnison