Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to Extend in Vec::set_len #66360

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Conversation

elichai
Copy link
Contributor

@elichai elichai commented Nov 13, 2019

Fixes #66354

Unrelated to this PR, I think we should stop using ../../std/MODULE and replace it with ../MODULE that way if you're looking at docs in core or alloc clicking at a link won't forward you to std.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2019
@elichai
Copy link
Contributor Author

elichai commented Nov 13, 2019

r? @steveklabnik (https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md says that he's the guy for docs)

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Nov 13, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 13, 2019

📌 Commit 0cd111f has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 14, 2019
Fix link to Exten in Vec::set_len

Fixes rust-lang#66354

Unrelated to this PR, I think we should stop using `../../std/MODULE` and replace it with `../MODULE` that way if you're looking at docs in `core` or `alloc` clicking at a link won't forward you to `std`.
bors added a commit that referenced this pull request Nov 14, 2019
Rollup of 9 pull requests

Successful merges:

 - #66253 (Improve errors after re rebalance coherence)
 - #66264 (fix an ICE in macro's diagnostic message)
 - #66349 (expand source_util macros with def-site context)
 - #66351 (Tweak non-char/numeric in range pattern diagnostic)
 - #66360 (Fix link to Exten in Vec::set_len)
 - #66361 (parser: don't use `unreachable!()` in `fn unexpected`.)
 - #66363 (Improve error message in make_tests)
 - #66369 (compiletest: Obtain timestamps for common inputs only once)
 - #66372 (Fix broken links in Ipv4Addr::is_benchmarking docs)

Failed merges:

r? @ghost
@bors bors merged commit 0cd111f into rust-lang:master Nov 14, 2019
@elichai elichai deleted the 2019-11-vec-link branch November 20, 2019 13:29
@dtolnay dtolnay changed the title Fix link to Exten in Vec::set_len Fix link to Extend in Vec::set_len Mar 24, 2024
@dtolnay dtolnay assigned dtolnay and unassigned steveklabnik Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vec::set_len docs contains dead link to extend
5 participants