Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable if and match in constants behind a feature flag #66507

Merged
merged 14 commits into from
Nov 23, 2019

Commits on Nov 21, 2019

  1. Allow multiple cfgs per comment in "revisions:" tests

    The `//[X]~` syntax filters errors for tests that are run across
    multiple cfgs with  `// revisions:`. This commit extends that syntax to
    accept `//[X,Y]~`, which will match multiple cfgs to the same error
    annotation. This is functionally the same as writing two comments,
    `//[X]~` and `//[Y]~`, but can fit on a single line.
    ecstatic-morse committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    54d51bc View commit details
    Browse the repository at this point in the history
  2. Fix broken incremental test

    This test does not actually emit any warnings, since
    `#![allow(warnings)]` was specified. `compiletest` was erroneously
    ignoring `//~` tests and looking only for `//[X]~` ones. As a result of
    the changes in the previous commit, we now look for `//~` comments in
    incremental tests and expect them to appear in *all* revisions.
    ecstatic-morse committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    701f6e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae22938 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c537f22 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    365d123 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e969fb2 View commit details
    Browse the repository at this point in the history
  7. Allow Downcast projections if const_if_match enabled

    These are generated when matching on enum variants to extract the value
    within. We should have no problem evaluating these, but care should be
    taken that we aren't accidentally allowing some other operation.
    ecstatic-morse committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    a98d20a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    929ff68 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f4b9dc7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ccb6e98 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    26d93f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2019

  1. Reorganize, bless and add tests for const control flow

    This creates a new test directory, `ui/consts/control-flow` to hold
    tests related to control flow in a const context. It also blesses all
    existing tests with the new error messages, and adds new tests for the
    `const_if_match` feature.
    ecstatic-morse committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    5c377f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    25122d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b09bb15 View commit details
    Browse the repository at this point in the history