-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable if
and match
in constants behind a feature flag
#66507
Merged
Merged
Commits on Nov 21, 2019
-
Allow multiple cfgs per comment in "revisions:" tests
The `//[X]~` syntax filters errors for tests that are run across multiple cfgs with `// revisions:`. This commit extends that syntax to accept `//[X,Y]~`, which will match multiple cfgs to the same error annotation. This is functionally the same as writing two comments, `//[X]~` and `//[Y]~`, but can fit on a single line.
Configuration menu - View commit details
-
Copy full SHA for 54d51bc - Browse repository at this point
Copy the full SHA 54d51bcView commit details -
This test does not actually emit any warnings, since `#![allow(warnings)]` was specified. `compiletest` was erroneously ignoring `//~` tests and looking only for `//[X]~` ones. As a result of the changes in the previous commit, we now look for `//~` comments in incremental tests and expect them to appear in *all* revisions.
Configuration menu - View commit details
-
Copy full SHA for 701f6e5 - Browse repository at this point
Copy the full SHA 701f6e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae22938 - Browse repository at this point
Copy the full SHA ae22938View commit details -
Configuration menu - View commit details
-
Copy full SHA for c537f22 - Browse repository at this point
Copy the full SHA c537f22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 365d123 - Browse repository at this point
Copy the full SHA 365d123View commit details -
Configuration menu - View commit details
-
Copy full SHA for e969fb2 - Browse repository at this point
Copy the full SHA e969fb2View commit details -
Allow
Downcast
projections ifconst_if_match
enabledThese are generated when matching on enum variants to extract the value within. We should have no problem evaluating these, but care should be taken that we aren't accidentally allowing some other operation.
Configuration menu - View commit details
-
Copy full SHA for a98d20a - Browse repository at this point
Copy the full SHA a98d20aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 929ff68 - Browse repository at this point
Copy the full SHA 929ff68View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4b9dc7 - Browse repository at this point
Copy the full SHA f4b9dc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccb6e98 - Browse repository at this point
Copy the full SHA ccb6e98View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26d93f3 - Browse repository at this point
Copy the full SHA 26d93f3View commit details
Commits on Nov 22, 2019
-
Reorganize, bless and add tests for const control flow
This creates a new test directory, `ui/consts/control-flow` to hold tests related to control flow in a const context. It also blesses all existing tests with the new error messages, and adds new tests for the `const_if_match` feature.
Configuration menu - View commit details
-
Copy full SHA for 5c377f3 - Browse repository at this point
Copy the full SHA 5c377f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25122d0 - Browse repository at this point
Copy the full SHA 25122d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b09bb15 - Browse repository at this point
Copy the full SHA b09bb15View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.