Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more context to async fn trait error #66526

Merged
merged 5 commits into from
Nov 20, 2019

Conversation

estebank
Copy link
Contributor

Follow up to #65937. Fix #65899.

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2019
@estebank
Copy link
Contributor Author

@gilescope, please take a look at the error code documentation.

@estebank estebank force-pushed the async-fn-trait-information branch from a41034f to 650f653 Compare November 18, 2019 20:44
@estebank estebank force-pushed the async-fn-trait-information branch from 650f653 to e565329 Compare November 18, 2019 23:23
src/librustc_error_codes/error_codes/E0706.md Outdated Show resolved Hide resolved
src/librustc_error_codes/error_codes/E0706.md Outdated Show resolved Hide resolved
src/librustc_error_codes/error_codes/E0706.md Outdated Show resolved Hide resolved
src/librustc_error_codes/error_codes/E0706.md Outdated Show resolved Hide resolved
src/librustc_error_codes/error_codes/E0706.md Outdated Show resolved Hide resolved
src/librustc_error_codes/error_codes/E0706.md Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Nov 19, 2019

r? @Centril

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2019
@Centril
Copy link
Contributor

Centril commented Nov 20, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 20, 2019

📌 Commit a079159 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 20, 2019
…, r=Centril

Add more context to `async fn` trait error

Follow up to rust-lang#65937. Fix rust-lang#65899.
bors added a commit that referenced this pull request Nov 20, 2019
Rollup of 8 pull requests

Successful merges:

 - #65665 (Update Source Code Pro and include italics)
 - #66478 (rustc_plugin: Remove the compatibility shim)
 - #66497 (Fix #53820)
 - #66526 (Add more context to `async fn` trait error)
 - #66532 (Generate DWARF address ranges for faster lookups)
 - #66546 (Remove duplicate function)
 - #66548 ([RISCV] Disable Atomics on all Non-A RISC-V targets)
 - #66553 (remove HermitCore leftovers from sys/unix)

Failed merges:

r? @ghost
@bors bors merged commit a079159 into rust-lang:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more context when trying to write async trait function
6 participants