-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay an is_local_ever_initialized
call.
#66537
Delay an is_local_ever_initialized
call.
#66537
Conversation
This commit moves the call after a `return` that almost always runs. It speeds up the `unicode_normalization` benchmark by about 2%.
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 9651617 with merge b0ffe539b10a02cdb3ff9a220ea27b0b27154e2d... |
☀️ Try build successful - checks-azure |
Queued b0ffe539b10a02cdb3ff9a220ea27b0b27154e2d with parent 0ccee30, future comparison URL. |
Finished benchmarking try commit b0ffe539b10a02cdb3ff9a220ea27b0b27154e2d, comparison URL. |
r? @pnkfelix |
The CI perf results match the local ones: |
📌 Commit 9651617 has been approved by |
@bors rollup |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit 9651617 has been approved by |
@bors rollup=never This is a performance improvement that may mask perf regressions if rolled up. |
…=spastorino Delay an `is_local_ever_initialized` call. This commit moves the call after a `return` that almost always runs. It speeds up the `unicode_normalization` benchmark by about 2%. r? @spastorino
☀️ Test successful - checks-azure |
This commit moves the call after a
return
that almost always runs. Itspeeds up the
unicode_normalization
benchmark by about 2%.r? @spastorino