Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compiler_builtins_lib feature from libstd #66538

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Remove compiler_builtins_lib feature from libstd #66538

merged 1 commit into from
Nov 19, 2019

Conversation

dingelish
Copy link
Contributor

@dingelish dingelish commented Nov 19, 2019

Test if we can close #66368 by this patch.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2019
@Centril
Copy link
Contributor

Centril commented Nov 19, 2019

Seems we can.

r? @Centril @bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 19, 2019

📌 Commit f6b327b has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 19, 2019
Remove compiler_builtins_lib feature from libstd

Test if we can close rust-lang#66368 by this patch.
bors added a commit that referenced this pull request Nov 19, 2019
Rollup of 11 pull requests

Successful merges:

 - #66090 (Misc CI improvements)
 - #66155 (Add long error explanation for E0594)
 - #66239 (Suggest calling async closure when needed)
 - #66430 ([doc] Fix the source code highlighting on source comments)
 - #66431 (Fix 'type annotations needed' error with opaque types)
 - #66461 (Add explanation message for E0641)
 - #66493 (Add JohnTitor to rustc-guide toolstate notification list)
 - #66511 (std::error::Chain: remove Copy)
 - #66529 (resolve: Give derive helpers highest priority during resolution)
 - #66536 (Move the definition of `QueryResult` into `plumbing.rs`.)
 - #66538 (Remove compiler_builtins_lib feature from libstd)

Failed merges:

r? @ghost
@bors bors merged commit f6b327b into rust-lang:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is feature compiler_builtins_lib still needed for libstd?
5 participants