Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point at type in let assignment on type errors #66539

Merged
merged 1 commit into from
Nov 24, 2019
Merged

Point at type in let assignment on type errors #66539

merged 1 commit into from
Nov 24, 2019

Conversation

estebank
Copy link
Contributor

Fix #61067.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Nov 19, 2019

r? @Centril

r=me with refactoring, issue filed, and rustdoc test adjusted

@rust-highfive rust-highfive assigned Centril and unassigned varkor Nov 19, 2019
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2019
@estebank estebank mentioned this pull request Nov 19, 2019
Closed
@estebank
Copy link
Contributor Author

@bors r=Centril

@bors
Copy link
Contributor

bors commented Nov 19, 2019

📌 Commit 67b8d532a83f965d6d36c4f591797b0475df87fb has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 19, 2019
@bors
Copy link
Contributor

bors commented Nov 20, 2019

☔ The latest upstream changes (presumably #66104) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 20, 2019
@estebank
Copy link
Contributor Author

@bors r=Centril

@bors
Copy link
Contributor

bors commented Nov 20, 2019

📌 Commit bca64ce has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 20, 2019
@Centril
Rollup merge of rust-lang#66539 - estebank:let-ty, r=Centril
e6e44cf 
Point at type in `let` assignment on type errors

Fix rust-lang#61067.
@Centril Centril mentioned this pull request Nov 20, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Nov 21, 2019
@Centril
Rollup merge of rust-lang#66539 - estebank:let-ty, r=Centril
6815e4b 
Point at type in `let` assignment on type errors

Fix rust-lang#61067.
@Centril Centril mentioned this pull request Nov 21, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Nov 21, 2019

Failed in #66601 (comment), @bors r-

Use --bless --compare-mode=nll to fix the issue.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 21, 2019
@bors

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Nov 23, 2019

@bors r+

@estebank when you force-push I don't get a notification ;)

@bors
Copy link
Contributor

bors commented Nov 23, 2019

📌 Commit 34f03c0 has been approved by Centril

@bors
Copy link
Contributor

bors commented Nov 23, 2019

🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 23, 2019
@Centril
Rollup merge of rust-lang#66539 - estebank:let-ty, r=Centril
62a7839 
Point at type in `let` assignment on type errors

Fix rust-lang#61067.
@Centril Centril mentioned this pull request Nov 23, 2019
Merged
bors added a commit that referenced this pull request Nov 23, 2019
@bors
Auto merge of #66680 - Centril:rollup-1ke3svj, r=Centril
ad808d9 
Rollup of 5 pull requests

Successful merges:

 - #61351 (Stabilize cfg(doc))
 - #66539 (Point at type in `let` assignment on type errors)
 - #66655 (rustdoc: Mark `--extern-private` as unstable)
 - #66657 (rustdoc: Don't panic when failing to write .lock file)
 - #66673 (Move def collector from `rustc` to `rustc_resolve`)

Failed merges:

r? @ghost
@bors bors merged commit 34f03c0 into rust-lang:master Nov 24, 2019
@bors
Copy link
Contributor

bors commented Nov 24, 2019

☔ The latest upstream changes (presumably #66680) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Point at cause of expectation for type mismatch on let assignments with explicit type
5 participants
@estebank @rust-highfive @Centril @bors @varkor