Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_plugin: Remove support for syntactic plugins #66647

Merged
merged 1 commit into from
Nov 24, 2019
Merged

rustc_plugin: Remove support for syntactic plugins #66647

merged 1 commit into from
Nov 24, 2019

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Nov 22, 2019 •
edited
Loading

This part of the plugin interface was successfully replaced by token-based procedural macros in theory and in practice.

cc #29597
cc #64675
r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2019
@petrochenkov
Copy link
Contributor Author

This is a full version of #64665 (@matklad @Mark-Simulacrum )

Centril
Centril reviewed Nov 22, 2019
View reviewed changes
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 💖

src/librustc_plugin_impl/registry.rs Show resolved Hide resolved
src/librustc_plugin_impl/registry.rs Show resolved Hide resolved
src/test/ui-fulldeps/plugin-args-2.rs Show resolved Hide resolved
src/test/ui-fulldeps/plugin-as-extern-crate.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Nov 22, 2019

r=me with comments addressed (except for the second re. llvm)

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2019
@petrochenkov
Copy link
Contributor Author

ping @rust-lang/compiler @rust-lang/lang
This PR removes user-defined syntax extensions.
Please leave a comment if you think this needs an FCP.

@joshtriplett
Copy link
Member

I think I remember us already signing off on the removal of plugins in another issue? I don't think we need to sign off again.

@petrochenkov
Copy link
Contributor Author

@bors r=Centril

@bors
Copy link
Contributor

bors commented Nov 24, 2019

📌 Commit f89e6c8 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2019
@bors
Copy link
Contributor

bors commented Nov 24, 2019

⌛ Testing commit f89e6c8 with merge 412f43a...

bors added a commit that referenced this pull request Nov 24, 2019
@bors
Auto merge of #66647 - petrochenkov:nosynt, r=Centril
412f43a 
rustc_plugin: Remove support for syntactic plugins

This part of the plugin interface was successfully replaced by token-based procedural macros in theory and in practice.

cc #29597
cc #64675
r? @Centril
@bors bors mentioned this pull request Nov 24, 2019
Merged
@bors
Copy link
Contributor

bors commented Nov 24, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 412f43a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 24, 2019
@bors bors merged commit f89e6c8 into rust-lang:master Nov 24, 2019
@bors bors mentioned this pull request Nov 24, 2019
Merged
@ehuss ehuss mentioned this pull request Nov 25, 2019
Merged
bors added a commit to rust-lang/cargo that referenced this pull request Nov 25, 2019
@bors
Auto merge of #7630 - ehuss:remove-plugin-tests, r=alexcrichton
9eb1f0e 
Remove failing plugin tests.

Some rustc plugin features have been removed in rust-lang/rust#66647, so these tests can no longer pass.
@cjgillot cjgillot mentioned this pull request Aug 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petrochenkov @Centril @joshtriplett @bors @rust-highfive