[PERF] further drop changes #66703

matthewjasper · 2019-11-24T14:54:57Z

rust-highfive · 2019-11-24T16:02:47Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-24T14:55:39.3308491Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-24T14:55:39.3321752Z ##[command]git config gc.auto 0
2019-11-24T14:55:39.3325067Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-24T14:55:39.3328446Z ##[command]git config --get-all http.proxy
2019-11-24T14:55:39.3333755Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66703/merge:refs/remotes/pull/66703/merge
---
2019-11-24T15:51:27.2590468Z .................................................................................................... 1600/9282
2019-11-24T15:51:31.9946096Z .................................................................................................... 1700/9282
2019-11-24T15:51:44.8536150Z .............................i...................................................................... 1800/9282
2019-11-24T15:51:51.6425770Z .................................................................................................... 1900/9282
2019-11-24T15:52:06.6937511Z ..............iiiii................................................................................. 2000/9282
2019-11-24T15:52:16.4079683Z .................................................................................................... 2200/9282
2019-11-24T15:52:18.9286340Z .................................................................................................... 2300/9282
2019-11-24T15:52:23.9958948Z .................................................................................................... 2400/9282
2019-11-24T15:52:44.8037726Z .................................................................................................... 2500/9282
---
2019-11-24T15:55:19.6790682Z ..............i...............i..................................................................... 4800/9282
2019-11-24T15:55:29.4375330Z .................................................................................................... 4900/9282
2019-11-24T15:55:34.8258343Z .................................................................................................... 5000/9282
2019-11-24T15:55:43.8892357Z .................................................................................................... 5100/9282
2019-11-24T15:55:49.7006340Z ...................ii.ii...........i................................................................ 5200/9282
2019-11-24T15:55:58.3623969Z .................................................................................................... 5400/9282
2019-11-24T15:56:08.7734634Z .................................................................................................... 5500/9282
2019-11-24T15:56:15.9358456Z .i.................................................................................................. 5600/9282
2019-11-24T15:56:21.2858124Z .................................................................................................... 5700/9282
2019-11-24T15:56:21.2858124Z .................................................................................................... 5700/9282
2019-11-24T15:56:31.0319169Z .......................................................................................i.i..i..ii... 5800/9282
2019-11-24T15:56:52.4305862Z .................................................................................................... 6000/9282
2019-11-24T15:56:59.9651694Z .................................................................................................... 6100/9282
2019-11-24T15:57:04.3988849Z .................................................................................................... 6200/9282
2019-11-24T15:57:04.3988849Z .................................................................................................... 6200/9282
2019-11-24T15:57:17.2240491Z ..........i..ii..................................................................................... 6300/9282
2019-11-24T15:57:35.0183344Z ..............................................................................i..................... 6500/9282
2019-11-24T15:57:37.1792401Z .................................................................................................... 6600/9282
2019-11-24T15:57:39.2727407Z .....................................................................i.............................. 6700/9282
2019-11-24T15:57:42.0930106Z .................................................................................................... 6800/9282
---
2019-11-24T16:02:32.0153873Z  finished in 5.552
2019-11-24T16:02:32.0320564Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-24T16:02:32.2026242Z 
2019-11-24T16:02:32.2026930Z running 157 tests
2019-11-24T16:02:34.8418391Z iiii....iii......iii..iiii...i.............................i..i..................i....i...........ii 100/157
2019-11-24T16:02:36.6682864Z .i.i..iiii..............i.........iii.i..........ii......
2019-11-24T16:02:36.6683313Z 
2019-11-24T16:02:36.6690275Z  finished in 4.636
2019-11-24T16:02:36.6875632Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-24T16:02:36.8643479Z 
---
2019-11-24T16:02:38.6923388Z ---- [codegen-units] codegen-units/partitioning/extern-drop-glue.rs stdout ----
2019-11-24T16:02:38.6923443Z 
2019-11-24T16:02:38.6923629Z The following items were assigned to wrong codegen units:
2019-11-24T16:02:38.6923748Z 
2019-11-24T16:02:38.6923826Z fn core::ptr[0]::real_drop_in_place[0]<cgu_extern_drop_glue::Struct[0]>
2019-11-24T16:02:38.6924454Z   expected: extern_drop_glue-mod1[Internal] extern_drop_glue[Internal] 
2019-11-24T16:02:38.6924911Z   actual:   extern_drop_glue-fallback.cgu[Internal] 
2019-11-24T16:02:38.6925012Z 
2019-11-24T16:02:38.6925065Z fn core::ptr[0]::real_drop_in_place[0]<extern_drop_glue::LocalStruct[0]>
2019-11-24T16:02:38.6925152Z   expected: extern_drop_glue[Internal] 
2019-11-24T16:02:38.6925447Z   actual:   extern_drop_glue-fallback.cgu[External] 
2019-11-24T16:02:38.6925496Z 
2019-11-24T16:02:38.6925547Z fn core::ptr[0]::real_drop_in_place[0]<extern_drop_glue::mod1[0]::LocalStruct[0]>
2019-11-24T16:02:38.6926024Z   expected: extern_drop_glue-mod1[Internal] 
2019-11-24T16:02:38.6926466Z   actual:   extern_drop_glue-fallback.cgu[External] 
2019-11-24T16:02:38.6927194Z thread '[codegen-units] codegen-units/partitioning/extern-drop-glue.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:2623:13
2019-11-24T16:02:38.6927421Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-11-24T16:02:38.6927530Z 
2019-11-24T16:02:38.6927874Z ---- [codegen-units] codegen-units/partitioning/local-drop-glue.rs stdout ----
2019-11-24T16:02:38.6927874Z ---- [codegen-units] codegen-units/partitioning/local-drop-glue.rs stdout ----
2019-11-24T16:02:38.6928236Z 
2019-11-24T16:02:38.6928429Z The following items were assigned to wrong codegen units:
2019-11-24T16:02:38.6928471Z 
2019-11-24T16:02:38.6928539Z fn core::ptr[0]::real_drop_in_place[0]<(u32, local_drop_glue::Struct[0])>
2019-11-24T16:02:38.6928932Z   expected: local_drop_glue-mod1[Internal] 
2019-11-24T16:02:38.6929176Z   actual:   local_drop_glue-fallback.cgu[Internal] 
2019-11-24T16:02:38.6929224Z 
2019-11-24T16:02:38.6929412Z fn core::ptr[0]::real_drop_in_place[0]<local_drop_glue::Outer[0]>
2019-11-24T16:02:38.6929550Z   expected: local_drop_glue[Internal] 
2019-11-24T16:02:38.6929839Z   actual:   local_drop_glue-fallback.cgu[External] 
2019-11-24T16:02:38.6929870Z 
2019-11-24T16:02:38.6929920Z fn core::ptr[0]::real_drop_in_place[0]<local_drop_glue::Struct[0]>
2019-11-24T16:02:38.6930359Z   expected: local_drop_glue-mod1[Internal] local_drop_glue[Internal] 
2019-11-24T16:02:38.6930740Z   actual:   local_drop_glue-fallback.cgu[Internal] 
2019-11-24T16:02:38.6930881Z 
2019-11-24T16:02:38.6931005Z fn core::ptr[0]::real_drop_in_place[0]<local_drop_glue::mod1[0]::Struct2[0]>
2019-11-24T16:02:38.6931250Z   expected: local_drop_glue-mod1[Internal] 
2019-11-24T16:02:38.6931617Z   actual:   local_drop_glue-fallback.cgu[External] 
2019-11-24T16:02:38.6932256Z thread '[codegen-units] codegen-units/partitioning/local-drop-glue.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:2623:13
2019-11-24T16:02:38.6932411Z 
2019-11-24T16:02:38.6937149Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-11-24T16:02:38.6937449Z 
---
2019-11-24T16:02:38.6942807Z test result: FAILED. 34 passed; 2 failed; 3 ignored; 0 measured; 0 filtered out
2019-11-24T16:02:38.6955193Z 
2019-11-24T16:02:38.6956913Z 
2019-11-24T16:02:38.6957120Z 
2019-11-24T16:02:38.6959152Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/codegen-units" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-units" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "codegen-units" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-11-24T16:02:38.6959585Z 
2019-11-24T16:02:38.6959705Z 
2019-11-24T16:02:38.6959821Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-11-24T16:02:38.6959937Z Build completed unsuccessfully in 1:01:13
2019-11-24T16:02:38.6959937Z Build completed unsuccessfully in 1:01:13
2019-11-24T16:02:38.7010677Z == clock drift check ==
2019-11-24T16:02:38.7033607Z   local time: Sun Nov 24 16:02:38 UTC 2019
2019-11-24T16:02:39.9338294Z   network time: Sun, 24 Nov 2019 16:02:38 GMT
2019-11-24T16:02:40.9342028Z == end clock drift check ==
2019-11-24T16:02:42.7322231Z 
2019-11-24T16:02:42.7430909Z ##[error]Bash exited with code '1'.
2019-11-24T16:02:42.7467499Z ##[section]Starting: Checkout
2019-11-24T16:02:42.7470096Z ==============================================================================
2019-11-24T16:02:42.7470140Z Task         : Get sources
2019-11-24T16:02:42.7470192Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

matthewjasper · 2019-11-24T16:09:56Z

@bors try @rust-timer queue

rust-timer · 2019-11-24T16:09:57Z

Awaiting bors try build completion

bors · 2019-11-24T16:10:07Z

⌛ Trying commit f09a177 with merge a707b15...

@ghost

[PERF] further drop changes r? @ghost

bors · 2019-11-24T18:51:06Z

☀️ Try build successful - checks-azure
Build commit: a707b15 (a707b15bf8e4506ab59eb603771ed05490beaa3d)

rust-timer · 2019-11-24T18:51:07Z

Queued a707b15 with parent b56b239, future comparison URL.

rust-timer · 2019-11-24T23:23:20Z

Finished benchmarking try commit a707b15, comparison URL.

rust-highfive · 2019-11-30T23:55:58Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-30T22:53:35.7240907Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-30T22:53:35.7533357Z ##[command]git config gc.auto 0
2019-11-30T22:53:35.7592805Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-30T22:53:35.7644953Z ##[command]git config --get-all http.proxy
2019-11-30T22:53:35.7769229Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66703/merge:refs/remotes/pull/66703/merge
---
2019-11-30T23:45:34.0423922Z .................................................................................................... 1600/9312
2019-11-30T23:45:38.0985929Z .................................................................................................... 1700/9312
2019-11-30T23:45:49.2137375Z ........................................i........................................................... 1800/9312
2019-11-30T23:45:55.9384333Z .................................................................................................... 1900/9312
2019-11-30T23:46:08.6929350Z .........................iiiii...................................................................... 2000/9312
2019-11-30T23:46:17.2925879Z .................................................................................................... 2200/9312
2019-11-30T23:46:19.4355558Z .................................................................................................... 2300/9312
2019-11-30T23:46:23.1996440Z .................................................................................................... 2400/9312
2019-11-30T23:46:41.4945638Z .................................................................................................... 2500/9312
---
2019-11-30T23:48:55.7955904Z ...........................i...............i........................................................ 4800/9312
2019-11-30T23:49:04.5495374Z .................................................................................................... 4900/9312
2019-11-30T23:49:09.6669169Z .................................................................................................... 5000/9312
2019-11-30T23:49:16.5744915Z .................................................................................................... 5100/9312
2019-11-30T23:49:23.0154365Z ................................ii.ii...........i................................................... 5200/9312
2019-11-30T23:49:30.9501400Z .................................................................................................... 5400/9312
2019-11-30T23:49:39.8215659Z .................................................................................................... 5500/9312
2019-11-30T23:49:45.4895929Z ..............i..................................................................................... 5600/9312
2019-11-30T23:49:50.9786052Z .................................................................................................... 5700/9312
2019-11-30T23:49:50.9786052Z .................................................................................................... 5700/9312
2019-11-30T23:50:01.4003638Z .................................................................................................... 5800/9312
2019-11-30T23:50:12.6078126Z ii...i..ii............i............................................................................. 5900/9312
2019-11-30T23:50:27.0520622Z .................................................................................................... 6100/9312
2019-11-30T23:50:30.3275714Z .................................................................................................... 6200/9312
2019-11-30T23:50:30.3275714Z .................................................................................................... 6200/9312
2019-11-30T23:50:42.4498954Z .......................i..ii........................................................................ 6300/9312
2019-11-30T23:50:59.7261055Z ...........................................................................................i........ 6500/9312
2019-11-30T23:51:01.6558980Z .................................................................................................... 6600/9312
2019-11-30T23:51:03.5277161Z ..................................................................................i................. 6700/9312
2019-11-30T23:51:05.7559390Z .................................................................................................... 6800/9312
---
2019-11-30T23:55:33.9363484Z  finished in 5.392
2019-11-30T23:55:33.9532400Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-30T23:55:34.1380224Z 
2019-11-30T23:55:34.1380449Z running 164 tests
2019-11-30T23:55:36.5434326Z iiii....iii......iii..iiii...i.............................i..i..................i....i...........ii 100/164
2019-11-30T23:55:38.2313098Z .i.i..iiii..iiiiiii............i.........iii.i..........ii......
2019-11-30T23:55:38.2314538Z 
2019-11-30T23:55:38.2316220Z  finished in 4.278
2019-11-30T23:55:38.2455705Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-11-30T23:55:38.3909763Z 
---
2019-11-30T23:55:40.1084488Z ---- [codegen-units] codegen-units/partitioning/extern-drop-glue.rs stdout ----
2019-11-30T23:55:40.1084584Z 
2019-11-30T23:55:40.1084757Z The following items were assigned to wrong codegen units:
2019-11-30T23:55:40.1084786Z 
2019-11-30T23:55:40.1084865Z fn core::ptr[0]::real_drop_in_place[0]<cgu_extern_drop_glue::Struct[0]>
2019-11-30T23:55:40.1085127Z   expected: extern_drop_glue-mod1[Internal] extern_drop_glue[Internal] 
2019-11-30T23:55:40.1085305Z   actual:   extern_drop_glue-fallback.cgu[Internal] 
2019-11-30T23:55:40.1085349Z 
2019-11-30T23:55:40.1085388Z fn core::ptr[0]::real_drop_in_place[0]<extern_drop_glue::LocalStruct[0]>
2019-11-30T23:55:40.1085437Z   expected: extern_drop_glue[Internal] 
2019-11-30T23:55:40.1085647Z   actual:   extern_drop_glue-fallback.cgu[External] 
2019-11-30T23:55:40.1085763Z 
2019-11-30T23:55:40.1086462Z fn core::ptr[0]::real_drop_in_place[0]<extern_drop_glue::mod1[0]::LocalStruct[0]>
2019-11-30T23:55:40.1087824Z   expected: extern_drop_glue-mod1[Internal] 
2019-11-30T23:55:40.1088038Z   actual:   extern_drop_glue-fallback.cgu[External] 
2019-11-30T23:55:40.1088599Z thread '[codegen-units] codegen-units/partitioning/extern-drop-glue.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:2623:13
2019-11-30T23:55:40.1088986Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-11-30T23:55:40.1089053Z 
2019-11-30T23:55:40.1090639Z ---- [codegen-units] codegen-units/partitioning/local-drop-glue.rs stdout ----
2019-11-30T23:55:40.1090639Z ---- [codegen-units] codegen-units/partitioning/local-drop-glue.rs stdout ----
2019-11-30T23:55:40.1096654Z 
2019-11-30T23:55:40.1097535Z The following items were assigned to wrong codegen units:
2019-11-30T23:55:40.1098329Z 
2019-11-30T23:55:40.1098943Z fn core::ptr[0]::real_drop_in_place[0]<(u32, local_drop_glue::Struct[0])>
2019-11-30T23:55:40.1099862Z   expected: local_drop_glue-mod1[Internal] 
2019-11-30T23:55:40.1100732Z   actual:   local_drop_glue-fallback.cgu[Internal] 
2019-11-30T23:55:40.1101808Z 
2019-11-30T23:55:40.1102345Z fn core::ptr[0]::real_drop_in_place[0]<local_drop_glue::Outer[0]>
2019-11-30T23:55:40.1102855Z   expected: local_drop_glue[Internal] 
2019-11-30T23:55:40.1103698Z   actual:   local_drop_glue-fallback.cgu[External] 
2019-11-30T23:55:40.1103895Z 
2019-11-30T23:55:40.1104417Z fn core::ptr[0]::real_drop_in_place[0]<local_drop_glue::Struct[0]>
2019-11-30T23:55:40.1105180Z   expected: local_drop_glue-mod1[Internal] local_drop_glue[Internal] 
2019-11-30T23:55:40.1105655Z   actual:   local_drop_glue-fallback.cgu[Internal] 
2019-11-30T23:55:40.1105952Z 
2019-11-30T23:55:40.1106477Z fn core::ptr[0]::real_drop_in_place[0]<local_drop_glue::mod1[0]::Struct2[0]>
2019-11-30T23:55:40.1107197Z   expected: local_drop_glue-mod1[Internal] 
2019-11-30T23:55:40.1107724Z   actual:   local_drop_glue-fallback.cgu[External] 
2019-11-30T23:55:40.1108034Z 
2019-11-30T23:55:40.1108548Z fn local_drop_glue::{{impl}}[0]::drop[0]
2019-11-30T23:55:40.1109054Z   expected: local_drop_glue[External] 
2019-11-30T23:55:40.1109756Z   actual:   local_drop_glue-fallback.cgu[External] 
2019-11-30T23:55:40.1110845Z thread '[codegen-units] codegen-units/partitioning/local-drop-glue.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:2623:13
2019-11-30T23:55:40.1111091Z 
2019-11-30T23:55:40.1111804Z 
2019-11-30T23:55:40.1112332Z failures:
---
2019-11-30T23:55:40.1113542Z 
2019-11-30T23:55:40.1114543Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-11-30T23:55:40.1114723Z 
2019-11-30T23:55:40.1114830Z 
2019-11-30T23:55:40.1116499Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/codegen-units" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-units" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "codegen-units" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-11-30T23:55:40.1118156Z 
2019-11-30T23:55:40.1118268Z 
2019-11-30T23:55:40.1118677Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-11-30T23:55:40.1118918Z Build completed unsuccessfully in 0:56:37
2019-11-30T23:55:40.1118918Z Build completed unsuccessfully in 0:56:37
2019-11-30T23:55:40.1169396Z == clock drift check ==
2019-11-30T23:55:40.1187021Z   local time: Sat Nov 30 23:55:40 UTC 2019
2019-11-30T23:55:40.3960527Z   network time: Sat, 30 Nov 2019 23:55:40 GMT
2019-11-30T23:55:40.3963335Z == end clock drift check ==
2019-11-30T23:55:44.8985343Z 
2019-11-30T23:55:44.9071828Z ##[error]Bash exited with code '1'.
2019-11-30T23:55:44.9104793Z ##[section]Starting: Checkout
2019-11-30T23:55:44.9106320Z ==============================================================================
2019-11-30T23:55:44.9106389Z Task         : Get sources
2019-11-30T23:55:44.9106432Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

matthewjasper · 2019-12-01T00:43:40Z

@bors try @rust-timer queue

rust-timer · 2019-12-01T00:43:41Z

Awaiting bors try build completion

bors · 2019-12-01T00:43:51Z

⌛ Trying commit 0cdbe985ed9bab2bbd8658cb4398d1323b41b290 with merge b7050c98084b69b4ad610de6d40401c55e701c84...

bors · 2019-12-01T03:19:25Z

☀️ Try build successful - checks-azure
Build commit: b7050c98084b69b4ad610de6d40401c55e701c84 (b7050c98084b69b4ad610de6d40401c55e701c84)

rust-timer · 2019-12-01T03:19:27Z

Queued b7050c98084b69b4ad610de6d40401c55e701c84 with parent d8bdb3f, future comparison URL.

rust-timer · 2019-12-01T05:53:01Z

Finished benchmarking try commit b7050c98084b69b4ad610de6d40401c55e701c84, comparison URL.

matthewjasper · 2019-12-01T12:04:29Z

@bors try @rust-timer queue

rust-timer · 2019-12-01T12:04:30Z

Awaiting bors try build completion

bors · 2019-12-01T12:04:39Z

⌛ Trying commit 9bb736a7b4c8ebf1985c0fab4befded046992aaa with merge 995015e745a28d4b94e63e2f7daf827dbff40f3d...

tesuji · 2019-12-01T12:10:24Z

src/librustc/ty/instance.rs

-                .map_or(ty.is_enum(), |dtor| tcx.codegen_fn_attrs(dtor.did).requests_inline());
+                .map_or(true, |adt_def| {
+                    adt_def.destructor(tcx)
+                        .map_or(


Maybe using lazy map_or_else is better.

tesuji · 2019-12-01T12:11:56Z

src/librustc_mir/borrow_check/mod.rs

+                flag: _,
                target: _,
                unwind: _,


Maybe using .. in this and other places is better.

rust-highfive · 2019-12-01T13:18:09Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-01T12:04:36.1507984Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-01T12:04:36.1685125Z ##[command]git config gc.auto 0
2019-12-01T12:04:36.1766154Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-01T12:04:36.1859694Z ##[command]git config --get-all http.proxy
2019-12-01T12:04:36.2002555Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66703/merge:refs/remotes/pull/66703/merge
---
2019-12-01T13:05:32.3367801Z .................................................................................................... 1600/9316
2019-12-01T13:05:37.0404515Z .................................................................................................... 1700/9316
2019-12-01T13:05:49.9964909Z ........................................i........................................................... 1800/9316
2019-12-01T13:05:58.0103961Z .................................................................................................... 1900/9316
2019-12-01T13:06:13.2282724Z .........................iiiii...................................................................... 2000/9316
2019-12-01T13:06:23.6042439Z .................................................................................................... 2200/9316
2019-12-01T13:06:26.2622199Z .................................................................................................... 2300/9316
2019-12-01T13:06:30.9842046Z .................................................................................................... 2400/9316
2019-12-01T13:06:53.3495967Z .................................................................................................... 2500/9316
---
2019-12-01T13:09:41.0889785Z ...........................i...............i........................................................ 4800/9316
2019-12-01T13:09:52.1605906Z .................................................................................................... 4900/9316
2019-12-01T13:09:58.4613339Z .................................................................................................... 5000/9316
2019-12-01T13:10:06.9525196Z .................................................................................................... 5100/9316
2019-12-01T13:10:15.0892328Z .................................ii.ii...........i.................................................. 5200/9316
2019-12-01T13:10:25.1773872Z .................................................................................................... 5400/9316
2019-12-01T13:10:35.6903957Z .................................................................................................... 5500/9316
2019-12-01T13:10:43.6569083Z ...............i.................................................................................... 5600/9316
2019-12-01T13:10:52.1969927Z .................................................................................................... 5700/9316
2019-12-01T13:10:52.1969927Z .................................................................................................... 5700/9316
2019-12-01T13:11:04.4450159Z .................................................................................................... 5800/9316
2019-12-01T13:11:17.6014383Z .ii...i..ii...........i............................................................................. 5900/9316
2019-12-01T13:11:36.2170090Z .................................................................................................... 6100/9316
2019-12-01T13:11:41.3788244Z .................................................................................................... 6200/9316
2019-12-01T13:11:41.3788244Z .................................................................................................... 6200/9316
2019-12-01T13:11:55.7555482Z ........................i..ii....................................................................... 6300/9316
2019-12-01T13:12:16.1924632Z ...............................................................................................i.... 6500/9316
2019-12-01T13:12:18.5340561Z .................................................................................................... 6600/9316
2019-12-01T13:12:20.8955941Z ......................................................................................i............. 6700/9316
2019-12-01T13:12:23.7320339Z .................................................................................................... 6800/9316
---
2019-12-01T13:17:51.8690804Z  finished in 6.181
2019-12-01T13:17:51.8895754Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-01T13:17:52.0750192Z 
2019-12-01T13:17:52.0750957Z running 164 tests
2019-12-01T13:17:54.9803963Z iiii....iii......iii..iiii...i.............................i..i..................i....i...........ii 100/164
2019-12-01T13:17:57.0753052Z .i.i..iiii..iiiiiii............i.........iii.i..........ii......
2019-12-01T13:17:57.0756587Z 
2019-12-01T13:17:57.0757889Z  finished in 5.186
2019-12-01T13:17:57.0962217Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-01T13:17:57.2680692Z 
---
2019-12-01T13:17:59.2872744Z ---- [codegen-units] codegen-units/partitioning/extern-drop-glue.rs stdout ----
2019-12-01T13:17:59.2872783Z 
2019-12-01T13:17:59.2872833Z The following items were assigned to wrong codegen units:
2019-12-01T13:17:59.2872883Z 
2019-12-01T13:17:59.2873383Z fn core::ptr[0]::real_drop_in_place[0]<cgu_extern_drop_glue::Struct[0]>
2019-12-01T13:17:59.2873815Z   expected: extern_drop_glue-mod1[Internal] extern_drop_glue[Internal] 
2019-12-01T13:17:59.2874304Z   actual:   extern_drop_glue-fallback.cgu[Internal] 
2019-12-01T13:17:59.2874499Z 
2019-12-01T13:17:59.2874579Z fn core::ptr[0]::real_drop_in_place[0]<extern_drop_glue::LocalStruct[0]>
2019-12-01T13:17:59.2874637Z   expected: extern_drop_glue[Internal] 
2019-12-01T13:17:59.2874961Z   actual:   extern_drop_glue-fallback.cgu[External] 
2019-12-01T13:17:59.2875148Z 
2019-12-01T13:17:59.2876451Z fn core::ptr[0]::real_drop_in_place[0]<extern_drop_glue::mod1[0]::LocalStruct[0]>
2019-12-01T13:17:59.2877088Z   expected: extern_drop_glue-mod1[Internal] 
2019-12-01T13:17:59.2877587Z   actual:   extern_drop_glue-fallback.cgu[External] 
2019-12-01T13:17:59.2878131Z thread '[codegen-units] codegen-units/partitioning/extern-drop-glue.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:2623:13
2019-12-01T13:17:59.2879405Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-01T13:17:59.2879453Z 
2019-12-01T13:17:59.2879844Z ---- [codegen-units] codegen-units/partitioning/local-drop-glue.rs stdout ----
2019-12-01T13:17:59.2879844Z ---- [codegen-units] codegen-units/partitioning/local-drop-glue.rs stdout ----
2019-12-01T13:17:59.2879880Z 
2019-12-01T13:17:59.2879926Z The following items were assigned to wrong codegen units:
2019-12-01T13:17:59.2879970Z 
2019-12-01T13:17:59.2880033Z fn core::ptr[0]::real_drop_in_place[0]<(u32, local_drop_glue::Struct[0])>
2019-12-01T13:17:59.2880264Z   expected: local_drop_glue-mod1[Internal] 
2019-12-01T13:17:59.2880593Z   actual:   local_drop_glue-fallback.cgu[Internal] 
2019-12-01T13:17:59.2880625Z 
2019-12-01T13:17:59.2880688Z fn core::ptr[0]::real_drop_in_place[0]<local_drop_glue::Outer[0]>
2019-12-01T13:17:59.2880735Z   expected: local_drop_glue[Internal] 
2019-12-01T13:17:59.2880989Z   actual:   local_drop_glue-fallback.cgu[External] 
2019-12-01T13:17:59.2881039Z 
2019-12-01T13:17:59.2881086Z fn core::ptr[0]::real_drop_in_place[0]<local_drop_glue::Struct[0]>
2019-12-01T13:17:59.2881358Z   expected: local_drop_glue-mod1[Internal] local_drop_glue[Internal] 
2019-12-01T13:17:59.2881614Z   actual:   local_drop_glue-fallback.cgu[Internal] 
2019-12-01T13:17:59.2881647Z 
2019-12-01T13:17:59.2881693Z fn core::ptr[0]::real_drop_in_place[0]<local_drop_glue::mod1[0]::Struct2[0]>
2019-12-01T13:17:59.2881940Z   expected: local_drop_glue-mod1[Internal] 
2019-12-01T13:17:59.2882204Z   actual:   local_drop_glue-fallback.cgu[External] 
2019-12-01T13:17:59.2882237Z 
2019-12-01T13:17:59.2882279Z fn local_drop_glue::{{impl}}[0]::drop[0]
2019-12-01T13:17:59.2882343Z   expected: local_drop_glue[External] 
2019-12-01T13:17:59.2882582Z   actual:   local_drop_glue-fallback.cgu[External] 
2019-12-01T13:17:59.2882944Z thread '[codegen-units] codegen-units/partitioning/local-drop-glue.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:2623:13
2019-12-01T13:17:59.2883000Z 
2019-12-01T13:17:59.2883026Z 
2019-12-01T13:17:59.2883236Z failures:
---
2019-12-01T13:17:59.2884230Z 
2019-12-01T13:17:59.2887538Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-01T13:17:59.2893830Z 
2019-12-01T13:17:59.2893903Z 
2019-12-01T13:17:59.2895707Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/codegen-units" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen-units" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "codegen-units" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-01T13:17:59.2896192Z 
2019-12-01T13:17:59.2896270Z 
2019-12-01T13:17:59.2906744Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-01T13:17:59.2906815Z Build completed unsuccessfully in 1:07:32
2019-12-01T13:17:59.2906815Z Build completed unsuccessfully in 1:07:32
2019-12-01T13:17:59.2961116Z == clock drift check ==
2019-12-01T13:17:59.2987126Z   local time: Sun Dec  1 13:17:59 UTC 2019
2019-12-01T13:18:00.2110710Z   network time: Sun, 01 Dec 2019 13:17:59 GMT
2019-12-01T13:18:00.2148375Z == end clock drift check ==
2019-12-01T13:18:03.4048129Z 
2019-12-01T13:18:03.4136472Z ##[error]Bash exited with code '1'.
2019-12-01T13:18:03.4199166Z ##[section]Starting: Checkout
2019-12-01T13:18:03.4201043Z ==============================================================================
2019-12-01T13:18:03.4201105Z Task         : Get sources
2019-12-01T13:18:03.4201174Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-12-01T14:39:17Z

☀️ Try build successful - checks-azure
Build commit: 995015e745a28d4b94e63e2f7daf827dbff40f3d (995015e745a28d4b94e63e2f7daf827dbff40f3d)

rust-timer · 2019-12-01T14:39:19Z

Queued 995015e745a28d4b94e63e2f7daf827dbff40f3d with parent 4007d4e, future comparison URL.

rust-timer · 2019-12-01T17:40:42Z

Finished benchmarking try commit 995015e745a28d4b94e63e2f7daf827dbff40f3d, comparison URL.

src/librustc_mir/interpret/terminator.rs

src/librustc/mir/mod.rs

matthewjasper · 2020-02-29T19:47:32Z

@bors try @rust-timer queue

rust-timer · 2020-02-29T19:47:34Z

Awaiting bors try build completion

bors · 2020-02-29T19:47:47Z

⌛ Trying commit ba989b2 with merge e66cbac2cde26b586f2989d64da447e77bac413b...

bors · 2020-02-29T22:50:35Z

☀️ Try build successful - checks-azure
Build commit: e66cbac2cde26b586f2989d64da447e77bac413b (e66cbac2cde26b586f2989d64da447e77bac413b)

rust-timer · 2020-02-29T22:50:37Z

Queued e66cbac2cde26b586f2989d64da447e77bac413b with parent e9bca51, future comparison URL.

Dylan-DPC-zz · 2020-04-17T15:27:16Z

@matthewjasper any updates?

matthewjasper · 2020-04-19T08:32:26Z

Not really, closing for now.

bors added a commit that referenced this pull request Nov 24, 2019

Auto merge of #66703 - matthewjasper:drop-trees, r=<try>

a707b15

[PERF] further drop changes r? @ghost

hdhoang added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 28, 2019

matthewjasper force-pushed the drop-trees branch 2 times, most recently from 6002ebe to ce04564 Compare November 30, 2019 22:20

This comment has been minimized.

Sign in to view

tesuji reviewed Dec 1, 2019

View reviewed changes

matthewjasper reopened this Feb 27, 2020

matthewjasper added 10 commits February 27, 2020 19:56

Temp: Initial test update

d11d586

Temp: Initial impl

82c4fa1

Temp: Cleanup 1

10817cc

Temp: Cleanup 2 (SourceInfo)

dca8121

Temp: Cleanup 3 (comments)

d9a44e6

Temp: Cleanup 4 (resume block)

a6bec9d

Temp: Cleanup 5 (colors)

e41a7c5

Temp: Cleanup 6 (Separate exit trees)

d44233e

Temp: Caching

62fccdc

Temp: More test changes

b4eeee6

RalfJung reviewed Feb 28, 2020

View reviewed changes

src/librustc_mir/interpret/terminator.rs Outdated Show resolved Hide resolved

RalfJung reviewed Feb 28, 2020

View reviewed changes

src/librustc/mir/mod.rs Outdated Show resolved Hide resolved

matthewjasper added 5 commits February 29, 2020 15:13

Reduce the number of drop-flag assignments in unwind paths

ce31497

Temp: Fix a bug

aa6f3e5

Temp: Fix debuginfo

cb7c75b

Make into schedule drop for the destination again

1f5fb7b

Fix mir-opt tests

9a926f9

matthewjasper force-pushed the drop-trees branch from 9bb736a to 9a926f9 Compare February 29, 2020 16:42

Add some more comments

ba989b2

matthewjasper closed this Apr 19, 2020

matthewjasper mentioned this pull request Apr 19, 2020

Panics in destructors can cause the return value to be leaked #47949

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PERF] further drop changes #66703

[PERF] further drop changes #66703

matthewjasper commented Nov 24, 2019

rust-highfive commented Nov 24, 2019

matthewjasper commented Nov 24, 2019

rust-timer commented Nov 24, 2019

bors commented Nov 24, 2019

bors commented Nov 24, 2019

rust-timer commented Nov 24, 2019

rust-timer commented Nov 24, 2019

This comment has been minimized.

rust-highfive commented Nov 30, 2019

matthewjasper commented Dec 1, 2019

rust-timer commented Dec 1, 2019

bors commented Dec 1, 2019

bors commented Dec 1, 2019

rust-timer commented Dec 1, 2019

rust-timer commented Dec 1, 2019

matthewjasper commented Dec 1, 2019

rust-timer commented Dec 1, 2019

bors commented Dec 1, 2019

tesuji Dec 1, 2019

tesuji Dec 1, 2019

rust-highfive commented Dec 1, 2019

bors commented Dec 1, 2019

rust-timer commented Dec 1, 2019

rust-timer commented Dec 1, 2019

matthewjasper commented Feb 29, 2020

rust-timer commented Feb 29, 2020

bors commented Feb 29, 2020

bors commented Feb 29, 2020

rust-timer commented Feb 29, 2020

Dylan-DPC-zz commented Apr 17, 2020

matthewjasper commented Apr 19, 2020

[PERF] further drop changes #66703

[PERF] further drop changes #66703

Conversation

matthewjasper commented Nov 24, 2019

rust-highfive commented Nov 24, 2019

matthewjasper commented Nov 24, 2019

rust-timer commented Nov 24, 2019

bors commented Nov 24, 2019

bors commented Nov 24, 2019

rust-timer commented Nov 24, 2019

rust-timer commented Nov 24, 2019

This comment has been minimized.

rust-highfive commented Nov 30, 2019

matthewjasper commented Dec 1, 2019

rust-timer commented Dec 1, 2019

bors commented Dec 1, 2019

bors commented Dec 1, 2019

rust-timer commented Dec 1, 2019

rust-timer commented Dec 1, 2019

matthewjasper commented Dec 1, 2019

rust-timer commented Dec 1, 2019

bors commented Dec 1, 2019

tesuji Dec 1, 2019

Choose a reason for hiding this comment

tesuji Dec 1, 2019

Choose a reason for hiding this comment

rust-highfive commented Dec 1, 2019

bors commented Dec 1, 2019

rust-timer commented Dec 1, 2019

rust-timer commented Dec 1, 2019

matthewjasper commented Feb 29, 2020

rust-timer commented Feb 29, 2020

bors commented Feb 29, 2020

bors commented Feb 29, 2020

rust-timer commented Feb 29, 2020

Dylan-DPC-zz commented Apr 17, 2020

matthewjasper commented Apr 19, 2020