accept union keyword inside enum when not followed by identifier #66970
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @davidtwco (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
r? @Centril |
|
Thank you @Centril for your suggestion. |
|
Thanks; can you also squash the commits into one? Should be ready to go after that (r=me). |
Centril
added
S-waiting-on-author
Rollup of 7 pull requests Successful merges: - #66346 (Replace .unwrap() with ? in std::os::unix::net) - #66789 (rustc: move mir::SourceScopeLocalData to a field of SourceScopeData.) - #66850 (rustc: hide HirId's fmt::Debug output from -Z span_free_formats.) - #66905 (rustc_plugin: Remove some remaining plugin features) - #66907 (rustc: don't just show raw DefIndex's in BrNamed's fmt::Debug impl.) - #66918 (Add crc and crypto to target feature whitelist on arm) - #66926 (add reusable MachineStop variant to Miri engine error enum) Failed merges: r? @ghost
|
Not sure why you got a merge commit from bors as the first one, but please also squash that into the other commit. Please also avoid mentioning user names with @Centril and such in commit messages as that generates more emails and notifications when you rebase. :) |
|
@Centril I have addressed your concern. |
|
@kamleshbhalui Seems like #66970 (comment) is unresolved? |
|
@Centril is it good now. |
|
@kamalmarhubi Seems like you still have two commits rather than one (where the first is a merge commit)? Not sure how you are rebasing but something is going awry. |
|
I will create different pull request |
Fixes #66943