-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #66978
Rollup of 9 pull requests #66978
Conversation
This commit clarifies some comments, fixes some minor errors in comments, and adds a state transition diagram.
The build process of the unikernel HermitCore is redesigned and doesn't longer depend on libhermit.
add ui test compute enclosing_scope_span on demand add scope test make tidy happy stylistic and typo fixes
The exact same logic was used in check_arms and check_match to build the matrix of relevant patterns. It would actually probably have been a bug if it was not the case, since exhaustiveness checking should be the same as checking reachability of an additional `_ => ...` match branch.
We want the lifetimes of the patterns contained in the matrix and the candidate `PatStack` to be the same so that they can be mixed together. A lot of this would not be necessary if `SmallVec` was covariant in its type argument (see servo/rust-smallvec#146).
Also remove a couple of redundant `visit_mac` asserts
…=davidtwco Add `enclosing scope` parameter to `rustc_on_unimplemented` Adds a new parameter to `#[rustc_on_unimplemented]`, `enclosing scope`, which highlights the function or closure scope with a message. The wip part refers to adding this annotation to `Try` trait to improve ergonomics (which I don't know how to do since I change both std and librustc) Closes rust-lang#61709.
remove dependency from libhermit The build process of the unikernel HermitCore is redesigned and doesn't longer depend on libhermit.
Standard library support for riscv64gc-unknown-linux-gnu Add std support for RISC-V 64-bit GNU/Linux and update libc for RISC-V support. r? @alexcrichton
Adding docs for keyword match, move Partial fix of issue rust-lang#34601.
Miri core engine: use throw_ub instead of throw_panic See rust-lang#66902 for context: panicking is not really an "interpreter error", but just part of a normal Rust execution. This is a first step towards removing the `InterpError::Panic` variant: the core Miri engine does not use it any more. ConstProp and ConstEval still use it, though. This will be addressed in future PRs. From what I can tell, all the error messages this removes are actually duplicates. r? @oli-obk @wesleywiser
syntax: Unify macro and attribute arguments in AST The unified form (`ast::MacArgs`) represents parsed arguments instead of an unstructured token stream that was previously used for attributes. It also tracks some spans and delimiter kinds better for fn-like macros and macro definitions. I've been talking about implementing this with @nnethercote in rust-lang#65750 (comment). The parsed representation is closer to `MetaItem` and requires less token juggling during conversions, so it potentially may be faster. r? @Centril
Remove `ord` lang item At this point it seems to be unused, and just `partial_ord` is used instead. This removes the unused lang item.
Remove hack for top-level or-patterns in match checking Follow-up to rust-lang#66612. Or-patterns are now truly first-class in match checking. As a side-effect, redundant subpatterns are linted as such, making the `unreachable_patterns` lint a bit more general. cc rust-lang#54883 r? @varkor
@bors r+ p=9 rollup=never |
📌 Commit cc3b75a has been approved by |
⌛ Testing commit cc3b75a with merge 7d5afc0dde3bc678e508c9bc7ed148aab5a1defc... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-azure |
@bors retry gonna assume this was spurious |
⌛ Testing commit cc3b75a with merge c63cd183ddb747ba999110e28dfb99268ff0b6ba... |
💔 Test failed - checks-azure |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
I've no idea why this failed, so I'm closing in favor of #66982. |
Successful merges:
NodeState::{Waiting,Done}
#66405 (TweakObligationForest
NodeState
s)enclosing scope
parameter torustc_on_unimplemented
#66651 (Addenclosing scope
parameter torustc_on_unimplemented
)ord
lang item #66941 (Removeord
lang item)Failed merges:
r? @ghost