-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move clean types into their own file #66984
Conversation
bbcf2a3
to
be17771
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
4f692d1
to
de35bb9
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
de35bb9
to
12a2671
Compare
ping @kinnison |
@GuillaumeGomez Okay, I've been through the commit sequence and it looks clean to me. You can squash it down if you want, or else just let Bors know I approve. |
Let's keep the commit history as is then, I kinda like the history flow as it is. :) @bors: r=kinnison |
📌 Commit 12a2671 has been approved by |
…kinnison Move clean types into their own file This PR is just about moving clean types into their own files to make the code more clear and keep all `Clean` trait implementations on their own. r? @kinnison
Seems like it failed in #67111 (comment) ? @bors rollup=never r- |
I ran it locally and no issue. The block code which failed is:
I don't see how it could fail. I think the error comes from somewhere else... @bors: r=kinnison |
📌 Commit 12a2671 has been approved by |
Move clean types into their own file This PR is just about moving clean types into their own files to make the code more clear and keep all `Clean` trait implementations on their own. r? @kinnison
☀️ Test successful - checks-azure |
This PR is just about moving clean types into their own files to make the code more clear and keep all
Clean
trait implementations on their own.r? @kinnison