Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] backports #67063

Merged
merged 15 commits into from
Dec 8, 2019
Merged

[beta] backports #67063

merged 15 commits into from
Dec 8, 2019

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Dec 5, 2019

This pull request backports the following pull requests, which have all been beta-accepted by the
compiler team.

@Mark-Simulacrum
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Dec 6, 2019

📌 Commit 9f7420ba8df3b428ca26984ee2e63ed00d2ba0dc has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 6, 2019
@bors
Copy link
Contributor

bors commented Dec 6, 2019

⌛ Testing commit 9f7420ba8df3b428ca26984ee2e63ed00d2ba0dc with merge dadb03032a6d499c74cdc033285d22d9924f1eeb...

@rust-highfive
Copy link
Collaborator

The job x86_64-apple of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-06T04:28:39.1625850Z diff of stderr:
2019-12-06T04:28:39.1625890Z 
2019-12-06T04:28:39.1626440Z 2   --> $DIR/issue-66357-unexpected-unreachable.rs:12:13
2019-12-06T04:28:39.1626530Z 3    |
2019-12-06T04:28:39.1626610Z 4 LL | fn f() { |[](* }
2019-12-06T04:28:39.1627150Z -    |             ^ expected one of `,` or `:`
2019-12-06T04:28:39.1627260Z +    |             ^ expected one of `,` or `:` here
2019-12-06T04:28:39.1627340Z 6 
2019-12-06T04:28:39.1627910Z 7 error: expected one of `)`, `-`, `_`, `box`, `mut`, `ref`, `|`, identifier, or path, found `*`
2019-12-06T04:28:39.1628570Z 
2019-12-06T04:28:39.1628620Z 
2019-12-06T04:28:39.1628700Z The actual stderr differed from the expected stderr.
2019-12-06T04:28:39.1629420Z Actual stderr saved to /Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/test/ui/parser/issue-66357-unexpected-unreachable/issue-66357-unexpected-unreachable.stderr
2019-12-06T04:28:39.1629420Z Actual stderr saved to /Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/test/ui/parser/issue-66357-unexpected-unreachable/issue-66357-unexpected-unreachable.stderr
2019-12-06T04:28:39.1630030Z To update references, rerun the tests and pass the `--bless` flag
2019-12-06T04:28:39.1630650Z To only update this specific test, also pass `--test-args parser/issue-66357-unexpected-unreachable.rs`
2019-12-06T04:28:39.1630820Z error: 1 errors occurred comparing output.
2019-12-06T04:28:39.1630890Z status: exit code: 1
2019-12-06T04:28:39.1630890Z status: exit code: 1
2019-12-06T04:28:39.1632380Z command: "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.160.1/work/1/s/src/test/ui/parser/issue-66357-unexpected-unreachable.rs" "-Zthreads=1" "--target=x86_64-apple-darwin" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/test/ui/parser/issue-66357-unexpected-unreachable" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "-L" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/test/ui/parser/issue-66357-unexpected-unreachable/auxiliary" "-A" "unused"
2019-12-06T04:28:39.1633330Z ------------------------------------------
2019-12-06T04:28:39.1633400Z 
2019-12-06T04:28:39.1633910Z ------------------------------------------
2019-12-06T04:28:39.1634020Z stderr:
2019-12-06T04:28:39.1634020Z stderr:
2019-12-06T04:28:39.1634540Z ------------------------------------------
2019-12-06T04:28:39.1634630Z error: expected one of `,` or `:`, found `(`
2019-12-06T04:28:39.1635340Z    |
2019-12-06T04:28:39.1635340Z    |
2019-12-06T04:28:39.1635430Z LL | fn f() { |[](* }
2019-12-06T04:28:39.1635500Z    |             ^ expected one of `,` or `:` here
2019-12-06T04:28:39.1635570Z 
2019-12-06T04:28:39.1636150Z error: expected one of `)`, `-`, `_`, `box`, `mut`, `ref`, `|`, identifier, or path, found `*`
2019-12-06T04:28:39.1636910Z    |
2019-12-06T04:28:39.1636910Z    |
2019-12-06T04:28:39.1636980Z LL | fn f() { |[](* }
2019-12-06T04:28:39.1637510Z    |             -^ help: `)` may belong here
2019-12-06T04:28:39.1637680Z    |             unclosed delimiter
2019-12-06T04:28:39.1637740Z 
2019-12-06T04:28:39.1637800Z error: aborting due to 2 previous errors
2019-12-06T04:28:39.1637850Z 
---
2019-12-06T04:28:39.1761340Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-06T04:28:39.1761510Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-06T04:28:39.1779820Z 
2019-12-06T04:28:39.1780000Z 
2019-12-06T04:28:39.1782870Z command did not execute successfully: "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/stage0-tools-bin/compiletest" "--compile-lib-path" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/stage2/lib" "--run-lib-path" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib" "--rustc-path" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "--src-base" "/Users/runner/runners/2.160.1/work/1/s/src/test/ui" "--build-base" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/test/ui" "--stage-id" "stage2-x86_64-apple-darwin" "--mode" "ui" "--target" "x86_64-apple-darwin" "--host" "x86_64-apple-darwin" "--llvm-filecheck" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/usr/local/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--lldb-version" "lldb-902.0.79.2\n  Swift-4.1\n" "--lldb-python-dir" "/Applications/Xcode_9.3.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" "--llvm-version" "9.0.0-rust-1.40.0-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-06T04:28:39.1783720Z 
2019-12-06T04:28:39.1783800Z 
2019-12-06T04:28:39.1792970Z failed to run: /Users/runner/runners/2.160.1/work/1/s/build/bootstrap/debug/bootstrap test
2019-12-06T04:28:39.1793110Z Build completed unsuccessfully in 0:53:30
2019-12-06T04:28:39.1793110Z Build completed unsuccessfully in 0:53:30
2019-12-06T04:28:39.1851610Z == clock drift check ==
2019-12-06T04:28:39.1897710Z   local time: Fri Dec  6 04:28:39 UTC 2019
2019-12-06T04:28:39.2422290Z   network time: Fri, 06 Dec 2019 04:28:39 GMT
2019-12-06T04:28:39.2424310Z == end clock drift check ==
2019-12-06T04:28:39.2459870Z 
2019-12-06T04:28:39.2578150Z ##[error]Bash exited with code '1'.
2019-12-06T04:28:39.2618540Z ##[section]Starting: Checkout
2019-12-06T04:28:39.2621120Z ==============================================================================
2019-12-06T04:28:39.2621240Z Task         : Get sources
2019-12-06T04:28:39.2621320Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Dec 6, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 6, 2019
@weiznich
Copy link
Contributor

weiznich commented Dec 6, 2019

Any chance to get #66983 in here?

@Mark-Simulacrum
Copy link
Member Author

I've beta-nominated that PR but if it doesn't get approved in time by the compiler team, it'll likely slip into stable. I expect we'll be doing at least one more round of backports, though, so I wouldn't worry too much -- as long as that PR is approved (r+), it should get in I imagine (though it's ultimately up to the compiler team).

@weiznich
Copy link
Contributor

weiznich commented Dec 6, 2019

👍
So I better start hitting asking someone from the compiler team to get some feedback for this one.

@Mark-Simulacrum
Copy link
Member Author

@bors r+

Looks like a rebase failure was the cause of the test failure.

@bors
Copy link
Contributor

bors commented Dec 6, 2019

📌 Commit 628dc274607ecf30d7db523f1672c4ce1296042a has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2019
@bors
Copy link
Contributor

bors commented Dec 6, 2019

⌛ Testing commit 628dc274607ecf30d7db523f1672c4ce1296042a with merge abb92a3a417471bc93da7a76787bcccad50bf0fe...

@rust-highfive
Copy link
Collaborator

The job x86_64-apple of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-06T15:00:23.1716760Z 16 
2019-12-06T15:00:23.1716800Z 
2019-12-06T15:00:23.1716960Z 
2019-12-06T15:00:23.1717040Z The actual stderr differed from the expected stderr.
2019-12-06T15:00:23.1717960Z Actual stderr saved to /Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/test/ui/parser/issue-66357-unexpected-unreachable/issue-66357-unexpected-unreachable.stderr
2019-12-06T15:00:23.1719530Z To update references, rerun the tests and pass the `--bless` flag
2019-12-06T15:00:23.1720280Z To only update this specific test, also pass `--test-args parser/issue-66357-unexpected-unreachable.rs`
2019-12-06T15:00:23.1720560Z error: 1 errors occurred comparing output.
2019-12-06T15:00:23.1720680Z status: exit code: 1
2019-12-06T15:00:23.1720680Z status: exit code: 1
2019-12-06T15:00:23.1722280Z command: "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "/Users/runner/runners/2.160.1/work/1/s/src/test/ui/parser/issue-66357-unexpected-unreachable.rs" "-Zthreads=1" "--target=x86_64-apple-darwin" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/test/ui/parser/issue-66357-unexpected-unreachable" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "-L" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/test/ui/parser/issue-66357-unexpected-unreachable/auxiliary" "-A" "unused"
2019-12-06T15:00:23.1723880Z ------------------------------------------
2019-12-06T15:00:23.1723970Z 
2019-12-06T15:00:23.1724590Z ------------------------------------------
2019-12-06T15:00:23.1724760Z stderr:
2019-12-06T15:00:23.1724760Z stderr:
2019-12-06T15:00:23.1725340Z ------------------------------------------
2019-12-06T15:00:23.1725880Z error: expected one of `,` or `:`, found `(`
2019-12-06T15:00:23.1726830Z    |
2019-12-06T15:00:23.1726830Z    |
2019-12-06T15:00:23.1726920Z LL | fn f() { |[](* }
2019-12-06T15:00:23.1727210Z    |             ^ expected one of `,` or `:` here
2019-12-06T15:00:23.1727310Z 
2019-12-06T15:00:23.1727940Z error: expected one of `)`, `-`, `_`, `box`, `mut`, `ref`, `|`, identifier, or path, found `*`
2019-12-06T15:00:23.1728790Z    |
2019-12-06T15:00:23.1728790Z    |
2019-12-06T15:00:23.1728860Z LL | fn f() { |[](* }
2019-12-06T15:00:23.1730030Z    |             -^ help: `)` may belong here
2019-12-06T15:00:23.1730220Z    |             unclosed delimiter
2019-12-06T15:00:23.1730270Z 
2019-12-06T15:00:23.1730340Z error: aborting due to 2 previous errors
2019-12-06T15:00:23.1730390Z 
---
2019-12-06T15:00:23.1903830Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-06T15:00:23.1904050Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-06T15:00:23.2821600Z 
2019-12-06T15:00:23.2821970Z 
2019-12-06T15:00:23.2826480Z command did not execute successfully: "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/stage0-tools-bin/compiletest" "--compile-lib-path" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/stage2/lib" "--run-lib-path" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib" "--rustc-path" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/stage2/bin/rustc" "--src-base" "/Users/runner/runners/2.160.1/work/1/s/src/test/ui" "--build-base" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/test/ui" "--stage-id" "stage2-x86_64-apple-darwin" "--mode" "ui" "--target" "x86_64-apple-darwin" "--host" "x86_64-apple-darwin" "--llvm-filecheck" "/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/llvm/build/bin/FileCheck" "--nodejs" "/usr/local/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/Users/runner/runners/2.160.1/work/1/s/build/x86_64-apple-darwin/native/rust-test-helpers" "--docck-python" "/usr/local/bin/python2.7" "--lldb-python" "/usr/bin/python" "--lldb-version" "lldb-902.0.79.2\n  Swift-4.1\n" "--lldb-python-dir" "/Applications/Xcode_9.3.app/Contents/SharedFrameworks/LLDB.framework/Resources/Python" "--llvm-version" "9.0.0-rust-1.40.0-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-06T15:00:23.2827970Z 
2019-12-06T15:00:23.2828040Z 
2019-12-06T15:00:23.2828170Z failed to run: /Users/runner/runners/2.160.1/work/1/s/build/bootstrap/debug/bootstrap test
2019-12-06T15:00:23.2828300Z Build completed unsuccessfully in 0:49:10
2019-12-06T15:00:23.2828300Z Build completed unsuccessfully in 0:49:10
2019-12-06T15:00:23.2828420Z == clock drift check ==
2019-12-06T15:00:23.2828530Z   local time: Fri Dec  6 15:00:23 UTC 2019
2019-12-06T15:00:23.2828640Z   network time: Fri, 06 Dec 2019 15:00:23 GMT
2019-12-06T15:00:23.2828760Z == end clock drift check ==
2019-12-06T15:00:23.2828830Z 
2019-12-06T15:00:23.2900090Z ##[error]Bash exited with code '1'.
2019-12-06T15:00:23.2941780Z ##[section]Starting: Checkout
2019-12-06T15:00:23.2944730Z ==============================================================================
2019-12-06T15:00:23.2944840Z Task         : Get sources
2019-12-06T15:00:23.2944930Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Dec 7, 2019

📌 Commit a9a771bd90354375bccbf63162bc28cf75a94cba has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2019
@bors
Copy link
Contributor

bors commented Dec 7, 2019

⌛ Testing commit a9a771bd90354375bccbf63162bc28cf75a94cba with merge 0eeaf61b8720a53b880dfeefcbdac34ff0997c8c...

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-07T09:27:52.1772427Z failures:
2019-12-07T09:27:52.1812995Z 
2019-12-07T09:27:52.1813969Z ---- [ui] ui/traits/cycle-cache-err-60010.rs stdout ----
2019-12-07T09:27:52.1814343Z 
2019-12-07T09:27:52.1815120Z error: /checkout/src/test/ui/traits/cycle-cache-err-60010.rs:31: unexpected error: '31:5: 31:33: overflow evaluating the requirement `RootDatabase: SourceDatabase` [E0275]'
2019-12-07T09:27:52.1815902Z error: 1 unexpected errors found, 0 expected errors not found
2019-12-07T09:27:52.1816140Z status: exit code: 1
2019-12-07T09:27:52.1816140Z status: exit code: 1
2019-12-07T09:27:52.1817781Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/cycle-cache-err-60010.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/cycle-cache-err-60010" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/cycle-cache-err-60010/auxiliary" "-A" "unused"
2019-12-07T09:27:52.1818399Z unexpected errors (from JSON output): [
2019-12-07T09:27:52.1818859Z         line_num: 31,
2019-12-07T09:27:52.1819055Z         kind: Some(
2019-12-07T09:27:52.1819278Z             Error,
2019-12-07T09:27:52.1819464Z         ),
2019-12-07T09:27:52.1819464Z         ),
2019-12-07T09:27:52.1819718Z         msg: "31:5: 31:33: overflow evaluating the requirement `RootDatabase: SourceDatabase` [E0275]",
2019-12-07T09:27:52.1820149Z ]
2019-12-07T09:27:52.1820317Z 
2019-12-07T09:27:52.1821116Z thread '[ui] ui/traits/cycle-cache-err-60010.rs' panicked at 'explicit panic', src/tools/compiletest/src/runtest.rs:1520:13
2019-12-07T09:27:52.1821481Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
---
2019-12-07T09:27:52.1823560Z 
2019-12-07T09:27:52.1853820Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-07T09:27:52.1870689Z 
2019-12-07T09:27:52.1870799Z 
2019-12-07T09:27:52.1873179Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-07T09:27:52.1873964Z 
2019-12-07T09:27:52.1874006Z 
2019-12-07T09:27:52.1888581Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-07T09:27:52.1888726Z Build completed unsuccessfully in 1:03:16
2019-12-07T09:27:52.1888726Z Build completed unsuccessfully in 1:03:16
2019-12-07T09:27:52.1940851Z == clock drift check ==
2019-12-07T09:27:52.1967425Z   local time: Sat Dec  7 09:27:52 UTC 2019
2019-12-07T09:27:52.2116720Z   network time: Sat, 07 Dec 2019 09:27:52 GMT
2019-12-07T09:27:52.2118414Z == end clock drift check ==
2019-12-07T09:27:53.0472172Z 
2019-12-07T09:27:53.0584570Z ##[error]Bash exited with code '1'.
2019-12-07T09:27:53.0625429Z ##[section]Starting: Checkout
2019-12-07T09:27:53.0627583Z ==============================================================================
2019-12-07T09:27:53.0627707Z Task         : Get sources
2019-12-07T09:27:53.0627803Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Dec 7, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 7, 2019
@Mark-Simulacrum
Copy link
Member Author

Okay, trying without any modifications to that test.

@bors r+

@bors
Copy link
Contributor

bors commented Dec 7, 2019

📌 Commit d8612f3 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2019
@bors
Copy link
Contributor

bors commented Dec 7, 2019

⌛ Testing commit d8612f3 with merge 3f7f341...

bors added a commit that referenced this pull request Dec 7, 2019
[beta] backports

This pull request backports the following pull requests, which have all been beta-accepted by the
compiler team.

 * Handle non_exhaustive in borrow checking #66722
 * Do not ICE on trait aliases with missing obligations #66392
 * Do not ICE in `if` without `else` in `async fn` #66391
 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390
 * Do not ICE on recovery from unmet associated type bound obligation #66388
 * find_deprecation: deprecation attr may be ill-formed meta. #66381
 * parser: don't use `unreachable!()` in `fn unexpected`. #66361
 * Undo an assert causing an ICE until we fix the underlying problem #66250
 * Do not ICE with a precision flag in formatting str and no format arguments #66093
 * Fix two OOM issues related to `ConstProp` #66394
@bors
Copy link
Contributor

bors commented Dec 7, 2019

💔 Test failed - checks-azure

@rust-highfive
Copy link
Collaborator

The job i686-mingw-2 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-07T21:13:11.2034984Z ---- [ui] ui\backtrace-debuginfo.rs stdout ----
2019-12-07T21:13:11.2035152Z 
2019-12-07T21:13:11.2035543Z error: test run failed!
2019-12-07T21:13:11.2035751Z status: exit code: 101
2019-12-07T21:13:11.2037333Z command: PATH="D:\a\1\s\build\i686-pc-windows-gnu\stage2\lib\rustlib\i686-pc-windows-gnu\lib;D:\a\1\s\build\i686-pc-windows-gnu\stage0-bootstrap-tools\i686-pc-windows-gnu\release\deps;D:\a\1\s\build\i686-pc-windows-gnu\stage0\bin;D:\a\1\s\ninja;D:\a\1\s\mingw32\bin;C:\Python27amd64;D:\a\msys2\usr\bin;C:\Program Files (x86)\Inno Setup 5;D:\a\1\s\sccache;C:\agents\2.160.1\externals\git\cmd;C:\hostedtoolcache\windows\Python\3.6.8\x64;C:\hostedtoolcache\windows\Python\3.6.8\x64\Scripts;C:\Program Files\Mercurial;C:\ProgramData\kind;C:\vcpkg;C:\cf-cli;C:\Program Files (x86)\NSIS;C:\Program Files\Mercurial;C:\Program Files\Boost\1.69.0;C:\Program Files\dotnet;C:\mysql-5.7.21-winx64\bin;C:\Program Files\Java\zulu-8-azure-jdk_8.40.0.25-8.0.222-win_x64\bin;C:\npm\prefix;C:\Rust\.cargo\bin;C:\hostedtoolcache\windows\Ruby\2.5.5\x64\bin;C:\Go1.12.7\bin;C:\Program Files\Git\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\mingw64\bin;C:\hostedtoolcache\windows\Python\3.6.8\x64\Scripts;C:\hostedtoolcache\windows\Python\3.6.8\x64;C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin;C:\Program Files\Microsoft MPI\Bin;C:\windows\system32;C:\windows;C:\windows\System32\Wbem;C:\windows\System32\WindowsPowerShell\v1.0;C:\ProgramData\Chocolatey\bin;C:\Program Files\Docker;C:\Program Files\PowerShell\6;C:\Program Files\dotnet;C:\Program Files\Microsoft SQL Server\130\Tools\Binn;C:\Program Files (x86)\Microsoft SQL Server\110\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\120\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\130\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\140\DTS\Binn;C:\Program Files (x86)\Microsoft SQL Server\150\DTS\Binn;C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit;C:\Program Files\Microsoft Service Fabric\bin\Fabric\Fabric.Code;C:\Program Files\Microsoft SDKs\Service Fabric\Tools\ServiceFabricLocalClusterManager;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\tools\php;C:\Program Files (x86)\Subversion\bin;C:\Program Files\nodejs;C:\ProgramData\chocolatey\lib\maven\apache-maven-3.6.2\bin;C:\Program Files\CMake\bin;C:\Strawberry\c\bin;C:\Strawberry\perl\site\bin;C:\Strawberry\perl\bin;C:\Program Files\OpenSSL\bin;C:\Users\VssAdministrator\.dotnet\tools;C:\Program Files (x86)\Microsoft SQL Server\120" "D:\\a\\1\\s\\build\\i686-pc-windows-gnu\\test\\ui\\backtrace-debuginfo\\a.exe"
2019-12-07T21:13:11.2038878Z ------------------------------------------
2019-12-07T21:13:11.2039093Z ---------------------------------------
2019-12-07T21:13:11.2039284Z trace does not match position list
2019-12-07T21:13:11.2039284Z trace does not match position list
2019-12-07T21:13:11.2039449Z still need to find ["backtrace-debuginfo.rs:189", "backtrace-debuginfo.rs:126"]
2019-12-07T21:13:11.2039591Z --- stdout
2019-12-07T21:13:11.2039654Z backtrace-debuginfo.rs:126
2019-12-07T21:13:11.2039750Z backtrace-debuginfo.rs:189
2019-12-07T21:13:11.2039793Z 
2019-12-07T21:13:11.2039793Z 
2019-12-07T21:13:11.2039875Z --- stderr
2019-12-07T21:13:11.2039937Z test case 4
2019-12-07T21:13:11.2040068Z thread 'main' panicked at 'explicit panic', D:\a\1\s\src/test\ui\backtrace-debuginfo.rs:100:5
2019-12-07T21:13:11.2040179Z stack backtrace:
2019-12-07T21:13:11.2040258Z    0: 0x69fd5fdc - _set_invalid_parameter_handler
2019-12-07T21:13:11.2040537Z    1: 0x69f9af25 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2040620Z    2: 0x69fab7af - _set_invalid_parameter_handler
2019-12-07T21:13:11.2040722Z    3: 0x69fab4b8 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2040805Z    4: 0x69fabede - _set_invalid_parameter_handler
2019-12-07T21:13:11.2040911Z    5:   0x41a22d - std::panicking::begin_panic::h4321e89b7b295a1c
2019-12-07T21:13:11.2041005Z                        at D:\a\1\s\src\libstd/panicking.rs:400
2019-12-07T21:13:11.2041117Z    6:   0x412664 - backtrace_debuginfo::inner_inlined::h77ab595dd670898f
2019-12-07T21:13:11.2041232Z                        at D:\a\1\s\src/test\ui/backtrace-debuginfo.rs:100
2019-12-07T21:13:11.2041323Z    7:   0x8cc4c8 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2041499Z    8:   0x40d21c - core::str::<impl str>::parse::ha3071a419f2372c0
2019-12-07T21:13:11.2041600Z                        at D:\a\1\s\src\libcore\str/mod.rs:3969
2019-12-07T21:13:11.2041742Z ---------------------------------------
2019-12-07T21:13:11.2041864Z trace does not match position list
2019-12-07T21:13:11.2041864Z trace does not match position list
2019-12-07T21:13:11.2041952Z still need to find ["backtrace-debuginfo.rs:189", "backtrace-debuginfo.rs:126"]
2019-12-07T21:13:11.2042089Z --- stdout
2019-12-07T21:13:11.2042171Z backtrace-debuginfo.rs:126
2019-12-07T21:13:11.2042240Z backtrace-debuginfo.rs:189
2019-12-07T21:13:11.2042690Z 
2019-12-07T21:13:11.2042690Z 
2019-12-07T21:13:11.2042766Z --- stderr
2019-12-07T21:13:11.2043078Z test case 5
2019-12-07T21:13:11.2043185Z thread 'main' panicked at 'explicit panic', D:\a\1\s\src/test\ui\backtrace-debuginfo.rs:101:5
2019-12-07T21:13:11.2043285Z stack backtrace:
2019-12-07T21:13:11.2055397Z    0: 0x69fd5fdc - _set_invalid_parameter_handler
2019-12-07T21:13:11.2055524Z    1: 0x69f9af25 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2055677Z    2: 0x69fab7af - _set_invalid_parameter_handler
2019-12-07T21:13:11.2055770Z    3: 0x69fab4b8 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2055874Z    4: 0x69fabede - _set_invalid_parameter_handler
2019-12-07T21:13:11.2055968Z    5:   0x41a22d - std::panicking::begin_panic::h4321e89b7b295a1c
2019-12-07T21:13:11.2056074Z                        at D:\a\1\s\src\libstd/panicking.rs:400
2019-12-07T21:13:11.2056174Z    6:   0x412716 - backtrace_debuginfo::inner_inlined::h77ab595dd670898f
2019-12-07T21:13:11.2056337Z                        at D:\a\1\s\src/test\ui/backtrace-debuginfo.rs:101
2019-12-07T21:13:11.2056445Z    7:   0x89c4c8 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2056547Z    8:   0x40d21c - core::str::<impl str>::parse::ha3071a419f2372c0
2019-12-07T21:13:11.2056649Z                        at D:\a\1\s\src\libcore\str/mod.rs:3969
2019-12-07T21:13:11.2056775Z ---------------------------------------
2019-12-07T21:13:11.2056858Z trace does not match position list
2019-12-07T21:13:11.2056858Z trace does not match position list
2019-12-07T21:13:11.2056957Z still need to find ["backtrace-debuginfo.rs:189", "backtrace-debuginfo.rs:126"]
2019-12-07T21:13:11.2057085Z --- stdout
2019-12-07T21:13:11.2057156Z backtrace-debuginfo.rs:109
2019-12-07T21:13:11.2057238Z backtrace-debuginfo.rs:126
2019-12-07T21:13:11.2057309Z backtrace-debuginfo.rs:189
2019-12-07T21:13:11.2057309Z backtrace-debuginfo.rs:189
2019-12-07T21:13:11.2057353Z 
2019-12-07T21:13:11.2057423Z --- stderr
2019-12-07T21:13:11.2057484Z test case 6
2019-12-07T21:13:11.2057585Z thread 'main' panicked at 'explicit panic', D:\a\1\s\src/test\ui\backtrace-debuginfo.rs:107:9
2019-12-07T21:13:11.2057687Z stack backtrace:
2019-12-07T21:13:11.2057766Z    0: 0x69fd5fdc - _set_invalid_parameter_handler
2019-12-07T21:13:11.2057980Z    1: 0x69f9af25 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2058063Z    2: 0x69fab7af - _set_invalid_parameter_handler
2019-12-07T21:13:11.2058162Z    3: 0x69fab4b8 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2058243Z    4: 0x69fabede - _set_invalid_parameter_handler
2019-12-07T21:13:11.2058338Z    5:   0x41a22d - std::panicking::begin_panic::h4321e89b7b295a1c
2019-12-07T21:13:11.2058584Z                        at D:\a\1\s\src\libstd/panicking.rs:400
2019-12-07T21:13:11.2058685Z    6:   0x412a67 - backtrace_debuginfo::inner_inlined::inner_further_inlined::hc6cb011b12fdc07c
2019-12-07T21:13:11.2058796Z                        at D:\a\1\s\src/test\ui/backtrace-debuginfo.rs:107
2019-12-07T21:13:11.2058891Z    7:   0x412771 - backtrace_debuginfo::inner_inlined::h77ab595dd670898f
2019-12-07T21:13:11.2059063Z                        at D:\a\1\s\src/test\ui/backtrace-debuginfo.rs:109
2019-12-07T21:13:11.2059147Z    8:    0xdc4c8 - <unknown>
2019-12-07T21:13:11.2059237Z    9:   0x40d21c - core::str::<impl str>::parse::ha3071a419f2372c0
2019-12-07T21:13:11.2059334Z                        at D:\a\1\s\src\libcore\str/mod.rs:3969
2019-12-07T21:13:11.2059530Z ---------------------------------------
2019-12-07T21:13:11.2059617Z trace does not match position list
2019-12-07T21:13:11.2059617Z trace does not match position list
2019-12-07T21:13:11.2059714Z still need to find ["backtrace-debuginfo.rs:189", "backtrace-debuginfo.rs:126"]
2019-12-07T21:13:11.2059837Z --- stdout
2019-12-07T21:13:11.2059906Z backtrace-debuginfo-aux.rs:6
2019-12-07T21:13:11.2059982Z backtrace-debuginfo.rs:111
2019-12-07T21:13:11.2060051Z backtrace-debuginfo.rs:126
2019-12-07T21:13:11.2060051Z backtrace-debuginfo.rs:126
2019-12-07T21:13:11.2060132Z backtrace-debuginfo.rs:189
2019-12-07T21:13:11.2060174Z 
2019-12-07T21:13:11.2060241Z --- stderr
2019-12-07T21:13:11.2060301Z test case 7
2019-12-07T21:13:11.2060398Z thread 'main' panicked at 'explicit panic', D:\a\1\s\src/test\ui\backtrace-debuginfo.rs:112:9
2019-12-07T21:13:11.2060482Z stack backtrace:
2019-12-07T21:13:11.2060564Z    0: 0x69fd5fdc - _set_invalid_parameter_handler
2019-12-07T21:13:11.2060647Z    1: 0x69f9af25 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2060741Z    2: 0x69fab7af - _set_invalid_parameter_handler
2019-12-07T21:13:11.2060822Z    3: 0x69fab4b8 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2060911Z    4: 0x69fabede - _set_invalid_parameter_handler
2019-12-07T21:13:11.2061009Z    5:   0x41a22d - std::panicking::begin_panic::h4321e89b7b295a1c
2019-12-07T21:13:11.2061169Z                        at D:\a\1\s\src\libstd/panicking.rs:400
2019-12-07T21:13:11.2061279Z    6:   0x409b6f - backtrace_debuginfo::inner_inlined::{{closure}}::hfb3950c4d50c2864
2019-12-07T21:13:11.2061380Z                        at D:\a\1\s\src/test\ui/backtrace-debuginfo.rs:112
2019-12-07T21:13:11.2061480Z    7:   0x4098fb - backtrace_debuginfo::aux::callback::h2d349a730207a6f1
2019-12-07T21:13:11.2061575Z                        at D:\a\1\s\src/test\ui/backtrace-debuginfo-aux.rs:6
2019-12-07T21:13:11.2061678Z    8:   0x4127b4 - backtrace_debuginfo::inner_inlined::h77ab595dd670898f
2019-12-07T21:13:11.2061777Z                        at D:\a\1\s\src/test\ui/backtrace-debuginfo.rs:111
2019-12-07T21:13:11.2061874Z    9:   0x8ac4c8 - _set_invalid_parameter_handler
2019-12-07T21:13:11.2061969Z   10:   0x40d21c - core::str::<impl str>::parse::ha3071a419f2372c0
2019-12-07T21:13:11.2062062Z                        at D:\a\1\s\src\libcore\str/mod.rs:3969
2019-12-07T21:13:11.2062163Z 
2019-12-07T21:13:11.2062237Z ------------------------------------------
2019-12-07T21:13:11.2062711Z stderr:
2019-12-07T21:13:11.2062792Z ------------------------------------------
2019-12-07T21:13:11.2062792Z ------------------------------------------
2019-12-07T21:13:11.2063195Z thread 'main' panicked at 'found some errors', D:\a\1\s\src/test\ui\backtrace-debuginfo.rs:179:9
2019-12-07T21:13:11.2063434Z 
2019-12-07T21:13:11.2063505Z ------------------------------------------
2019-12-07T21:13:11.2063552Z 
2019-12-07T21:13:11.2063586Z 
---
2019-12-07T21:13:11.2064314Z test result: FAILED. 9196 passed; 1 failed; 88 ignored; 0 measured; 0 filtered out
2019-12-07T21:13:11.2064373Z 
2019-12-07T21:13:11.2064600Z 
2019-12-07T21:13:11.2064675Z 
2019-12-07T21:13:11.2065443Z command did not execute successfully: "D:\\a\\1\\s\\build\\i686-pc-windows-gnu\\stage0-tools-bin\\compiletest.exe" "--compile-lib-path" "D:\\a\\1\\s\\build\\i686-pc-windows-gnu\\stage2\\bin" "--run-lib-path" "D:\\a\\1\\s\\build\\i686-pc-windows-gnu\\stage2\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "--rustc-path" "D:\\a\\1\\s\\build\\i686-pc-windows-gnu\\stage2\\bin\\rustc.exe" "--src-base" "D:\\a\\1\\s\\src/test\\ui" "--build-base" "D:\\a\\1\\s\\build\\i686-pc-windows-gnu\\test\\ui" "--stage-id" "stage2-i686-pc-windows-gnu" "--mode" "ui" "--target" "i686-pc-windows-gnu" "--host" "i686-pc-windows-gnu" "--llvm-filecheck" "D:\\a\\1\\s\\build\\i686-pc-windows-gnu\\llvm\\build\\bin\\FileCheck.exe" "--nodejs" "C:\\Program Files\\nodejs\\node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=D:\\a\\1\\s\\build\\i686-pc-windows-gnu\\native\\rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=D:\\a\\1\\s\\build\\i686-pc-windows-gnu\\native\\rust-test-helpers" "--docck-python" "C:\\Python27amd64\\python2.7" "--lldb-python" "C:\\Python27amd64\\python2.7" "--gdb" "D:\\a\\1\\s\\mingw32\\bin\\gdb" "--llvm-version" "9.0.0-rust-1.40.0-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-07T21:13:11.2066059Z 
2019-12-07T21:13:11.2066098Z 
2019-12-07T21:13:11.3375699Z failed to run: D:\a\1\s\build\bootstrap\debug\bootstrap test src/test/ui src/test/compile-fail
2019-12-07T21:13:11.3376114Z Build completed unsuccessfully in 3:00:32
2019-12-07T21:13:11.3376114Z Build completed unsuccessfully in 3:00:32
2019-12-07T21:13:11.4093125Z make: *** [Makefile:91: ci-mingw-subset-2] Error 1
2019-12-07T21:13:11.4721330Z   local time: Sat Dec  7 21:13:11 CUT 2019
2019-12-07T21:13:12.1253942Z   network time: Sat, 07 Dec 2019 21:13:12 GMT
2019-12-07T21:13:12.1262351Z == end clock drift check ==
2019-12-07T21:13:12.2556085Z 
2019-12-07T21:13:12.2556085Z 
2019-12-07T21:13:12.6503075Z ##[error]Bash exited with code '2'.
2019-12-07T21:13:12.7514103Z ##[section]Starting: Checkout
2019-12-07T21:13:12.8524625Z ==============================================================================
2019-12-07T21:13:12.8524764Z Task         : Get sources
2019-12-07T21:13:12.8524863Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 7, 2019
@Mark-Simulacrum
Copy link
Member Author

@bors retry -- hopefully spurious? None of the PRs we're backporting seem to have anything to do with debuginfo AFAICT.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2019
@bors
Copy link
Contributor

bors commented Dec 8, 2019

⌛ Testing commit d8612f3 with merge b509d9b...

bors added a commit that referenced this pull request Dec 8, 2019
[beta] backports

This pull request backports the following pull requests, which have all been beta-accepted by the
compiler team.

 * Handle non_exhaustive in borrow checking #66722
 * Do not ICE on trait aliases with missing obligations #66392
 * Do not ICE in `if` without `else` in `async fn` #66391
 * Fix ICE when trying to suggest `Type<>` instead of `Type()` #66390
 * Do not ICE on recovery from unmet associated type bound obligation #66388
 * find_deprecation: deprecation attr may be ill-formed meta. #66381
 * parser: don't use `unreachable!()` in `fn unexpected`. #66361
 * Undo an assert causing an ICE until we fix the underlying problem #66250
 * Do not ICE with a precision flag in formatting str and no format arguments #66093
 * Fix two OOM issues related to `ConstProp` #66394
@bors
Copy link
Contributor

bors commented Dec 8, 2019

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing b509d9b to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 8, 2019
@bors bors merged commit d8612f3 into rust-lang:beta Dec 8, 2019
@Mark-Simulacrum Mark-Simulacrum deleted the beta-backports branch December 9, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants