Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submodules: update clippy from 69f99e74 to acbc609a #67486

Merged
merged 1 commit into from
Dec 22, 2019

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Dec 21, 2019

Changes:

rustup "Merge `ast::Mutability` and `mir::Mutability`"
rustup https://github.com/rust-lang/rust/pull/67130
rustup https://github.com/rust-lang/rust/pull/67455
Update lints for `iterator_step_by_zero` changes
Fix 'redudant' spelling in redundant_clone docs
Fix documentation example for unnecessary_filter_map.
Fix `expect_fun_call` false negative on references
Fix `iterator_step_by_zero` description in declaration
Fix `iterator_step_by_zero` definition
Correct `iterator_step_by_zero` documentation
Update iterator_step_by_zero
Prevent `cmp_nan` when inside constants
Detect comparisons with NAN constants
Fix clippy build failure

r? @oli-obk @Manishearth

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2019
@matthiaskrgr matthiaskrgr changed the title submodules: update clippy from 69f99e74 to acbc609a [WIP] submodules: update clippy from 69f99e74 to acbc609a Dec 21, 2019
@matthiaskrgr
Copy link
Member Author

Ok let's wait until #67485 merge because that likely requires another fix of clippy..

@matthiaskrgr
Copy link
Member Author

Status: clippy update is pending: rust-lang/rust-clippy#4932
Will update after this is merged.

Changes:
````
rustup "Merge `ast::Mutability` and `mir::Mutability`"
rustup rust-lang#67130
rustup rust-lang#67455
There are no per-file copyright headers anymore
Update lints for `iterator_step_by_zero` changes
Fix 'redudant' spelling in redundant_clone docs
Fix documentation example for unnecessary_filter_map.
Fix `expect_fun_call` false negative on references
Fix `iterator_step_by_zero` description in declaration
Fix `iterator_step_by_zero` definition
Correct `iterator_step_by_zero` documentation
Update iterator_step_by_zero
Prevent `cmp_nan` when inside constants
Detect comparisons with NAN constants
Fix clippy build failure
````
@matthiaskrgr matthiaskrgr changed the title [WIP] submodules: update clippy from 69f99e74 to acbc609a submodules: update clippy from 69f99e74 to acbc609a Dec 21, 2019
@matthiaskrgr
Copy link
Member Author

Should be good to go until clippy breaks again. :)

@oli-obk
Copy link
Contributor

oli-obk commented Dec 21, 2019

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Dec 21, 2019

📌 Commit f51f0e1 has been approved by oli-obk

@bors
Copy link
Contributor

bors commented Dec 21, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2019
@Centril
Copy link
Contributor

Centril commented Dec 22, 2019

@bors p=201

@Centril
Copy link
Contributor

Centril commented Dec 22, 2019

@bors rollup=never

@bors
Copy link
Contributor

bors commented Dec 22, 2019

⌛ Testing commit f51f0e1 with merge 005cf38...

bors added a commit that referenced this pull request Dec 22, 2019
submodules: update clippy from 69f99e7 to acbc609

Changes:
````
rustup "Merge `ast::Mutability` and `mir::Mutability`"
rustup #67130
rustup #67455
Update lints for `iterator_step_by_zero` changes
Fix 'redudant' spelling in redundant_clone docs
Fix documentation example for unnecessary_filter_map.
Fix `expect_fun_call` false negative on references
Fix `iterator_step_by_zero` description in declaration
Fix `iterator_step_by_zero` definition
Correct `iterator_step_by_zero` documentation
Update iterator_step_by_zero
Prevent `cmp_nan` when inside constants
Detect comparisons with NAN constants
Fix clippy build failure
````

r? @oli-obk  @Manishearth
@bors
Copy link
Contributor

bors commented Dec 22, 2019

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 005cf38 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 22, 2019
@bors bors merged commit f51f0e1 into rust-lang:master Dec 22, 2019
@matthiaskrgr matthiaskrgr deleted the submodule_upd branch January 3, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants