-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow rustfmt key in [build] section #67636
Conversation
Hm, it looks like the commit just adds a field to the config struct which I would expect to not actually fix this; maybe you missed something when pushing? |
in but by just adding the |
Could you add a comment to that effect to the rust code? We should also document this in config.toml.example (similar to rustc/cargo bits today). Once those are done I think we can merge. Thanks! |
d335f9f
to
98d8326
Compare
@Mark-Simulacrum any comments on my last changes ? else I will just workaround the problem locally. currently my buildbot on OpenBSD is off due to this problem. |
Sorry, missed the force-push I think (not sure if GH notifies on this -- I think it does sometimes, but maybe not always). @bors r+ |
📌 Commit 98d8326 has been approved by |
…imulacrum allow rustfmt key in [build] section Permit using `rustfmt` in `config.toml`. It will allow to not download `rustfmt` binary, which is not possible for at least some tiers-3 platforms. Fixes: rust-lang#67624 r? @Mark-Simulacrum
…imulacrum allow rustfmt key in [build] section Permit using `rustfmt` in `config.toml`. It will allow to not download `rustfmt` binary, which is not possible for at least some tiers-3 platforms. Fixes: rust-lang#67624 r? @Mark-Simulacrum
Rollup of 5 pull requests Successful merges: - #67636 (allow rustfmt key in [build] section) - #67736 (Less-than is asymmetric, not antisymmetric) - #67762 (Add missing links for insecure_time) - #67777 (Use self profile infrastructure for -Z time and -Z time-passes) - #67807 (Use drop instead of the toilet closure `|_| ()`) Failed merges: r? @ghost
…imulacrum allow rustfmt key in [build] section Permit using `rustfmt` in `config.toml`. It will allow to not download `rustfmt` binary, which is not possible for at least some tiers-3 platforms. Fixes: rust-lang#67624 r? @Mark-Simulacrum
Rollup of 10 pull requests Successful merges: - #67450 (Allow for setting a ThinLTO import limit during bootstrap) - #67595 (Suggest adding a lifetime constraint for opaque type) - #67636 (allow rustfmt key in [build] section) - #67736 (Less-than is asymmetric, not antisymmetric) - #67762 (Add missing links for insecure_time) - #67783 (Warn for bindings named same as variants when matching against a borrow) - #67796 (Ensure that we process projections during MIR inlining) - #67807 (Use drop instead of the toilet closure `|_| ()`) - #67816 (Clean up err codes) - #67825 (Minor: change take() docs grammar to match other docs) Failed merges: r? @ghost
☔ The latest upstream changes (presumably #67828) made this pull request unmergeable. Please resolve the merge conflicts. |
Permit using
rustfmt
inconfig.toml
. It will allow to not downloadrustfmt
binary, which is not possible for at least some tiers-3 platforms.Fixes: #67624
r? @Mark-Simulacrum