Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove colorcolumn setting from Vim runtime files #6783

Closed
wants to merge 1 commit into from

Conversation

hoelzro
Copy link
Contributor

@hoelzro hoelzro commented May 28, 2013

I think settings like this should be left up to the user.

@bstrie
Copy link
Contributor

bstrie commented May 28, 2013

We talked about this a bit and I think this is the correct course of action. I originally put in the colorcolumn rule because our original convention of 78 columns was shorter than the typical users' worst-case column length (80), and also because it was short enough that people were hitting it constantly. Now that we've increased the convention to 100 columns, the complaints of hitting the line-length limit during make check have all but vanished, which leads me to believe that a default setting to warn of the limit is no longer necessary. Also, some people would rather use textwidth to enforce their line lengths, rather than colorcolumn.

Furthermore, ideally the hypothetical rustfmt would save us from ever worrying about column lengths at all. Let us boldly stride towards that utopian future.

bors added a commit that referenced this pull request May 28, 2013
I think settings like this should be left up to the user.
@bors bors closed this May 28, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Feb 25, 2021
Add OpenDNS to `doc-valid-idents`

changelog: This commit adds `"OpenDNS"` to doc-valid-idents to avoid `doc_markdown` false positives.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants