Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fire "non_camel_case_types" for associated types #67936

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Jan 6, 2020

Fixes #67920.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2020
@Centril
Copy link
Contributor

Centril commented Jan 6, 2020

r? @Centril @bors r+

@bors
Copy link
Contributor

bors commented Jan 6, 2020

📌 Commit a7727c5 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned davidtwco Jan 6, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2020
@est31
Copy link
Member

est31 commented Jan 6, 2020

Thanks @euclio for the quick fix!

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 6, 2020
fire "non_camel_case_types" for associated types

Fixes rust-lang#67920.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 7, 2020
fire "non_camel_case_types" for associated types

Fixes rust-lang#67920.
bors added a commit that referenced this pull request Jan 7, 2020
Rollup of 13 pull requests

Successful merges:

 - #67566 (Add an unstable conversion from thread ID to u64)
 - #67671 (Account for `type X = impl Trait;` in lifetime suggestion)
 - #67727 (Stabilise vec::remove_item)
 - #67877 (Omit underscore constants from rustdoc)
 - #67880 (Handle multiple error fix suggestions carefuly)
 - #67898 (Improve hygiene of `newtype_index`)
 - #67908 (rustdoc: HTML escape const values)
 - #67909 (Fix ICE in const pretty printing and resolve FIXME)
 - #67929 (Formatting an example for method Vec.retain)
 - #67934 (Clean up E0178 explanation)
 - #67936 (fire "non_camel_case_types" for associated types)
 - #67943 (Missing module std in example.)
 - #67962 (Update books)

Failed merges:

r? @ghost
@bors bors merged commit a7727c5 into rust-lang:master Jan 7, 2020
@euclio euclio deleted the assoc-type-bad-style branch January 7, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad_style doesn't fire for associated types
6 participants