resolve: Point at the private item definitions in privacy errors #68153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ I would like to also include the original ADT's span in some way. My goal would be to suggest an appropriate import path. Do you have thoughts on how that could be accomplished in an agreeable way? |
|
📌 Commit a68334a has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 16, 2020
resolve: Point at the private item definitions in privacy errors A basic version of rust-lang#67951. r? @estebank
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 16, 2020
resolve: Point at the private item definitions in privacy errors A basic version of rust-lang#67951. r? @estebank
bors
added
S-waiting-on-author
Give named fields to `struct PrivacyError` Move `fn report_ambiguity_error` to `diagnostics.rs`
petrochenkov
force-pushed
the
privdiag
branch
from
a68334a to
0b60f1f
Compare
|
📌 Commit 0b60f1f has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 17, 2020
resolve: Point at the private item definitions in privacy errors A basic version of rust-lang#67951. r? @estebank
bors
added a commit
that referenced
this pull request
Jan 17, 2020
Rollup of 6 pull requests Successful merges: - #67956 (Detail transitive containment in E0588 diagnostic) - #68153 (resolve: Point at the private item definitions in privacy errors) - #68195 (Account for common `impl Trait`/`dyn Trait` return type errors) - #68288 (Fix some of the rustfmt fallout in Miri) - #68292 (don't clone types that are copy) - #68301 (Don't propagate __RUST_TEST_INVOKE to subprocess) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A basic version of #67951.
r? @estebank