Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 3.6 instead of 3.5 in float fract() documentation #68223

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Use 3.6 instead of 3.5 in float fract() documentation #68223

merged 1 commit into from
Jan 16, 2020

Conversation

SOF3
Copy link
Contributor

@SOF3 SOF3 commented Jan 14, 2020 •
edited
Loading

It is not self-explanatory whether the fract() function inverts the fractional part of negative numbers. This change clarifies this possible question (so that it is .6 not .4)

@rust-highfive
Copy link
Collaborator

r? @LukasKalbertodt

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 14, 2020
@rust-highfive
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-01-14T18:09:01.8103983Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-14T18:09:01.8191464Z ##[command]git config gc.auto 0
2020-01-14T18:09:01.8267174Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-14T18:09:01.8335209Z ##[command]git config --get-all http.proxy
2020-01-14T18:09:01.8469877Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68223/merge:refs/remotes/pull/68223/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@varkor
Copy link
Member

varkor commented Jan 14, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 14, 2020

📌 Commit d43615f has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 14, 2020
@varkor varkor assigned varkor and unassigned LukasKalbertodt Jan 14, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#68223 - SOF3:float-fract-doc, r=varkor
d98dd60 
Use 3.6 instead of 3.5 in float fract() documentation

It is not self-explanatory whether the fract() function inverts the fractional part of negative numbers. This change clarifies this possible question (so that it is `.6` not `.4`)
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 15, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 15, 2020
@Dylan-DPC
Rollup merge of rust-lang#68223 - SOF3:float-fract-doc, r=varkor
919da48 
Use 3.6 instead of 3.5 in float fract() documentation

It is not self-explanatory whether the fract() function inverts the fractional part of negative numbers. This change clarifies this possible question (so that it is `.6` not `.4`)
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 15, 2020
Closed
@Dylan-DPC-zz
Copy link

Failed in rollup #68242

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 15, 2020
mati865
mati865 reviewed Jan 15, 2020
View reviewed changes
src/libstd/f64.rs Outdated Show resolved Hide resolved
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-01-15T14:56:28.3060452Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-15T14:56:28.3071149Z ##[command]git config gc.auto 0
2020-01-15T14:56:28.3073155Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-15T14:56:28.3074822Z ##[command]git config --get-all http.proxy
2020-01-15T14:56:28.3077828Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68223/merge:refs/remotes/pull/68223/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@mati865
Copy link
Contributor

mati865 commented Jan 15, 2020

GitHub has broke spacing in the last commit, you should make is as a fixup to the previous one.

@SOF3 @mati865
Use 3.6 instead of 3.5 in float fract() documentation
33bc9ef 
It is not self-explanatory whether the fract() function inverts the fractional part of negative numbers.

Co-Authored-By: Mateusz Mikuła <mati865@users.noreply.github.com>
@varkor
Copy link
Member

varkor commented Jan 15, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jan 15, 2020

📌 Commit 33bc9ef has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 15, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#68223 - SOF3:float-fract-doc, r=varkor
e115881 
Use 3.6 instead of 3.5 in float fract() documentation

It is not self-explanatory whether the fract() function inverts the fractional part of negative numbers. This change clarifies this possible question (so that it is `.6` not `.4`)
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 16, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Jan 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#68223 - SOF3:float-fract-doc, r=varkor
69eee56 
Use 3.6 instead of 3.5 in float fract() documentation

It is not self-explanatory whether the fract() function inverts the fractional part of negative numbers. This change clarifies this possible question (so that it is `.6` not `.4`)
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Jan 16, 2020
Merged
bors added a commit that referenced this pull request Jan 16, 2020
@bors
Auto merge of #68272 - Dylan-DPC:rollup-vrb90gu, r=Dylan-DPC
9fe05e9 
Rollup of 5 pull requests

Successful merges:

 - #67780 (Move some queries from rustc::ty to librustc_ty.)
 - #68096 (Clean up some diagnostics by making them more consistent)
 - #68223 (Use 3.6 instead of 3.5 in float fract() documentation)
 - #68265 (Fix some issue numbers of unstable features)
 - #68266 (Changed docs for f32 and f64.)

Failed merges:

 - #68204 (Use named fields for `{ast,hir}::ItemKind::Impl`)

r? @ghost
@bors bors merged commit 33bc9ef into rust-lang:master Jan 16, 2020
@SOF3 SOF3 deleted the float-fract-doc branch January 16, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mati865 mati865 mati865 left review comments

Assignees

@varkor varkor

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SOF3 @rust-highfive @varkor @bors @Dylan-DPC-zz @mati865 @LukasKalbertodt