librustc: Bump the offset when translating const structs. Closes #6352. #6848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -563,6 +563,7 @@ fn build_const_struct(ccx: @CrateContext, st: &Struct, vals: &[ValueRef]) | |||
| vals[i] | |||
| }; | |||
| cfields.push(val); | |||
| offset += machine::llsize_of_real(ccx, llty) as u64 | |||
There was a problem hiding this comment.
Why llsize_of_real and not llsize_of_alloc?
bors
added a commit
that referenced
this pull request
May 31, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 11, 2021
…ogiq lintcheck: add --fix mode which tries to apply lint suggestions to th… …e sources and prints a warning if that fails Great for spotting false positives/broken suggestions of applicable lints. There are false positives though because I'm not sure yet how to silence rustc warnings while keeping clippy warnings. Sometimes rustc makes a suggestion that fails to apply and the implementation does not differentiate between clippy and rustc warnings when applying lint suggestions. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis