Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use spaces before type ascription like colons #68517

Merged
merged 1 commit into from
Jan 26, 2020
Merged

Don't use spaces before type ascription like colons #68517

merged 1 commit into from
Jan 26, 2020

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jan 24, 2020

Split out of #67133 to make that PR simpler

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 24, 2020
@oli-obk oli-obk mentioned this pull request Jan 24, 2020
Merged
@bors
Copy link
Contributor

bors commented Jan 25, 2020

☔ The latest upstream changes (presumably #68526) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 25, 2020

rebased

@nagisa
Copy link
Member

nagisa commented Jan 25, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jan 25, 2020

📌 Commit ae31436 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2020
@bors
Copy link
Contributor

bors commented Jan 26, 2020

⌛ Testing commit ae31436 with merge fe1e815...

bors added a commit that referenced this pull request Jan 26, 2020
@bors
Auto merge of #68517 - oli-obk:spaces2, r=nagisa
fe1e815 
Don't use spaces before type ascription like colons

Split out of #67133 to make that PR simpler

r? @eddyb
@bors
Copy link
Contributor

bors commented Jan 26, 2020

☀️ Test successful - checks-azure
Approved by: nagisa
Pushing fe1e815 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 26, 2020
@bors bors merged commit ae31436 into rust-lang:master Jan 26, 2020
@oli-obk oli-obk deleted the spaces2 branch March 16, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

@eddyb eddyb eddyb left review comments

Assignees

@eddyb eddyb

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oli-obk @bors @nagisa @eddyb @Mark-Simulacrum @rust-highfive