Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null synthetic_implementors error #68598

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Fix null synthetic_implementors error #68598

merged 1 commit into from
Jan 29, 2020

Conversation

GuillaumeGomez
Copy link
Member

Fixes #68584.

r? @ollie27

cc @kinnison

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-01-28T12:49:21.7695359Z ========================== Starting Command Output ===========================
2020-01-28T12:49:21.7714417Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/118662eb-0c48-471d-99ca-f1d95257267f.sh
2020-01-28T12:49:21.8012328Z 
2020-01-28T12:49:21.8052957Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-28T12:49:21.8058767Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68598/merge to s
2020-01-28T12:49:21.8060387Z Task         : Get sources
2020-01-28T12:49:21.8060425Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-28T12:49:21.8060462Z Version      : 1.0.0
2020-01-28T12:49:21.8060542Z Author       : Microsoft
---
2020-01-28T12:49:22.6943018Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-28T12:49:22.7056128Z ##[command]git config gc.auto 0
2020-01-28T12:49:22.7130788Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-28T12:49:22.7182727Z ##[command]git config --get-all http.proxy
2020-01-28T12:49:22.7328353Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68598/merge:refs/remotes/pull/68598/merge
---
2020-01-28T13:15:28.4965256Z    Compiling serde_json v1.0.40
2020-01-28T13:15:30.0268271Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2020-01-28T13:15:39.1227660Z     Finished release [optimized] target(s) in 1m 16s
2020-01-28T13:15:39.1335538Z tidy check
2020-01-28T13:15:40.2722931Z tidy error: /checkout/src/librustdoc/html/static/main.js:1902: line longer than 100 chars
2020-01-28T13:15:41.9424896Z some tidy checks failed
2020-01-28T13:15:41.9425054Z Found 487 error codes
2020-01-28T13:15:41.9425112Z Found 0 error codes with no tests
2020-01-28T13:15:41.9425165Z Done!
2020-01-28T13:15:41.9425165Z Done!
2020-01-28T13:15:41.9425200Z 
2020-01-28T13:15:41.9425252Z 
2020-01-28T13:15:41.9426375Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2020-01-28T13:15:41.9426564Z 
2020-01-28T13:15:41.9426596Z 
2020-01-28T13:15:41.9435190Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2020-01-28T13:15:41.9435277Z Build completed unsuccessfully in 0:01:27
2020-01-28T13:15:41.9435277Z Build completed unsuccessfully in 0:01:27
2020-01-28T13:15:41.9489069Z == clock drift check ==
2020-01-28T13:15:41.9500442Z   local time: Tue Jan 28 13:15:41 UTC 2020
2020-01-28T13:15:42.4933755Z   network time: Tue, 28 Jan 2020 13:15:42 GMT
2020-01-28T13:15:42.4934942Z == end clock drift check ==
2020-01-28T13:15:43.2105706Z 
2020-01-28T13:15:43.2226734Z ##[error]Bash exited with code '1'.
2020-01-28T13:15:43.2239901Z ##[section]Finishing: Run build
2020-01-28T13:15:43.2255256Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68598/merge to s
2020-01-28T13:15:43.2257120Z Task         : Get sources
2020-01-28T13:15:43.2257173Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-28T13:15:43.2257240Z Version      : 1.0.0
2020-01-28T13:15:43.2257287Z Author       : Microsoft
2020-01-28T13:15:43.2257287Z Author       : Microsoft
2020-01-28T13:15:43.2257338Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-28T13:15:43.2257406Z ==============================================================================
2020-01-28T13:15:43.6539830Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-28T13:15:43.6581909Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68598/merge to s
2020-01-28T13:15:43.6695896Z Cleaning up task key
2020-01-28T13:15:43.6696682Z Start cleaning up orphan processes.
2020-01-28T13:15:43.6804375Z Terminate orphan process: pid (3238) (python)
2020-01-28T13:15:43.7019407Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@ollie27
Copy link
Member

ollie27 commented Jan 28, 2020

Nice, r=me once the tidy error has been fixed.

Nominating for beta backport because it looks like it's just been branched.

@ollie27 ollie27 added beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 28, 2020
@Centril Centril added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 28, 2020
@Centril
Copy link
Contributor

Centril commented Jan 28, 2020

@ollie27 btw, don't forget to add a team label when adding beta-nominated. :)

@GuillaumeGomez
Copy link
Member Author

Updated!

@GuillaumeGomez
Copy link
Member Author

@bors: r=ollie27

@bors
Copy link
Contributor

bors commented Jan 29, 2020

📌 Commit 0754461 has been approved by ollie27

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 29, 2020
@JohnTitor
Rollup merge of rust-lang#68598 - GuillaumeGomez:fix-null-synthetic_i…
ed351e2 
…mplementors, r=ollie27

Fix null synthetic_implementors error

Fixes rust-lang#68584.

r? @ollie27

cc @kinnison
@JohnTitor JohnTitor mentioned this pull request Jan 29, 2020
Merged
bors added a commit that referenced this pull request Jan 29, 2020
@bors
Auto merge of #68635 - JohnTitor:rollup-jsc34ac, r=JohnTitor
eed12bc 
Rollup of 7 pull requests

Successful merges:

 - #67722 (Minor: note how Any is an unsafe trait in SAFETY comments)
 - #68586 (Make conflicting_repr_hints a deny-by-default c-future-compat lint)
 - #68598 (Fix null synthetic_implementors error)
 - #68603 (Changelog: Demonstrate final build-override syntax)
 - #68609 (Set lld flavor for MSVC to link.exe)
 - #68611 (Correct ICE caused by macros generating invalid spans.)
 - #68627 (Document that write_all will not call write if given an empty buffer)

Failed merges:

r? @ghost
@bors bors merged commit 0754461 into rust-lang:master Jan 29, 2020
@GuillaumeGomez GuillaumeGomez deleted the fix-null-synthetic_implementors branch January 29, 2020 22:18
@Mark-Simulacrum
Copy link
Member

@rust-lang/rustdoc If this is to get into beta in time (i.e., before beta becomes stable) then it needs to be approved roughly in the next 3 days.

@GuillaumeGomez GuillaumeGomez added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 6, 2020
@GuillaumeGomez
Copy link
Member Author

@Mark-Simulacrum I add the tag for it.

@pietroalbini pietroalbini mentioned this pull request Mar 9, 2020
Merged
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 9, 2020
bors added a commit that referenced this pull request Mar 9, 2020
@bors
Auto merge of #69854 - pietroalbini:stable-next, r=Centril
39ac5ed 
[stable] Release 1.42.0

This PR prepares the release artifacts of Rust 1.42.0, and cherry-picks the following PRs:

* #69754: Update deprecation version to 1.42 for Error::description
* #69753: Do not ICE when matching an uninhabited enum's field
* #69522 / #69853: error_derive_forbidden_on_non_adt: be more graceful
* #68598:  Fix null synthetic_implementors error

In addition, the release notes are updated to include the remaining compatibility notes.

r? @Centril
bors added a commit that referenced this pull request Mar 9, 2020
@bors
Auto merge of #69854 - pietroalbini:stable-next, r=Centril
b8cedc0 
[stable] Release 1.42.0

This PR prepares the release artifacts of Rust 1.42.0, and cherry-picks the following PRs:

* #69754: Update deprecation version to 1.42 for Error::description
* #69753: Do not ICE when matching an uninhabited enum's field
* #69522 / #69853: error_derive_forbidden_on_non_adt: be more graceful
* #68598:  Fix null synthetic_implementors error

In addition, the release notes are updated to include the remaining compatibility notes.

r? @Centril
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ollie27 ollie27

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaScript TypeError: synthetic_implementors is null error on some trait pages
7 participants
@GuillaumeGomez @rust-highfive @ollie27 @Centril @bors @Mark-Simulacrum @pietroalbini