Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experiment] proc_macro: Redirect Span::call_site to Span::mixed_site #68766

Closed
wants to merge 1 commit into from
Closed

[experiment] proc_macro: Redirect Span::call_site to Span::mixed_site #68766

wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Feb 2, 2020 •
edited
Loading

The goal is to approximately check how much disruption will be caused by crates like quote changing the default hygiene to the macro_rules one.

r? @ghost

@petrochenkov
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Feb 2, 2020

⌛ Trying commit 2810704 with merge f149601db42efe10ece8b284ab681fd4a6fcb89c...

@petrochenkov petrochenkov added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Feb 2, 2020
@petrochenkov petrochenkov mentioned this pull request Feb 2, 2020
Merged
@bors
Copy link
Contributor

bors commented Feb 2, 2020

☀️ Try build successful - checks-azure
Build commit: f149601db42efe10ece8b284ab681fd4a6fcb89c (f149601db42efe10ece8b284ab681fd4a6fcb89c)

@petrochenkov
Copy link
Contributor Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-68766 created and queued.
🤖 Automatically detected try build f149601db42efe10ece8b284ab681fd4a6fcb89c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-68766 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-68766 is completed!
📊 3578 regressed and 0 fixed (88601 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 7, 2020
@dtolnay
Copy link
Member

dtolnay commented Feb 7, 2020

Let's follow up in #68716.

@dtolnay dtolnay closed this Feb 7, 2020
@dtolnay dtolnay self-assigned this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dtolnay dtolnay

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petrochenkov @bors @craterbot @dtolnay