Move callee_id out of ast::expr #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs rebase. Once you've rebased, I'll review this, because I originally made the choice to put |
|
@catamorphism: Just pushed a rebase. |
|
@catamorphism and another one. Added the requested fixme too: #6890. |
bors
added a commit
that referenced
this pull request
Jun 2, 2013
The `callee_id` in `ast::expr` in only used in a couple expression variants. This moves the `callee_id` into those branches to make it more clear when its should be used. Also, it fixes a bug in a std::run test when there is a symlink in the path rust where was checked out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
callee_idinast::exprin only used in a couple expression variants. This moves thecallee_idinto those branches to make it more clear when its should be used.Also, it fixes a bug in a std::run test when there is a symlink in the path rust where was checked out.