Test failure of unchecked arithmetic intrinsics in const eval #68937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Any reason you used half a dozen different files as opposed to putting them all into the same file? |
RalfJung
reviewed
Feb 10, 2020
RalfJung
reviewed
Feb 10, 2020
|
ecstatic-morse
force-pushed
the
unchecked-intrinsics-test
branch
2 times, most recently
from
b7f8065 to
8db5d55
Compare
|
Yeah, Miri stops on the first error (not sure what else an interpreter could possibly do). rustc just gives up for that particular |
RalfJung
reviewed
Feb 10, 2020
ecstatic-morse
force-pushed
the
unchecked-intrinsics-test
branch
from
8db5d55 to
ee52fe6
Compare
|
Thanks! @bors r+ rollup |
|
📌 Commit ee52fe6 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 12, 2020
…-test, r=RalfJung Test failure of unchecked arithmetic intrinsics in const eval Test that the unchecked arithmetic intrinsics that were made unstably const in rust-lang#68809 emit an error during const-eval if given invalid input. Addresses [this comment](rust-lang#68809 (comment)). r? @RalfJung
bors
added a commit
that referenced
this pull request
Feb 12, 2020
Rollup of 11 pull requests Successful merges: - #67695 (Added dyn and true keyword docs) - #68487 ([experiment] Support linking from a .rlink file) - #68554 (Split lang_items to crates `rustc_hir` and `rustc_passes`.) - #68937 (Test failure of unchecked arithmetic intrinsics in const eval) - #68947 (Python script PEP8 style guide space formatting and minor Python source cleanup) - #68999 (remove dependency on itertools) - #69026 (Remove common usage pattern from `AllocRef`) - #69027 (Add missing `_zeroed` varants to `AllocRef`) - #69058 (Preparation for allocator aware `Box`) - #69070 (Add self to .mailmap) - #69077 (Fix outdated doc comment.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that the unchecked arithmetic intrinsics that were made unstably const in #68809 emit an error during const-eval if given invalid input.
Addresses this comment.
r? @RalfJung