Cleanup SGX entry code #69040
Merged
Cleanup SGX entry code #69040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… clear rflags during enclave (re-)entry
|
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
All of these commits could definitely use some more text on them describing the why. |
nagisa
reviewed
Feb 11, 2020
|
|
||
| /* x87 FPU control word initialization value for ABI */ | ||
| .Lfpucw_init: | ||
| .int 0x037f |
There was a problem hiding this comment.
This is setting one of the reserved bits (6th) to 1?
There was a problem hiding this comment.
This is the default from the Intel SDM, Vol. 1, §8.1.5
|
Sorry I'm not on the libs team any more and I'd rather not be on the hook for these sorts of PRs. @nagisa mind taking over review? |
|
r? @nagisa |
|
See §4 of https://people.cs.kuleuven.be/~jo.vanbulck/ccs19-tale.pdf for the “why”. |
|
This includes fixes for INTEL-SA-00336/CVE-2020-0561, could this be merged soon? |
|
@bors r+ |
|
📌 Commit 71b9ed4 has been approved by |
bors
added
S-waiting-on-bors
|
Why does bors show this as not mergeable? |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 12, 2020
…gisa Cleanup SGX entry code cc @aandyl
bors
added a commit
that referenced
this pull request
Feb 12, 2020
Rollup of 7 pull requests Successful merges: - #67954 (Support new LLVM pass manager) - #68981 ( Account for type params on method without parentheses) - #69002 (miri: improve and simplify overflow detection) - #69038 (Add initial debug fmt for Backtrace) - #69040 (Cleanup SGX entry code) - #69086 (Update compiler-builtins to 0.1.25) - #69095 (Minified theme check) Failed merges: r? @ghost
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 13, 2020
…lan-DPC Add comment to SGX entry code Meant to force push this to be included in rust-lang#69040, but forgot r? @nagisa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @aandyl