Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use to_vec() instead of .iter().cloned().collect() to convert slices to vecs. #69546

Merged
merged 1 commit into from
Feb 29, 2020
Merged

use to_vec() instead of .iter().cloned().collect() to convert slices to vecs. #69546

merged 1 commit into from
Feb 29, 2020

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2020
davidtwco
davidtwco approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when CI passes

@nagisa
Copy link
Member

nagisa commented Feb 28, 2020

@bors r=davidtwco,nagisa

@bors
Copy link
Contributor

bors commented Feb 28, 2020

📌 Commit 0c5d497 has been approved by davidtwco,nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 28, 2020
@matthiaskrgr
Copy link
Member Author

can we roll this up?

@nagisa
Copy link
Member

nagisa commented Feb 28, 2020

@bors rollup

@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 29, 2020
Merged
bors added a commit that referenced this pull request Feb 29, 2020
@bors
Auto merge of #69570 - Dylan-DPC:rollup-d6boczt, r=Dylan-DPC
3f9bddc 
Rollup of 6 pull requests

Successful merges:

 - #69477 (docs: add mention of async blocks in move keyword docs)
 - #69504 (Use assert_ne in hash tests)
 - #69546 (use to_vec() instead of .iter().cloned().collect() to convert slices to vecs.)
 - #69551 (use is_empty() instead of len() == x  to determine if structs are empty.)
 - #69563 (Fix no_std detection for target triples)
 - #69567 (use .to_string() instead of format!() macro to create strings)

Failed merges:

r? @ghost
@bors bors merged commit ba2df27 into rust-lang:master Feb 29, 2020
@matthiaskrgr matthiaskrgr deleted the slice_to_vec branch February 29, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @rust-highfive @nagisa @bors @davidtwco