Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: work-around for take/skip type inference (#6967) #6968

Merged
merged 1 commit into from
Jun 6, 2013
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/libstd/iterator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ pub trait IteratorUtil<A> {
/// assert_eq!(it.next().get(), &5);
/// assert!(it.next().is_none());
/// ~~~
fn skip(self, n: uint) -> SkipIterator<Self>;
fn skip(self, n: uint) -> SkipIterator<A, Self>;

/// Creates an iterator which yields the first `n` elements of this
/// iterator, and then it will always return None.
Expand All @@ -203,7 +203,7 @@ pub trait IteratorUtil<A> {
/// assert_eq!(it.next().get(), &3);
/// assert!(it.next().is_none());
/// ~~~
fn take(self, n: uint) -> TakeIterator<Self>;
fn take(self, n: uint) -> TakeIterator<A, Self>;

/// Creates a new iterator which behaves in a similar fashion to foldl.
/// There is a state which is passed between each iteration and can be
Expand Down Expand Up @@ -386,12 +386,12 @@ impl<A, T: Iterator<A>> IteratorUtil<A> for T {
}

#[inline(always)]
fn skip(self, n: uint) -> SkipIterator<T> {
fn skip(self, n: uint) -> SkipIterator<A, T> {
SkipIterator{iter: self, n: n}
}

#[inline(always)]
fn take(self, n: uint) -> TakeIterator<T> {
fn take(self, n: uint) -> TakeIterator<A, T> {
TakeIterator{iter: self, n: n}
}

Expand Down Expand Up @@ -739,13 +739,14 @@ impl<'self, A, T: Iterator<A>> Iterator<A> for TakeWhileIterator<'self, A, T> {
}
}

/// An iterator which skips over `n` elements of `iter`
pub struct SkipIterator<T> {
/// An iterator which skips over `n` elements of `iter`.
// FIXME #6967: Dummy A parameter to get around type inference bug
pub struct SkipIterator<A, T> {
priv iter: T,
priv n: uint
}

impl<A, T: Iterator<A>> Iterator<A> for SkipIterator<T> {
impl<A, T: Iterator<A>> Iterator<A> for SkipIterator<A, T> {
#[inline]
fn next(&mut self) -> Option<A> {
let mut next = self.iter.next();
Expand All @@ -772,12 +773,13 @@ impl<A, T: Iterator<A>> Iterator<A> for SkipIterator<T> {
}

/// An iterator which only iterates over the first `n` iterations of `iter`.
pub struct TakeIterator<T> {
// FIXME #6967: Dummy A parameter to get around type inference bug
pub struct TakeIterator<A, T> {
priv iter: T,
priv n: uint
}

impl<A, T: Iterator<A>> Iterator<A> for TakeIterator<T> {
impl<A, T: Iterator<A>> Iterator<A> for TakeIterator<A, T> {
#[inline]
fn next(&mut self) -> Option<A> {
let next = self.iter.next();
Expand Down Expand Up @@ -945,7 +947,7 @@ mod tests {
let ys = [13, 15, 16, 17, 19, 20, 30];
let mut it = xs.iter().skip(5);
let mut i = 0;
for it.advance |&x: &uint| {
for it.advance |&x| {
assert_eq!(x, ys[i]);
i += 1;
}
Expand All @@ -958,7 +960,7 @@ mod tests {
let ys = [0u, 1, 2, 3, 5];
let mut it = xs.iter().take(5);
let mut i = 0;
for it.advance |&x: &uint| {
for it.advance |&x| {
assert_eq!(x, ys[i]);
i += 1;
}
Expand Down