Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use associated constants of integer types #69698

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 4, 2020

Take advantage of #68952 in the interpreter and some nearby modules :)

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2020
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me when CI passes

@RalfJung
Copy link
Member Author

RalfJung commented Mar 4, 2020

@bors r=davidtwco rollup

@bors
Copy link
Contributor

bors commented Mar 4, 2020

📌 Commit f0c3cf2 has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 4, 2020
Use associated constants of integer types

Take advantage of rust-lang#68952 in the interpreter and some nearby modules :)
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 4, 2020
Use associated constants of integer types

Take advantage of rust-lang#68952 in the interpreter and some nearby modules :)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2020
Use associated constants of integer types

Take advantage of rust-lang#68952 in the interpreter and some nearby modules :)
bors added a commit that referenced this pull request Mar 5, 2020
Rollup of 10 pull requests

Successful merges:

 - #69520 (Make error message clearer about creating new module)
 - #69589 (ast: `Mac`/`Macro` -> `MacCall`)
 - #69614 (`delay_span_bug` when codegen cannot select obligation)
 - #69641 (Update books)
 - #69674 (Rename DefKind::Method and TraitItemKind::Method )
 - #69697 (Add explanation for E0380)
 - #69698 (Use associated constants of integer types)
 - #69705 (Toolstate: remove redundant beta-week check.)
 - #69711 (Update macros.rs: fix documentation typo.)
 - #69713 (more clippy cleanups)

Failed merges:

r? @ghost
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2020
Use associated constants of integer types

Take advantage of rust-lang#68952 in the interpreter and some nearby modules :)
bors added a commit that referenced this pull request Mar 5, 2020
Rollup of 8 pull requests

Successful merges:

 - #69697 (Add explanation for E0380)
 - #69698 (Use associated constants of integer types)
 - #69711 (Update macros.rs: fix documentation typo.)
 - #69713 (more clippy cleanups)
 - #69728 (Make link to `std::str` active)
 - #69732 (Clean E0382 and E0384 explanations)
 - #69736 (even more clippy cleanups)
 - #69742 (Fixed a typo)

Failed merges:

r? @ghost
@bors bors merged commit 44f184a into rust-lang:master Mar 6, 2020
@RalfJung RalfJung deleted the int_assoc branch March 7, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants