Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak output for invalid negative impl AST errors #69722

Merged
merged 7 commits into from
Mar 12, 2020
Merged

Tweak output for invalid negative impl AST errors #69722

merged 7 commits into from
Mar 12, 2020

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Mar 5, 2020

Use more accurate spans for negative impl errors.

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2020
@estebank estebank mentioned this pull request Mar 5, 2020
Merged
Centril
Centril reviewed Mar 5, 2020
View reviewed changes
src/librustc_ast_passes/ast_validation.rs Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_parse/parser/item.rs Outdated Show resolved Hide resolved
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2020
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2020
Centril
Centril reviewed Mar 6, 2020
View reviewed changes
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
@estebank estebank force-pushed the negative-impl-span-ast branch from 44dd91d to 53cfb23 Compare March 6, 2020 19:45
@estebank estebank force-pushed the negative-impl-span-ast branch from 53cfb23 to f483032 Compare March 6, 2020 19:59
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2020
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 11, 2020
Centril
Centril reviewed Mar 11, 2020
View reviewed changes
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
src/librustc_ast_passes/ast_validation.rs Outdated Show resolved Hide resolved
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2020
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 11, 2020
@Centril
Copy link
Contributor

Centril commented Mar 11, 2020

Thanks, @bors r+

@bors
Copy link
Contributor

bors commented Mar 11, 2020

📌 Commit 7ee1b47 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 11, 2020
@Centril
Rollup merge of rust-lang#69722 - estebank:negative-impl-span-ast, r=…
3681df6 
…Centril

Tweak output for invalid negative impl AST errors

Use more accurate spans for negative `impl` errors.

r? @Centril
@Centril Centril mentioned this pull request Mar 11, 2020
Closed
@Centril Centril mentioned this pull request Mar 12, 2020
Merged
bors added a commit that referenced this pull request Mar 12, 2020
@bors
Auto merge of #69950 - Centril:rollup-xh0hmvx, r=Centril
54b7d21 
Rollup of 10 pull requests

Successful merges:

 - #68899 (Add Display and Error impls for proc_macro::LexError)
 - #69011 (Document unsafe blocks in core::fmt)
 - #69674 (Rename DefKind::Method and TraitItemKind::Method )
 - #69705 (Toolstate: remove redundant beta-week check.)
 - #69722 (Tweak output for invalid negative impl AST errors)
 - #69747 (Rename rustc guide)
 - #69792 (Implement Error for TryReserveError)
 - #69830 (miri: ICE on invalid terminators)
 - #69921 (rustdoc: remove unused import)
 - #69945 (update outdated comment)

Failed merges:

r? @ghost
@bors bors merged commit 4f7fc5a into rust-lang:master Mar 12, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2020
@bors
Auto merge of rust-lang#69649 - estebank:negative-impl-span, r=Centril
8549cfe 
Tweak output for invalid negative impl errors

Follow up to rust-lang#69722. Tweak negative impl errors emitted in the HIR:

```
error[E0192]: invalid negative impl
  --> $DIR/E0192.rs:9:6
   |
LL | impl !Trait for Foo { }
   |      ^^^^^^
   |
   = note: negative impls are only allowed for auto traits, like `Send` and `Sync`
```
@estebank estebank deleted the negative-impl-span-ast branch November 9, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@estebank @Centril @bors @rust-highfive