-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update backtrace crate #69729
update backtrace crate #69729
Conversation
@bors r+ |
📌 Commit 22ee27b has been approved by |
update backtrace crate In particular this release includes rust-lang/backtrace-rs#297 and rust-lang/backtrace-rs#300.
Speculatively assigning blame for #69845 (comment) to this PR, @bors r- |
@alexcrichton looks like a macOS-only failure in this test:
This PR lands in particular rust-lang/backtrace-rs#300, which seems to do something with macOS symbol resolution. Here's the total libbacktrace diff. "signal: 10" looks exactly like #45731 is back. |
Hm, or maybe given that the fix back then was to disable mmap, maybe the issue is rust-lang/backtrace-rs#298. Cc @Aaron1011 |
@RalfJung: I find it odd that the OSX tests passed for my EDIT: It looks like mmap was explicitly disabled on on macOS in the past - I think we just need to add it to the |
Well, the test truncates some dSYM file. Maybe the backtrace crate does not do that. And yes, that's what I said above -- mmap was disabled on macOS precisely because of "signal 10 SIGBUS", and your PR probably re-enabled the macOS mmap implementation. |
@RalfJung: Ooos, I didn't see the link in your previous comment. |
@Aaron1011 so your proposal is to extend this check to also include macos targets? if target.contains("windows") || target.contains("macos") { |
upstream PR by @Aaron1011 already landed: rust-lang/backtrace-rs#302 |
@Mark-Simulacrum I bumped backtrace-sys, I think this is good to go again. |
@bors r+ |
📌 Commit 9552d2e has been approved by |
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
update backtrace crate In particular this release includes rust-lang/backtrace-rs#297 and rust-lang/backtrace-rs#300.
@bors p=1 |
☀️ Test successful - checks-azure |
In particular this release includes rust-lang/backtrace-rs#297 and rust-lang/backtrace-rs#300.