librustc_codegen_llvm: Use slices in preference to 0-terminated strings #69779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ecstatic-morse (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
| }; | ||
| // When empty, linkage_name field is omitted, | ||
| // which is what we want for no_mangle statics | ||
| let linkage_name = linkage_name.as_deref().unwrap_or(""); |
There was a problem hiding this comment.
Are the semantics of a null pointer vs an empty string documented somewhere?
There was a problem hiding this comment.
Both a null pointer and an empty string will create a StringRef representing an
empty sequence of bytes. At this point they are still distinguishable by
looking at the data pointer, although it would unusual to do so in StringRef
based API.
In this case, Name and LinkageName are turned into canonical MDStrings which
remove the distinction completely:
static MDString *getCanonicalMDString(LLVMContext &Context, StringRef S) {
if (S.empty())
return nullptr;
return MDString::get(Context, S);
}
|
Assuming the RefCell borrow order gets sorted out, this looks good to me. I'll r? @eddyb in case they want to review, since I don't own this code. In the future, it would be nice if you mentioned stuff like the invariants/constructors for |
|
r? @eddyb |
|
cc @nagisa @nikic @hanna-kruppe (Should we have a "LLVM team" for a ping like this?) |
nagisa
reviewed
Mar 7, 2020
src/rustllvm/RustWrapper.cpp
Outdated
| LLVMRustDIBuilderRef Builder, | ||
| const char *Filename, size_t FilenameLen, | ||
| const char *Directory, size_t DirectoryLen) { | ||
| return wrap(Builder->createFile({Filename, FilenameLen}, |
There was a problem hiding this comment.
Would it be perhaps be better to be explicit about what type (StringRef) is being created here? I'd find StringRef { Filename, FilenameLen } significantly easier to read (applies across this file).
There was a problem hiding this comment.
Repalced with StringRef(Name, NameLen) which I feel is more common in LLVM itself.
Additionally whenever possible match C API provided by the LLVM.
|
Rebased and converted two remaining uses of 0-terminated strings in debuginfo codegen: r? @nagisa |
|
@bors r+ |
|
📌 Commit e54a829 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2020
librustc_codegen_llvm: Use slices in preference to 0-terminated strings Additionally whenever possible match C API provided by the LLVM.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2020
librustc_codegen_llvm: Use slices in preference to 0-terminated strings Additionally whenever possible match C API provided by the LLVM.
bors
added a commit
that referenced
this pull request
Mar 9, 2020
Rollup of 6 pull requests Successful merges: - #69201 (Permit attributes on 'if' expressions) - #69402 (Extend search) - #69519 ( Don't use static crt by default when build proc-macro) - #69685 (unix: Don't override existing SIGSEGV/BUS handlers) - #69762 (Ensure that validity only raises validity errors) - #69779 (librustc_codegen_llvm: Use slices in preference to 0-terminated strings) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 9, 2020
librustc_codegen_llvm: Use slices in preference to 0-terminated strings Additionally whenever possible match C API provided by the LLVM.
bors
added a commit
that referenced
this pull request
Mar 9, 2020
Rollup of 6 pull requests Successful merges: - #69201 (Permit attributes on 'if' expressions) - #69685 (unix: Don't override existing SIGSEGV/BUS handlers) - #69762 (Ensure that validity only raises validity errors) - #69779 (librustc_codegen_llvm: Use slices in preference to 0-terminated strings) - #69801 (rustc_parse: Remove `Parser::normalized(_prev)_token`) - #69842 (Add more regression tests) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally whenever possible match C API provided by the LLVM.