fix #62456 #69859

contrun · 2020-03-09T16:13:49Z

rust-highfive · 2020-03-09T16:13:53Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2020-03-09T16:33:10Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-09T16:14:34.7384113Z Prepare build directory.
2020-03-09T16:14:34.7708255Z Set build variables.
2020-03-09T16:14:34.7739164Z Download all required tasks.
2020-03-09T16:14:34.7853082Z Downloading task: Bash (3.163.1)
2020-03-09T16:14:36.8633109Z Checking job knob settings.
2020-03-09T16:14:36.8652547Z Finished checking job knob settings.
2020-03-09T16:14:36.9239852Z ##[section]Finishing: Initialize job
2020-03-09T16:14:36.9586259Z ##[section]Starting: Configure Job Name
2020-03-09T16:14:36.9801012Z ==============================================================================
2020-03-09T16:14:36.9801840Z Task         : Bash
---
2020-03-09T16:14:37.6127258Z ========================== Starting Command Output ===========================
2020-03-09T16:14:37.6131165Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/b314ec7c-36a0-46ef-b4fe-2c88fd2490f0.sh
2020-03-09T16:14:37.6131657Z 
2020-03-09T16:14:37.6136907Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-09T16:14:37.6155920Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69859/merge to s
2020-03-09T16:14:37.6158962Z Task         : Get sources
2020-03-09T16:14:37.6159233Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-09T16:14:37.6159543Z Version      : 1.0.0
2020-03-09T16:14:37.6159724Z Author       : Microsoft
---
2020-03-09T16:14:38.8484071Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-09T16:14:38.8490310Z ##[command]git config gc.auto 0
2020-03-09T16:14:38.8493747Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-09T16:14:38.8498656Z ##[command]git config --get-all http.proxy
2020-03-09T16:14:38.8507039Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69859/merge:refs/remotes/pull/69859/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rust-highfive · 2020-03-09T18:08:35Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-09T17:52:12.4545021Z Prepare build directory.
2020-03-09T17:52:12.4882795Z Set build variables.
2020-03-09T17:52:12.4918587Z Download all required tasks.
2020-03-09T17:52:12.5039437Z Downloading task: Bash (3.163.1)
2020-03-09T17:52:13.5514503Z Checking job knob settings.
2020-03-09T17:52:13.5537329Z Finished checking job knob settings.
2020-03-09T17:52:13.6074923Z ##[section]Finishing: Initialize job
2020-03-09T17:52:13.6402526Z ##[section]Starting: Configure Job Name
2020-03-09T17:52:13.6609215Z ==============================================================================
2020-03-09T17:52:13.6609901Z Task         : Bash
---
2020-03-09T17:52:14.6932777Z ========================== Starting Command Output ===========================
2020-03-09T17:52:14.6935071Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/99cb2540-a66c-4f6f-b255-86df867a139f.sh
2020-03-09T17:52:14.6935299Z 
2020-03-09T17:52:14.6939407Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-09T17:52:14.6959168Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69859/merge to s
2020-03-09T17:52:14.6962458Z Task         : Get sources
2020-03-09T17:52:14.6962713Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-09T17:52:14.6962959Z Version      : 1.0.0
2020-03-09T17:52:14.6963170Z Author       : Microsoft
---
2020-03-09T17:52:16.0065055Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-09T17:52:16.0071415Z ##[command]git config gc.auto 0
2020-03-09T17:52:16.0074580Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-09T17:52:16.0078301Z ##[command]git config --get-all http.proxy
2020-03-09T17:52:16.0085305Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69859/merge:refs/remotes/pull/69859/merge
---
2020-03-09T17:57:50.3141741Z Done!
2020-03-09T17:57:50.3142017Z some tidy checks failed
2020-03-09T17:57:50.3142329Z 
2020-03-09T17:57:50.3142496Z 
2020-03-09T17:57:50.3143701Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2020-03-09T17:57:50.3154079Z 
2020-03-09T17:57:50.3154427Z 
2020-03-09T17:57:50.3154900Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2020-03-09T17:57:50.3155405Z Build completed unsuccessfully in 0:01:28
2020-03-09T17:57:50.3155405Z Build completed unsuccessfully in 0:01:28
2020-03-09T17:57:50.3202451Z == clock drift check ==
2020-03-09T17:57:50.3211883Z   local time: Mon Mar  9 17:57:50 UTC 2020
2020-03-09T17:57:50.5873868Z   network time: Mon, 09 Mar 2020 17:57:50 GMT
2020-03-09T17:57:50.5878215Z == end clock drift check ==
2020-03-09T17:57:51.3837889Z 
2020-03-09T17:57:51.3872397Z ##[error]Bash exited with code '1'.
2020-03-09T17:57:51.3886117Z ##[section]Finishing: Run build
2020-03-09T17:57:51.3930438Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69859/merge to s
2020-03-09T17:57:51.3936005Z Task         : Get sources
2020-03-09T17:57:51.3936370Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-09T17:57:51.3936728Z Version      : 1.0.0
2020-03-09T17:57:51.3936957Z Author       : Microsoft
2020-03-09T17:57:51.3936957Z Author       : Microsoft
2020-03-09T17:57:51.3937321Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-09T17:57:51.3937765Z ==============================================================================
2020-03-09T17:57:51.6975456Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-09T17:57:51.7015292Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69859/merge to s
2020-03-09T17:57:51.7111197Z Cleaning up task key
2020-03-09T17:57:51.7112608Z Start cleaning up orphan processes.
2020-03-09T17:57:51.7299335Z Terminate orphan process: pid (4600) (python)
2020-03-09T17:57:51.7441848Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

matthewjasper · 2020-03-09T19:24:34Z

src/librustc_typeck/check/expr.rs

+                );
+                tcx.types.err
+            }
+            _ => tcx.types.err,


Suggested change

_ => tcx.types.err,

Err(ErrorHandled::Reported) => tcx.types.err,

matthewjasper · 2020-03-09T19:26:25Z

src/librustc_typeck/check/expr.rs

@@ -22,7 +22,10 @@ use rustc::ty;
 use rustc::ty::adjustment::{Adjust, Adjustment, AllowTwoPhase, AutoBorrow, AutoBorrowMutability};
 use rustc::ty::Ty;
 use rustc::ty::TypeFoldable;
-use rustc::ty::{AdtKind, Visibility};
+use rustc::{
+    mir::interpret::ErrorHandled,


This should be in its own use item.

src/test/ui/const-generics/issues/issue-62456.rs

matthewjasper · 2020-03-09T19:35:00Z

r=me with comments addressed

rust-highfive · 2020-03-10T02:44:25Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-10T01:31:17.8158311Z ========================== Starting Command Output ===========================
2020-03-10T01:31:17.8161785Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/d2a031fb-63b5-442d-bf56-95103db49955.sh
2020-03-10T01:31:17.8162093Z 
2020-03-10T01:31:17.8166429Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-10T01:31:17.8187843Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69859/merge to s
2020-03-10T01:31:17.8191454Z Task         : Get sources
2020-03-10T01:31:17.8192581Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-10T01:31:17.8192923Z Version      : 1.0.0
2020-03-10T01:31:17.8193164Z Author       : Microsoft
---
2020-03-10T01:31:18.9635772Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-10T01:31:18.9648168Z ##[command]git config gc.auto 0
2020-03-10T01:31:18.9653692Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-10T01:31:18.9663191Z ##[command]git config --get-all http.proxy
2020-03-10T01:31:18.9676226Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69859/merge:refs/remotes/pull/69859/merge
---
2020-03-10T02:32:42.6693510Z .................................................................................................... 1700/9755
2020-03-10T02:32:47.2980532Z .................................................................................................... 1800/9755
2020-03-10T02:32:59.1331063Z ............................................................i....................................... 1900/9755
2020-03-10T02:33:06.8205721Z .................................................................................................... 2000/9755
2020-03-10T02:33:21.6053499Z ..................................................iiiii............................................. 2100/9755
2020-03-10T02:33:31.8768713Z .................................................................................................... 2300/9755
2020-03-10T02:33:34.1120900Z .................................................................................................... 2400/9755
2020-03-10T02:33:37.3984821Z .................................................................................................... 2500/9755
2020-03-10T02:33:59.2932723Z .................................................................................................... 2600/9755
---
2020-03-10T02:36:42.0014837Z .....................i...............i.............................................................. 5000/9755
2020-03-10T02:36:52.0933921Z .................................................................................................... 5100/9755
2020-03-10T02:36:57.6940039Z ................................................................i................................... 5200/9755
2020-03-10T02:37:03.9965253Z .................................................F.................................................. 5300/9755
2020-03-10T02:37:13.2330710Z .............................................ii.ii........i...i..................................... 5400/9755
2020-03-10T02:37:21.4615850Z .................................................................................................... 5600/9755
2020-03-10T02:37:31.3128527Z .................................................................................................... 5700/9755
2020-03-10T02:37:38.3445253Z ....................................i............................................................... 5800/9755
2020-03-10T02:37:44.5324787Z .................................................................................................... 5900/9755
2020-03-10T02:37:44.5324787Z .................................................................................................... 5900/9755
2020-03-10T02:37:55.3178122Z .................................................................................................... 6000/9755
2020-03-10T02:38:04.4985656Z .............................ii...i..ii...........i................................................. 6100/9755
2020-03-10T02:38:21.6155639Z .................................................................................................... 6300/9755
2020-03-10T02:38:28.2494638Z .................................................................................................... 6400/9755
2020-03-10T02:38:28.2494638Z .................................................................................................... 6400/9755
2020-03-10T02:38:39.7146614Z ............................................................i..ii................................... 6500/9755
2020-03-10T02:39:11.7936707Z .................................................................................................... 6700/9755
2020-03-10T02:39:15.4754166Z ......................................................i............................................. 6800/9755
2020-03-10T02:39:17.6070723Z .................................................................................................... 6900/9755
2020-03-10T02:39:20.2144393Z .....................................................................................i.............. 7000/9755
---
2020-03-10T02:40:58.8512904Z .................................................................................................... 7700/9755
2020-03-10T02:41:02.9280765Z .................................................................................................... 7800/9755
2020-03-10T02:41:08.7294082Z .................................................................................................... 7900/9755
2020-03-10T02:41:15.5928043Z ...................................i................................................................ 8000/9755
2020-03-10T02:41:24.4577237Z ....................................................................................iiiiiiiiii.i.... 8100/9755
2020-03-10T02:41:40.0657004Z ............................i......i................................................................ 8300/9755
2020-03-10T02:41:44.7552406Z .................................................................................................... 8400/9755
2020-03-10T02:41:55.8527308Z .................................................................................................... 8500/9755
2020-03-10T02:42:07.5533650Z .................................................................................................... 8600/9755
---
2020-03-10T02:44:05.5167711Z 
2020-03-10T02:44:05.5168904Z ---- [ui] ui/issues/issue-69602-type-err-during-codegen-ice.rs stdout ----
2020-03-10T02:44:05.5169377Z diff of stderr:
2020-03-10T02:44:05.5169625Z 
2020-03-10T02:44:05.5169922Z 13 LL | impl TraitB for B {
2020-03-10T02:44:05.5170308Z 14    | ^^^^^^^^^^^^^^^^^ missing `MyA` in implementation
2020-03-10T02:44:05.5171229Z - error: aborting due to 2 previous errors
2020-03-10T02:44:05.5171914Z + error: array lengths can't depend on generic parameters
2020-03-10T02:44:05.5172663Z +   --> $DIR/issue-69602-type-err-during-codegen-ice.rs:21:17
2020-03-10T02:44:05.5173088Z +    |
2020-03-10T02:44:05.5173088Z +    |
2020-03-10T02:44:05.5173401Z + LL |     let _ = [0; B::VALUE];
2020-03-10T02:44:05.5174071Z + 
2020-03-10T02:44:05.5174378Z + error: aborting due to 3 previous errors
2020-03-10T02:44:05.5174699Z 17 
2020-03-10T02:44:05.5175049Z 18 Some errors have detailed explanations: E0046, E0437.
2020-03-10T02:44:05.5175049Z 18 Some errors have detailed explanations: E0046, E0437.
2020-03-10T02:44:05.5175947Z 19 For more information about an error, try `rustc --explain E0046`.
2020-03-10T02:44:05.5176369Z 
2020-03-10T02:44:05.5176574Z 
2020-03-10T02:44:05.5178241Z The actual stderr differed from the expected stderr.
2020-03-10T02:44:05.5180729Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-69602-type-err-during-codegen-ice/issue-69602-type-err-during-codegen-ice.stderr
2020-03-10T02:44:05.5182987Z To update references, rerun the tests and pass the `--bless` flag
2020-03-10T02:44:05.5199674Z To only update this specific test, also pass `--test-args issues/issue-69602-type-err-during-codegen-ice.rs`
2020-03-10T02:44:05.5221752Z error: 1 errors occurred comparing output.
2020-03-10T02:44:05.5222117Z status: exit code: 1
2020-03-10T02:44:05.5222117Z status: exit code: 1
2020-03-10T02:44:05.5224594Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-69602-type-err-during-codegen-ice.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-69602-type-err-during-codegen-ice" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-69602-type-err-during-codegen-ice/auxiliary"
2020-03-10T02:44:05.5226967Z ------------------------------------------
2020-03-10T02:44:05.5227301Z 
2020-03-10T02:44:05.5227818Z ------------------------------------------
2020-03-10T02:44:05.5228188Z stderr:
2020-03-10T02:44:05.5228188Z stderr:
2020-03-10T02:44:05.5228706Z ------------------------------------------
2020-03-10T02:44:05.5229144Z error[E0437]: type `M` is not a member of trait `TraitB`
2020-03-10T02:44:05.5231112Z   --> /checkout/src/test/ui/issues/issue-69602-type-err-during-codegen-ice.rs:17:5
2020-03-10T02:44:05.5231590Z    |
2020-03-10T02:44:05.5231981Z LL |     type M   = A; //~ ERROR type `M` is not a member of trait `TraitB`
2020-03-10T02:44:05.5232429Z    |     ^^^^^^^^^^^^^ not a member of trait `TraitB`
2020-03-10T02:44:05.5233117Z error[E0046]: not all trait items implemented, missing: `MyA`
2020-03-10T02:44:05.5233977Z   --> /checkout/src/test/ui/issues/issue-69602-type-err-during-codegen-ice.rs:16:1
2020-03-10T02:44:05.5235083Z    |
2020-03-10T02:44:05.5235083Z    |
2020-03-10T02:44:05.5235281Z LL |     type MyA: TraitA;
2020-03-10T02:44:05.5235784Z    |     ----------------- `MyA` from trait
2020-03-10T02:44:05.5235983Z ...
2020-03-10T02:44:05.5236280Z LL | impl TraitB for B { //~ ERROR not all trait items implemented, missing: `MyA`
2020-03-10T02:44:05.5236641Z    | ^^^^^^^^^^^^^^^^^ missing `MyA` in implementation
2020-03-10T02:44:05.5237243Z error: array lengths can't depend on generic parameters
2020-03-10T02:44:05.5237829Z   --> /checkout/src/test/ui/issues/issue-69602-type-err-during-codegen-ice.rs:21:17
2020-03-10T02:44:05.5238117Z    |
2020-03-10T02:44:05.5238117Z    |
2020-03-10T02:44:05.5238321Z LL |     let _ = [0; B::VALUE];
2020-03-10T02:44:05.5238697Z 
2020-03-10T02:44:05.5238888Z error: aborting due to 3 previous errors
2020-03-10T02:44:05.5239074Z 
2020-03-10T02:44:05.5239298Z Some errors have detailed explanations: E0046, E0437.
---
2020-03-10T02:44:05.5245854Z test result: FAILED. 9697 passed; 1 failed; 57 ignored; 0 measured; 0 filtered out
2020-03-10T02:44:05.5246146Z 
2020-03-10T02:44:05.5246239Z 
2020-03-10T02:44:05.5246330Z 
2020-03-10T02:44:05.5250137Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-03-10T02:44:05.5252853Z 
2020-03-10T02:44:05.5252952Z 
2020-03-10T02:44:05.5253204Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-03-10T02:44:05.5253534Z Build completed unsuccessfully in 1:06:56
2020-03-10T02:44:05.5253534Z Build completed unsuccessfully in 1:06:56
2020-03-10T02:44:05.5254168Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-03-10T02:44:05.5254598Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-03-10T02:44:05.5287738Z == clock drift check ==
2020-03-10T02:44:05.5303619Z   local time: Tue Mar 10 02:44:05 UTC 2020
2020-03-10T02:44:05.8140553Z   network time: Tue, 10 Mar 2020 02:44:05 GMT
2020-03-10T02:44:05.8143292Z == end clock drift check ==
2020-03-10T02:44:06.2393404Z 
2020-03-10T02:44:06.2471518Z ##[error]Bash exited with code '1'.
2020-03-10T02:44:06.2485618Z ##[section]Finishing: Run build
2020-03-10T02:44:06.2545937Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69859/merge to s
2020-03-10T02:44:06.2550724Z Task         : Get sources
2020-03-10T02:44:06.2551092Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-10T02:44:06.2551406Z Version      : 1.0.0
2020-03-10T02:44:06.2551624Z Author       : Microsoft
2020-03-10T02:44:06.2551624Z Author       : Microsoft
2020-03-10T02:44:06.2551986Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-10T02:44:06.2552392Z ==============================================================================
2020-03-10T02:44:06.5891657Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-10T02:44:06.5940700Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/69859/merge to s
2020-03-10T02:44:06.6028643Z Cleaning up task key
2020-03-10T02:44:06.6029878Z Start cleaning up orphan processes.
2020-03-10T02:44:06.6212976Z Terminate orphan process: pid (3779) (python)
2020-03-10T02:44:06.6423906Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

matthewjasper · 2020-03-10T08:29:13Z

@bors r+ rollup

bors · 2020-03-10T08:29:14Z

📌 Commit 0a0c850 has been approved by matthewjasper

bors · 2020-03-10T08:29:15Z

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

fix rust-lang#62456 closes rust-lang#62456

@ghost

Rollup of 6 pull requests Successful merges: - #69122 (Backtrace Debug tweaks) - #69591 (Use TypeRelating for instantiating query responses) - #69760 (Improve expression & attribute parsing) - #69837 (Use smaller discriminants for generators) - #69838 (Expansion-driven outline module parsing) - #69859 (fix #62456) Failed merges: r? @ghost

fix rust-lang#62456 closes rust-lang#62456

@ghost

Rollup of 10 pull requests Successful merges: - #66059 (mem::zeroed/uninit: panic on types that do not permit zero-initialization) - #69373 (Stabilize const for integer {to,from}_{be,le,ne}_bytes methods) - #69591 (Use TypeRelating for instantiating query responses) - #69625 (Implement nth, last, and count for iter::Copied) - #69645 (const forget tests) - #69766 (Make Point `Copy` in arithmetic documentation) - #69825 (make `mem::discriminant` const) - #69859 (fix #62456) - #69891 (Exhaustiveness checking, `Matrix::push`: recursively expand or-patterns) - #69896 (parse: Tweak the function parameter edition check) Failed merges: r? @ghost

rust-highfive assigned matthewjasper Mar 9, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2020

contrun force-pushed the fix-62456 branch 2 times, most recently from 34bba6c to 9100035 Compare March 9, 2020 17:51

matthewjasper reviewed Mar 9, 2020

View reviewed changes

src/test/ui/const-generics/issues/issue-62456.rs Show resolved Hide resolved

fix rust-lang#62456

906bb8d

contrun force-pushed the fix-62456 branch from 9100035 to 906bb8d Compare March 10, 2020 01:30

fix test failure due to earlier emitted error

0a0c850

Centril added the F-const_generics `#![feature(const_generics)]` label Mar 10, 2020

contrun requested a review from matthewjasper March 10, 2020 08:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2020

Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2020

Rollup merge of rust-lang#69859 - contrun:fix-62456, r=matthewjasper

9d93aa1

fix rust-lang#62456 closes rust-lang#62456

Centril mentioned this pull request Mar 10, 2020

Rollup of 6 pull requests #69883

Closed

Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2020

Rollup merge of rust-lang#69859 - contrun:fix-62456, r=matthewjasper

5d10555

fix rust-lang#62456 closes rust-lang#62456

Centril mentioned this pull request Mar 10, 2020

Rollup of 6 pull requests #69884

Closed

Centril added a commit to Centril/rust that referenced this pull request Mar 11, 2020

Rollup merge of rust-lang#69859 - contrun:fix-62456, r=matthewjasper

b024bbc

fix rust-lang#62456 closes rust-lang#62456

Centril mentioned this pull request Mar 11, 2020

Rollup of 10 pull requests #69909

Closed

Centril mentioned this pull request Mar 11, 2020

Rollup of 10 pull requests #69914

Merged

bors merged commit 62e3dae into rust-lang:master Mar 11, 2020

contrun deleted the fix-62456 branch March 11, 2020 12:58

This was referenced Mar 12, 2020

ICE w/ const_generics when trying to use the size of an associated type size as an array length #67739

Closed

ICE (const generics) with const generics in trait #62504

Closed

varkor mentioned this pull request Jul 22, 2020

Tracking issue for const generics (RFC 2000) #44580

Closed

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix #62456 #69859

fix #62456 #69859

contrun commented Mar 9, 2020

rust-highfive commented Mar 9, 2020

rust-highfive commented Mar 9, 2020

rust-highfive commented Mar 9, 2020

matthewjasper Mar 9, 2020

matthewjasper Mar 9, 2020

matthewjasper commented Mar 9, 2020

rust-highfive commented Mar 10, 2020

matthewjasper commented Mar 10, 2020

bors commented Mar 10, 2020

bors commented Mar 10, 2020

	_ => tcx.types.err,
	Err(ErrorHandled::Reported) => tcx.types.err,

fix #62456 #69859

fix #62456 #69859

Conversation

contrun commented Mar 9, 2020

rust-highfive commented Mar 9, 2020

rust-highfive commented Mar 9, 2020

rust-highfive commented Mar 9, 2020

matthewjasper Mar 9, 2020

Choose a reason for hiding this comment

matthewjasper Mar 9, 2020

Choose a reason for hiding this comment

matthewjasper commented Mar 9, 2020

rust-highfive commented Mar 10, 2020

matthewjasper commented Mar 10, 2020

bors commented Mar 10, 2020

bors commented Mar 10, 2020