Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triagebot.toml: add ping aliases #69949

Merged
merged 2 commits into from
Mar 13, 2020
Merged

triagebot.toml: add ping aliases #69949

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
118003d
triagebot.toml: add ping aliases
Centril Mar 12, 2020
90e8058
triagebot.toml: add typo aliases
Centril Mar 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions triagebot.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ allow-unauthenticated = [
[assign]

[ping.icebreakers-llvm]
alias = ["llvm"]
message = """\
Hey LLVM ICE-breakers! This bug has been identified as a good
"LLVM ICE-breaking candidate". In case it's useful, here are some
Expand All @@ -22,6 +23,7 @@ Thanks! <3
label = "ICEBreaker-LLVM"

[ping.icebreakers-cleanup-crew]
alias = ["cleanup", "shrink", "reduce", "bisect"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally prefer that we avoid adding all the aliases we can think of - is cleanup not enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were more that I thought of... ;) ...but these were the ones which I associate the task with most closely, i.e. I associate the actual work more closely with bisecting or shrinking than with "cleanup" (which I also associate with C-cleanup, and that isn't what this is about). Imo having more aliases which aren't misleading means folks are more likely to get the bot to do what they want. (It's good to make the bot fault tolerant, e.g. cleanups (with the s at the end) would be a good extension I think.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to try to make the code itself fault tolerant in that respect, but I suppose I can buy this argument. Could you add cleanups and such as well then? r=me with that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added "llvms" and "cleanups". We can add more variations if people make those mistakes. :)

message = """\
Hey Cleanup Crew ICE-breakers! This bug has been identified as a good
"Cleanup ICE-breaking candidate". In case it's useful, here are some
Expand Down