Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #70034

Merged
merged 23 commits into from
Mar 16, 2020
Merged

Rollup of 8 pull requests #70034

merged 23 commits into from
Mar 16, 2020

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

da-x and others added 23 commits March 9, 2020 18:23
This should allow the `rustdoc-js` and `rustdoc-js-std` test suites to run automatically on PRs.
Stable, beta and nightly URLs remain
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
Co-Authored-By: Dylan DPC <dylan.dpc@gmail.com>
…umeGomez

Use `pprust` to print attributes in rustdoc

Fixes rust-lang#69559.

I'm not sure what the original motivation was for the `render_attribute`, so I may be missing something, but replacing it with `pprust::attribute_to_string` seems to give the intended output (modulo some spacing idiosyncrasies).

r? @GuillaumeGomez
std: on Windows, use GetSystemTimePreciseAsFileTime if it is available

This implements rust-lang#67266.
…m,GuillaumeGomez

Add Node.js to PR CI image

This should allow the `rustdoc-js` and `rustdoc-js-std` test suites to run automatically on PRs.
Block version-specific docs from search engines

Latest stable, beta and nightly URLs remain accessible because their URLs don't start with a version number. Robots.txt uses simple path prefixes, so it's OK that the disallow rules aren't full directory paths.

Direct links to old docs remain accessible to users, because robots.txt only affects crawlers.

With this change old docs for specific old versions of Rust won't pop up in search results. This is good, because users won't be getting obsolete documentation by accident.
…flow, r=ecstatic-morse

Add more context to the literal overflow message

related to issue rust-lang#63733
…error-code-e0634, r=Dylan-DPC,GuillaumeGomez

Add long error explanation for E0634

Add long explanation for the E0634 error code
Part of rust-lang#61137

r? @GuillaumeGomez
…ok, r=Dylan-DPC

Small fixes in rustdoc book

I read the `rustdoc` book today and noticed some small typos/problems. Mainly:

 - `# fn foo() {}` was displayed when not needed because fenced block code type was `text` instead of `rust`;
 - two path separators were missing and some Windows-style separators were not consistent with the rest of them (mainly Linux-style).

Here are my proposed fixes. It is my first PR for the rust project. Don't hesitate to tell me if I am doing it wrong or if you need anything else.

Have a nice day!
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=8

@bors
Copy link
Contributor

bors commented Mar 16, 2020

📌 Commit 6b50a4c has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 16, 2020
@bors
Copy link
Contributor

bors commented Mar 16, 2020

⌛ Testing commit 6b50a4c with merge 97eda01...

@bors
Copy link
Contributor

bors commented Mar 16, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing 97eda01 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 16, 2020
@bors bors merged commit 97eda01 into rust-lang:master Mar 16, 2020
@bors bors mentioned this pull request Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.