rustc_mir: remove extra space when pretty-printing MIR. #70080
Conversation
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @oli-obk |
| @@ -114,7 +114,7 @@ fn main() { | |||
| // } | |||
| // END rustc.main-{{closure}}.EraseRegions.after.mir | |||
| // START rustc.ptr-drop_in_place.Test.SimplifyCfg-make_shim.after.mir | |||
| // fn std::intrinsics::drop_in_place(_1: *mut Test) -> () { | |||
There was a problem hiding this comment.
I don't get how this is the only test affected. Shouldn't
have been printing the space before this PR, too?There was a problem hiding this comment.
also I just saw that my linked thing is missing a space in the end... Maybe MIR opt tests ignore whitespaces even in the middle of things?
There was a problem hiding this comment.
Maybe MIR opt tests ignore whitespaces even in the middle of things?
We were confused by this too, I think that's the case, and I'd rather it not.
There was a problem hiding this comment.
If we move loads of mir-opt tests to the blessable system the leftover cases that still want to use the manual system should be few enough for that to be doable in a painless way.
|
@bors r+ rollup Not testable right now, but improves mir printing output |
|
📌 Commit 7d40019 has been approved by |
bors
added
S-waiting-on-bors
rustc_mir: remove extra space when pretty-printing MIR.
Rollup of 9 pull requests Successful merges: - rust-lang#68700 (Add Wake trait for safe construction of Wakers.) - rust-lang#69494 (Stabilize --crate-version option in rustdoc) - rust-lang#70080 (rustc_mir: remove extra space when pretty-printing MIR.) - rust-lang#70195 (Add test for issue rust-lang#53275) - rust-lang#70199 (Revised span-to-lines conversion to produce an empty vec on DUMMY_SP.) - rust-lang#70299 (add err_machine_stop macro) - rust-lang#70300 (Reword unused variable warning) - rust-lang#70315 (Rename remaining occurences of Void to Opaque.) - rust-lang#70318 (Split long derive lists into two derive attributes.) Failed merges: r? @ghost
No description provided.