rustc: use LocalDefId instead of DefId in TypeckTables. #70119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
bors
added
the
S-waiting-on-author
eddyb
force-pushed
the
typeck-tables-local-def-id
branch
from
8868226 to
8c93a29
Compare
eddyb
commented
Mar 19, 2020
Comment on lines
-735
to
-740
| let var_owner_def_id = DefId { | ||
| krate: local_id_root.krate, | ||
| index: var_path.hir_id.owner.local_def_index, | ||
| }; | ||
| let closure_def_id = | ||
| DefId { krate: local_id_root.krate, index: closure_expr_id.local_def_index }; |
There was a problem hiding this comment.
This is specifically what I kept seeing while working on #66131, and it started to bother me.
This comment has been minimized.
This comment has been minimized.
petrochenkov
added
S-blocked
eddyb
force-pushed
the
typeck-tables-local-def-id
branch
from
8c93a29 to
06d723a
Compare
eddyb
force-pushed
the
typeck-tables-local-def-id
branch
from
06d723a to
f8178c7
Compare
eddyb
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit f8178c7 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#69497 (Don't unwind when hitting the macro expansion recursion limit) - rust-lang#69901 (add #[rustc_layout(debug)]) - rust-lang#69910 (Avoid query type in generics) - rust-lang#69955 (Fix abort-on-eprintln during process shutdown) - rust-lang#70032 (put type params in front of const params in generics_of) - rust-lang#70119 (rustc: use LocalDefId instead of DefId in TypeckTables.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in
TypeckTables' implementation ofHashStable, which createdDefIds by combining aCrateNumfrom aDefIdand aDefIndexfrom aLocalDefId, bothered me a bit.I don't know how much this matters, but it works so might as well submit it.