Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #70246

Merged
merged 21 commits into from
Mar 22, 2020
Merged

Rollup of 10 pull requests #70246

merged 21 commits into from
Mar 22, 2020

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

pnkfelix and others added 21 commits March 20, 2020 13:56
Namely, this version focuses on the end-to-end behavior that the attempt to
create the UDP binding will fail, regardless of the semantics of how particular
DNS servers handle junk inputs.

(I spent some time trying to create a second more-focused test that would
sidestep the DNS resolution, but this is not possible without more invasive
changes to the internal infrastructure of `ToSocketAddrs` and what not. It is
not worth it.)
Also stop encoding/decoding it entirely
…r=nikomatsakis

symbol_names: treat ReifyShim like VtableShim.

Without this, the `#[track_caller]` tests don't pass with `-Zsymbol-mangling-version=v0`, because there is a symbol name collision between the `ReifyShim` and the original definition.

cc @anp
…um_discr, r=RalfJung,eddyb

Fix ICE caused by truncating a negative ZST enum discriminant

Fixes rust-lang#70114

r? @oli-obk or @RalfJung
…-23076, r=LukasKalbertodt

For issue 53957: revise unit test to focus on underlying bug of 23076.

Fix rust-lang#53957 by revising unit test to focus on underlying bug of rust-lang#23076.

Namely, this version focuses on the end-to-end behavior that the attempt to create the UDP binding will fail, regardless of the semantics of how particular DNS servers handle junk inputs.

(I spent some time trying to create a second more-focused test that would sidestep the DNS resolution, but this is not possible without more invasive changes to the internal infrastructure of `ToSocketAddrs` and what not. It is not worth it.)
ast: Compress `AttrId` from `usize` to `u32`

An easy size win for `ast::Attribute` (96 bytes -> 88 bytes).

Also stop encoding/decoding `AttrId` entirely.
…, r=jonas-schievink

Fix deprecated Error.description() usage in docs
Remove CARGO_BUILD_TARGET from bootstrap.py

Closes rust-lang#70208
Add explanation message for E0224

Addresses some of rust-lang#61137
Tweak wording for std::io::Read::read function

I think the sentence as a whole reads smoother that way.
Add a test for out-of-line module passed through a proc macro

Closes rust-lang#58818.
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=10

@bors
Copy link
Contributor

bors commented Mar 21, 2020

📌 Commit 17e6ed1 has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 21, 2020
@bors
Copy link
Contributor

bors commented Mar 21, 2020

⌛ Testing commit 17e6ed1 with merge c6b172f...

@Dylan-DPC-zz Dylan-DPC-zz added the rollup A PR which is a rollup label Mar 21, 2020
@bors
Copy link
Contributor

bors commented Mar 22, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing c6b172f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 22, 2020
@bors bors merged commit c6b172f into rust-lang:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.