-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rid of ConstPropUnsupported; use ZST marker structs instead #70267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Mar 22, 2020
RalfJung
force-pushed
the
const-prop-unsup
branch
from
March 22, 2020 10:44
a20fc05
to
a239b4e
Compare
RalfJung
force-pushed
the
const-prop-unsup
branch
from
March 22, 2020 11:16
a239b4e
to
82f4a1a
Compare
RalfJung
commented
Mar 22, 2020
oli-obk
reviewed
Mar 22, 2020
@wesleywiser might be an alternative reviewer for this PR? |
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
const-prop-unsup
branch
from
March 22, 2020 19:38
cabe8b3
to
bcd8acb
Compare
oli-obk
reviewed
Mar 22, 2020
RalfJung
force-pushed
the
const-prop-unsup
branch
from
March 22, 2020 21:43
bcd8acb
to
cda81da
Compare
wesleywiser
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a macro to avoid boilerplate seems like a good idea but this is a nice improvement even without that.
RalfJung
force-pushed
the
const-prop-unsup
branch
from
March 23, 2020 10:02
abf8de3
to
410385d
Compare
@bors r=oli-obk,wesleywiser |
📌 Commit e619b85 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 23, 2020
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 23, 2020
…k,wesleywiser get rid of ConstPropUnsupported; use ZST marker structs instead This gets rid of yet another machine-specific error variant. r? @oli-obk
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 23, 2020
…k,wesleywiser get rid of ConstPropUnsupported; use ZST marker structs instead This gets rid of yet another machine-specific error variant. r? @oli-obk
This was referenced Mar 23, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 24, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#67761 (Move the dep_graph construction to a dedicated crate.) - rust-lang#69740 (Replace some desc logic in librustc_lint with article_and_desc) - rust-lang#69981 (Evaluate repeat expression lengths as late as possible) - rust-lang#70087 (Remove const eval loop detector) - rust-lang#70242 (Improve E0308 error message wording) - rust-lang#70264 (Fix invalid suggestion on `&mut` iterators yielding `&` references) - rust-lang#70267 (get rid of ConstPropUnsupported; use ZST marker structs instead) - rust-lang#70277 (Remove `ReClosureBound`) - rust-lang#70283 (Add regression test for rust-lang#70155.) - rust-lang#70294 (Account for bad placeholder types in where clauses) - rust-lang#70309 (Clean up E0452 explanation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of yet another machine-specific error variant.
r? @oli-obk