Removing internal iterators, part 3 #7032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Jun 10, 2013
Continuation of #7015, and #6995. Rewrites the character-based `each_split` functions in `str` to use an iterator, removes a few redundant methods, and replaces all uses of `len`, `is_empty` and `slice` functions with the methods (and deletes the the functions). Update: Ok, this has turned into a major makeover for `str`, turning a lot of functions into methods, and removing redundant ones. Each commit is essentially a single such change. (Unscientific benchmarks suggest that the external `split_iter` is approximately 10% faster than the internal one. I'm not quite sure why this would be true.) (@thestinger is probably interested in this.)
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 22, 2021
Fix FP in `wrong_self_convention` lint Previously, this lint didn't check into impl block when it was implementing a trait. Recent improvements (rust-lang#6924) have moved this check and some impl blocks are now checked but they shouldn't, such as in rust-lang#7032. Fixes rust-lang#7032 changelog: Fix FP when not taking `self` in impl block for `wrong_self_convention` lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #7015, and #6995.
Rewrites the character-based
each_splitfunctions instrto use an iterator, removes a few redundant methods, and replaces all uses oflen,is_emptyandslicefunctions with the methods (and deletes the the functions).Update: Ok, this has turned into a major makeover for
str, turning a lot of functions into methods, and removing redundant ones. Each commit is essentially a single such change.(Unscientific benchmarks suggest that the external
split_iteris approximately 10% faster than the internal one. I'm not quite sure why this would be true.)(@thestinger is probably interested in this.)