Fix smaller issues with invalid placeholder type errors #70369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Mar 24, 2020
Centril
added
S-waiting-on-author
|
r=me with ^-- addressed. |
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
bad-placeholder-in-where
branch
from
ad58502
to
41d4a45
Compare
estebank
force-pushed
the
bad-placeholder-in-where
branch
from
41d4a45
to
7534efa
Compare
estebank
added
the
beta-nominated
|
📌 Commit 7534efa has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 25, 2020
…r=Centril Fix smaller issues with invalid placeholder type errors Follow up to rust-lang#70294. - Fix placement of suggested generic param when bounds are present. - Reduce error duplication for invalid placeholder types in `fn` types. r? @Centril
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#70331 (Increase verbosity when using update syntax with private fields) - rust-lang#70349 (move `hir_id_validation` to `rustc_passes` + simplify `hir::map` code) - rust-lang#70361 (Update backtrace crate to 0.3.46) - rust-lang#70364 (resolve: Remove `rustc_attrs` as a standalone feature gate) - rust-lang#70369 (Fix smaller issues with invalid placeholder type errors) - rust-lang#70373 (normalize some imports & prefer direct ones) - rust-lang#70376 (Add test for rust-lang#66312) Failed merges: r? @ghost
Centril
added
the
T-compiler
|
Discussed in compiler meeting. Declined for beta backport. |
pnkfelix
removed
the
beta-nominated
davidtwco
added a commit
to davidtwco/rust
that referenced
this pull request
Jul 12, 2020
This commit fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available. Signed-off-by: David Wood <david@davidtw.co>
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 13, 2020
…der-type-error, r=estebank typeck: report placeholder type error w/out span Fixes rust-lang#74086. This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available. r? @estebank
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 13, 2020
…der-type-error, r=estebank typeck: report placeholder type error w/out span Fixes rust-lang#74086. This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available. r? @estebank
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 13, 2020
…der-type-error, r=estebank typeck: report placeholder type error w/out span Fixes rust-lang#74086. This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available. r? @estebank
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 13, 2020
…der-type-error, r=estebank typeck: report placeholder type error w/out span Fixes rust-lang#74086. This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available. r? @estebank
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 14, 2020
…der-type-error, r=estebank typeck: report placeholder type error w/out span Fixes rust-lang#74086. This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available. r? @estebank
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 14, 2020
…der-type-error, r=estebank typeck: report placeholder type error w/out span Fixes rust-lang#74086. This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available. r? @estebank
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 14, 2020
…der-type-error, r=estebank typeck: report placeholder type error w/out span Fixes rust-lang#74086. This PR fixes a regression introduced in rust-lang#70369 which meant that an error was not being emitted for invalid placeholder types when there wasn't a span available. r? @estebank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #70294.
fntypes.r? @Centril